Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Architecture] Do sync framework integration in a separate class #1115

Closed
rfc2822 opened this issue Nov 1, 2024 · 1 comment · Fixed by #1137
Closed

[Architecture] Do sync framework integration in a separate class #1115

rfc2822 opened this issue Nov 1, 2024 · 1 comment · Fixed by #1137
Assignees
Labels
refactoring Internal improvement of existing functions

Comments

@rfc2822
Copy link
Member

rfc2822 commented Nov 1, 2024

Create a new class for SyncFrameworkIntegration, which is used for all sync framework integration (for contacts, calendars etc.) Goal is that other classes never call ContentResolver.setIsSyncable() or something like that themselves. Everything sync-framework related must be handled by this class.

The sync framework must only be used to get notified about changed content provider entries. All other users should be disabled by the new class (like current behaviour).

It should also be kept in mind that if we would ever like to change the notification of changed content provider entries to JobScheduler / WorkManager (https://github.com/bitfireAT/davx5/issues/247), it should be possible by adapting mainly this class.

@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Nov 1, 2024
@rfc2822 rfc2822 changed the title Create a new class for SyncFrameworkIntegration, which is used for all sync framework integration (for contacts, calendars etc.) Goal is that other classes never call ContentResolver.setIsSyncable() or something like that themselves. Everything sync-framework related must be handled by this class. [Architecture] Do sync framework integration in a separate class Nov 1, 2024
@sunkup sunkup self-assigned this Nov 21, 2024
@sunkup sunkup linked a pull request Nov 21, 2024 that will close this issue
4 tasks
@rfc2822
Copy link
Member Author

rfc2822 commented Nov 25, 2024

Maybe related to #626 (if we need to return the sync result to the sync framework or something like that)

@github-project-automation github-project-automation bot moved this from Todo to Done in DAVx⁵ Releases Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants