Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client is only exported when proxy feature is enabled. #91

Open
tnull opened this issue Dec 14, 2022 · 2 comments · May be fixed by #143
Open

Client is only exported when proxy feature is enabled. #91

tnull opened this issue Dec 14, 2022 · 2 comments · May be fixed by #143

Comments

@tnull
Copy link
Contributor

tnull commented Dec 14, 2022

Currently, the default features are ["use-rustls", "proxy"]. As I have no immediate use for a socks proxy, I tried disabling this feature, with the result that crate::client is not exported anymore, see here:

#[cfg(any(
all(feature = "proxy", feature = "use-openssl"),
all(feature = "proxy", feature = "use-rustls")
))]
pub mod client;

Not sure if that is intended, but if "proxy" is indeed mandatory, it's unclear to me why it's a feature in the first place?

@tnull
Copy link
Contributor Author

tnull commented Oct 26, 2023

Recently stumbled across this again when implementing Electrum syncing for LDK. Would be great to get a resolution here: is proxy mandatory, if so, why is it a feature to begin with?

@thunderbiscuit
Copy link
Member

See #143

@notmandatory notmandatory removed this from the Release 0.20.0 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants