Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to pass their own custom rustls::crypto::CryptoProvider #140

Closed
oleonardolima opened this issue Aug 6, 2024 · 1 comment
Closed

Comments

@oleonardolima
Copy link
Collaborator

oleonardolima commented Aug 6, 2024

As mentioned by Lloyd's in #135 the ideal solution would be to allow users to pass their own custom CryptoProvider.

We decided not to make this change part of the PR, but handle it as a standalone issue/PR.

I started addressing it in #138

Can we just expose the rustls provider API here: https://docs.rs/rustls/latest/rustls/crypto/struct.CryptoProvider.html so I can pass in my own provider?
We can have a rustls-aws-lc feature that adds a constructor that uses that. Can do the same for rustls-ring. But I'd like to able to fix this kind of issue in the future without having to wait for a merge.

Originally posted by @LLFourn in #135 (comment)

@oleonardolima
Copy link
Collaborator Author

Oh, I didn't notice we already had #137, closing this one in favor of #137.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant