-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address gap limit? #1577
Labels
Milestone
Comments
evanlinjin
added
bug
Something isn't working
discussion
There's still a discussion ongoing
labels
Aug 27, 2024
5 tasks
Is this fixed by #1579 ? |
This is an issue about a new feature that would stop revealing new addresses passed the stop gap. It's related to #1579 as it would have softened the problem for the user who doesn't called |
If this a new feature request can we move it out of the 1.0 beta milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the situation
An undisclosed user of ours ran into an issue where creating multiple unbroadcasted transactions resulted in incrementing the revealed index for the internal keychain too rapidly. Eventually, the gap of unused addresses surpassed the
stop_gap
set for the spk-based chain source, thus some transactions were not caught by the syncing process.This is caused by
Wallet::create_tx
which marks change addresses as used.bdk/crates/wallet/src/wallet/mod.rs
Line 1460 in 775e4ae
The correct use of the current API would be to call
Wallet::cancel_tx
. However, I would argue that this is unwieldy and not immediately apparent.bdk/crates/wallet/src/wallet/mod.rs
Line 1963 in 775e4ae
Also, recently another user mentioned trying to implement some sort of address-recycling logic on Discord @
#bdk-users
.What to do
Not sure, let's discuss.
The text was updated successfully, but these errors were encountered: