-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chain] Make LocalChain::apply_changeset
infallible
#1576
Comments
Perhaps more importantly, this function actually allows you to change the genesis block if the changeset happens to include it (although why would it?) which seems incongruent with most other methods |
Is this something you think should be done for the 1.0.0-beta milestone? would it help make any wallet user facing functions infallible ? |
I don't think it's terribly urgent and seems like it mostly affects developers who are working with |
What I mean by inherent or an invariant of |
It seems like the only way this can fail is if we don't find a base AND
extension
doesn't include block 0, but I think one of these will have to be true, i.e.extension
must have a genesis block or else we have a base.bdk/crates/chain/src/local_chain.rs
Lines 23 to 30 in 775e4ae
bdk/crates/chain/src/local_chain.rs
Lines 43 to 48 in 775e4ae
The text was updated successfully, but these errors were encountered: