You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the merged PRs section, the indicated number of comments only seems to count independent comments, not line comments on the diff. Feedback: There's still uncertainty of whether a batch review should count as one comment total or one comment per line, or whether replies to line comments should count as comments, but I'd lean towards giving everything 1 point---the goal for me today was to see whether the person was making impactful changes (typically indicated by high participation from others) versus typo-fix-level contributions.
The text was updated successfully, but these errors were encountered:
I investigated this issue and we switched the way we are getting the comment count from the comments array which accounted for independent comments to totalCommentsCount which accounts for all comments related to the pr.
Can you test to see if this issue still persists ?
In the merged PRs section, the indicated number of comments only seems to count independent comments, not line comments on the diff.
Feedback: There's still uncertainty of whether a batch review should count as one comment total or one comment per line, or whether replies to line comments should count as comments, but I'd lean towards giving everything 1 point---the goal for me today was to see whether the person was making impactful changes (typically indicated by high participation from others) versus typo-fix-level contributions.
The text was updated successfully, but these errors were encountered: