Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merged pr's number of comments only seems to count independent comments #14

Open
Extheoisah opened this issue Oct 10, 2023 · 1 comment
Labels
enhancement New feature or request user-feedback

Comments

@Extheoisah
Copy link
Contributor

In the merged PRs section, the indicated number of comments only seems to count independent comments, not line comments on the diff.
Feedback: There's still uncertainty of whether a batch review should count as one comment total or one comment per line, or whether replies to line comments should count as comments, but I'd lean towards giving everything 1 point---the goal for me today was to see whether the person was making impactful changes (typically indicated by high participation from others) versus typo-fix-level contributions.

@IgboPharaoh
Copy link
Collaborator

I investigated this issue and we switched the way we are getting the comment count from the comments array which accounted for independent comments to totalCommentsCount which accounts for all comments related to the pr.

Can you test to see if this issue still persists ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user-feedback
Projects
Development

No branches or pull requests

2 participants