Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a custom keybinding system #420

Open
brunnerh opened this issue Mar 10, 2023 · 4 comments · May be fixed by #1830
Open

Implement a custom keybinding system #420

brunnerh opened this issue Mar 10, 2023 · 4 comments · May be fixed by #1830
Labels
enhancement New feature or request

Comments

@brunnerh
Copy link

E.g. the documentation states that Alt + t switches to the terminal, however if I press that, I end up on the factions page because on my keyboard layout (Colemak) T is where F would be on Querty.

I think it would make more sense to use the keyboard event's key to make sure the shortcuts match what is documented/expected.

@Snarling
Copy link
Collaborator

Related issue #86 , will likely close one of them to keep the keycode related stuff in one issue.

We were using or tried to use key at one point as well and that caused some sort of issue for another subset of users.

@d0sboots do you happen to remember what the issue was? Without searching back I don't recall but IIRC you were heavily involved in that conversation

@d0sboots
Copy link
Collaborator

On my phone right now, the quick summary is that it used to use key instead of keycode, it was changed to keycode because of issues with macs but this breaks other keyboard layouts. The only real solution is to support keybinding.

When I'm at my computer I'll link all the relevant bugs and PRs, I still have them open in tabs.

@d0sboots
Copy link
Collaborator

danielyxie/bitburner#3592 - Original issue that prompted the switch to keycode
danielyxie/bitburner#3605 - PR attached to same
#224 - My PR that changed back to key
#242 - Revert of that PR
https://discord.com/channels/415207508303544321/459097632896188436/1048186524145045574 - Beginning of a long discussion between Zoë and me in #development about why my PR was no good, this contains all the specific details of what's going on with Macs and their keyboards

@Snarling Snarling changed the title Keyboard shortcuts use key code rather than key Implement a custom keybinding system Mar 14, 2023
@Snarling
Copy link
Collaborator

Since this issue has a bunch of relevant stuff linked, I closed out the other issue #86 . Since a custom keybinding system seems to be the best way to resolve this for everyone, I renamed the issue, but if there are any other ideas feel free to add them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants