Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for phpstan 1.12 #325

Closed
hostep opened this issue Aug 27, 2024 · 2 comments
Closed

Add support for phpstan 1.12 #325

hostep opened this issue Aug 27, 2024 · 2 comments
Milestone

Comments

@hostep
Copy link
Contributor

hostep commented Aug 27, 2024

Hiya!

Would be nice if the module can be released with support for phpstan 1.12, see:

It sounds like this is the last minor version release line before they'll release 2.0

Maybe we can consider switching again to ^1.11.1 constraint instead of ~1.11.1 for phpstan, as it's supposed to be backwards compatible?

Already tried with phpstan version 1.12.0 on 4 small modules and 1 semi larger project, no issues found.

@shochdoerfer
Copy link
Member

Thanks for testing :)

Will try to merge #326 soonish.

@shochdoerfer shochdoerfer added this to the 0.32.0 milestone Aug 31, 2024
@shochdoerfer
Copy link
Member

@hostep here you go https://github.com/bitExpert/phpstan-magento/releases/tag/v0.32.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants