Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency to phpstan/phpstan 1.11.x #319

Closed
dimitriBouteille opened this issue May 23, 2024 · 4 comments
Closed

Update dependency to phpstan/phpstan 1.11.x #319

dimitriBouteille opened this issue May 23, 2024 · 4 comments
Milestone

Comments

@dimitriBouteille
Copy link

dimitriBouteille commented May 23, 2024

Please support phpstan/phpstan 1.11.x

#318

@shochdoerfer
Copy link
Member

Thanks for opening your first issue in this repo. And thanks for caring about PHPStan 1.11 :)

I have it on my radar, but I need to find the time to test things in detail. This will take a few more weeks since I am currently quite busy with other stuff. If you are able to test it and report back, that would be super helpful.

@hostep
Copy link
Contributor

hostep commented Jun 5, 2024

Some quick feedback from me.

I've tested phpstan 1.11.3 in combination with this module (hacked it using "phpstan/phpstan": "1.11.3 as 1.10.67" in composer). Tried it on 4 different Magento modules and no issues found.

But I'm probably not using every single feature this module offers, so can't say for certain if it's fully compatible.

@shochdoerfer
Copy link
Member

Sounds good, thx Pieter! Will check my schedule to find a slot soonish to prepare the next release. I don't expect anything to break, but we have had issues in the past... :)

@shochdoerfer
Copy link
Member

Here we go https://github.com/bitExpert/phpstan-magento/releases/tag/v0.31.0

Sorry that it took way longer than expected, too much stuff going on currently. If anyone wants to step up and help as a co-maintainer, let me know. Happy to have more people to take care of this extension.

@shochdoerfer shochdoerfer added this to the 0.31.0 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants