Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and update tests with the BioLink v2.1 changes #72

Closed
newgene opened this issue Jul 30, 2021 · 3 comments
Closed

Fix and update tests with the BioLink v2.1 changes #72

newgene opened this issue Jul 30, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@newgene
Copy link
Member

newgene commented Jul 30, 2021

As part of this parent issue: biothings/biothings_explorer#207, we should fix and update the tests corresponding with the updates to BioLink v2.1.

@newgene newgene added the enhancement New feature or request label Jul 30, 2021
@newgene
Copy link
Member Author

newgene commented Jul 30, 2021

main branch - all tests pass
biolinkv2.1.0-updates-only - currently 4 failed tests:

Test Suites: 2 failed, 8 passed, 10 total
Tests:       4 failed, 2 skipped, 101 passed, 107 total

@colleenXu please help add expected BioLink v2.1 compatible (entity names) tests as well.

@colleenXu
Copy link
Contributor

@newgene please check the new branch biolink_v2.1 since that branch has been deleted.

@newgene
Copy link
Member Author

newgene commented Aug 2, 2021

I reran the tests using the latest biolink_v2.1 branch, all tests pass now:

npm run git checkout "biolink_v2.1"
npm run compile
npm run test --workspace=biomedical_id_resolver

Test Suites: 10 passed, 10 total
Tests:       107 passed, 107 total
Snapshots:   0 total
Time:        32.605 s

@tokebe tokebe closed this as completed Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants