-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record values of other observables #5
Comments
Assignment rules can now be tracked. See PySCeS/pysces#57 (comment). Fixed in latest PySCeS Release (1.0.2). |
This continues the discussion from here where certain model outputs are not recorded. The unrecorded variables are all assignment rules. In fact they are recorded by PySCeS, so it is a wrapper issue. Staying with Biomodels 297. I've had a brief look at the wrapper code. The wrapper records the simulation results here:
@luciansmith I have verified that this array contains all the simulation data including the assignment rules, in fact it is the same data as in the It therefore has to do with filtering of the model attributes which as far as I can see happens here: Biosimulators_PySCeS/biosimulators_pysces/core.py Lines 309 to 310 in 2d97929
The rules are not part The assignment and rate rules are in a dictionary
Hopefully this will give you sufficient info to track this down further. Unfortunately I don't have time in the coming weeks to work on this myself. |
Thanks for the analysis! Now that the pipeline works again, I can tackle this. |
And, this now works! And the PySCeS wrapper can now handle 711 of the biomodels, waaaay up from the previous 241. That section was indeed key! So thanks. |
I'm happy you were able to track this down 😃 |
The text was updated successfully, but these errors were encountered: