Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(noForEach): add validIdentifiers option #4498

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(noForEach): add validIdentifiers option #4498

wants to merge 1 commit into from

Conversation

lucasweng
Copy link
Contributor

Summary

Test Plan

Added tests for valid and invalid validIdentifiers configurations.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Nov 10, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 10, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4498 will not alter performance

Comparing lucasweng:noForEach-valid-identifiers (6e34ff7) with main (927b75b)

Summary

✅ 97 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💅 lint/complexity/noForEach should not throw on Effect.forEach (or be configurable)
1 participant
@lucasweng