Test and Score: Adapt test to change in sklearn #6914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6914 +/- ##
==========================================
+ Coverage 88.40% 88.41% +0.01%
==========================================
Files 326 326
Lines 71971 71971
==========================================
+ Hits 63624 63633 +9
+ Misses 8347 8338 -9 |
|
This should wait for scikit-learn/scikit-learn/pull/30103. |
|
scikit-learn/scikit-learn#30103 has been merged, and this PR has been changed accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #6913.
Sklearn did it again.
Description of changes
Expect different result from sklearn >= 1.6.
It seems that we do not have to change anything else but this test? Behaviour of the Test and score widget seems to be the same as before.
Includes