Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken test due to a change in scikit-learn's AUC #6913

Open
janezd opened this issue Oct 15, 2024 · 0 comments · May be fixed by #6914
Open

Broken test due to a change in scikit-learn's AUC #6913

janezd opened this issue Oct 15, 2024 · 0 comments · May be fixed by #6914

Comments

@janezd
Copy link
Contributor

janezd commented Oct 15, 2024

Hard-working maintainers of Python scientific stack decided to change the result of AUC when only one class is present in test data: scikit-learn/scikit-learn#27412, merged two days ago (here: https://github.com/scikit-learn/scikit-learn/pull/27412/files#diff-4eb3c023f8a3f088d62208f6adbd02b6df5196de2257ccd228dffc972c964634R383).

Yes, changing None to 0 indeed does not make a huge difference, does it? Well, except for breaking our tests and taking me half an hour to discover who's responsible (scikit? sklearn? pandas?) and what changed and why. Now I only need to make our tests version-dependent and we're fine again. Thank you, thank you, thank you.

I do not have a habit of swearing, but I might start if I keep trying to keep the pace with the ever-changing scipy, sklearn and pandas.

@janezd janezd added bug report Bug is reported by user, not yet confirmed by the core team and removed bug report Bug is reported by user, not yet confirmed by the core team labels Oct 15, 2024
@janezd janezd linked a pull request Oct 15, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant