PCA: distinguish between PCA and IncrementalPCA #6534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahnovsak
added
the
dask
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dask #6534 +/- ##
==========================================
- Coverage 87.70% 87.69% -0.01%
==========================================
Files 322 322
Lines 70045 70052 +7
==========================================
+ Hits 61432 61434 +2
- Misses 8613 8618 +5 |
markotoplak
added a commit
that referenced
this pull request
Aug 17, 2023
PCA: distinguish between PCA and IncrementalPCA
markotoplak
added a commit
that referenced
this pull request
Aug 21, 2023
PCA: distinguish between PCA and IncrementalPCA
markotoplak
added a commit
that referenced
this pull request
Sep 4, 2023
PCA: distinguish between PCA and IncrementalPCA
markotoplak
added a commit
that referenced
this pull request
Sep 14, 2023
PCA: distinguish between PCA and IncrementalPCA
markotoplak
added a commit
to markotoplak/orange3
that referenced
this pull request
Sep 14, 2023
PCA: distinguish between PCA and IncrementalPCA
markotoplak
added a commit
that referenced
this pull request
Sep 18, 2023
PCA: distinguish between PCA and IncrementalPCA
markotoplak
added a commit
that referenced
this pull request
Sep 26, 2023
PCA: distinguish between PCA and IncrementalPCA
markotoplak
added a commit
that referenced
this pull request
Oct 10, 2023
PCA: distinguish between PCA and IncrementalPCA
markotoplak
added a commit
that referenced
this pull request
Oct 13, 2023
PCA: distinguish between PCA and IncrementalPCA
markotoplak
added a commit
that referenced
this pull request
Oct 21, 2023
PCA: distinguish between PCA and IncrementalPCA
markotoplak
added a commit
that referenced
this pull request
Oct 29, 2023
PCA: distinguish between PCA and IncrementalPCA
markotoplak
added a commit
that referenced
this pull request
Nov 6, 2023
PCA: distinguish between PCA and IncrementalPCA
markotoplak
added a commit
that referenced
this pull request
Jan 23, 2024
PCA: distinguish between PCA and IncrementalPCA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the initial implementation of dask_ml into PCA I used IncrementalPCA instead due to memory concerns. This has now proven to be pointless, so it seems better to have each of the two projectors use the appropriate base class.
*IncrementalPCA is never actually used in Orange. If memory does end up being a concern though, I think the distinction between regular and incremental PCA should probably be made in the widget instead.