Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettify Workflow instead of Snap to Grid #4154

Closed
irgolic opened this issue Oct 31, 2019 · 7 comments
Closed

Prettify Workflow instead of Snap to Grid #4154

irgolic opened this issue Oct 31, 2019 · 7 comments
Labels

Comments

@irgolic
Copy link
Member

irgolic commented Oct 31, 2019

I feel like snap to grid isn't too useful, its role could be better fulfilled by a prettify workflow button.

Describe the solution you'd like
Upon a click of a button, the workflow is rearranged into an aesthetically pleasing configuration, as such:
Screenshot 2019-10-31 at 12 17 35

@irgolic irgolic added the wish label Oct 31, 2019
@janezd
Copy link
Contributor

janezd commented Nov 1, 2019

Actually, I don't like the prettify button. This should be like Illustrator's "Snap to object". When you drag a widget, it would snap to position in which the connection line is horizontal, or the widget is horizontally/vertically aligned with other widgets. The former has the priority.

We don't even need a checkbox for this functionality. It could be just enabled, always.

@ajdapretnar
Copy link
Contributor

It could be just enabled, always.

I think that would satisfy only us, super OCD people. I am not sure this is useful when building complex workflows where many connections overlap. I've seen such workflows and they would probably grow even bigger with this option.

@janezd
Copy link
Contributor

janezd commented Nov 4, 2019

I think that would satisfy only us, super OCD people.

Of course. It's far from a must-have.

@irgolic
Copy link
Member Author

irgolic commented Nov 5, 2019

I think it's nice to give the user agency over where nodes are placed. The prettify feature should serve the same purpose as a code reformat action in an IDE.

I imagine it'd also be useful for creating examples for screenshots.

@janezd
Copy link
Contributor

janezd commented Nov 8, 2019

This is a canvas issue. Continued in biolab/orange-canvas-core#53.

@janezd janezd closed this as completed Nov 8, 2019
@irgolic
Copy link
Member Author

irgolic commented Nov 8, 2019

A button for recomputation of all widget positions is what I meant.

I'd like to take this

Screenshot 2019-11-08 at 17 47 14

and with a click of a button, produce this

Screenshot 2019-11-08 at 17 48 37

Why do you believe such a solution to be infeasible?

@janezd
Copy link
Contributor

janezd commented Nov 10, 2019

I just wanted to say it's so difficult that it won't be implemented. Plus, I suspect that automated positioning won't always give the desired results. I think that snapping is easier and also more useful. But of course I wouldn't object to this solution, if you (or somebody else) implements it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants