GeoCoding: Don't override identifier type in set_data #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #179.
In
set_data
, we haveregion_attr_changed()
is the callback for combo with the attribute, and it includes a heuristic for setting the identifier type, thus overriding the value from the context.Besides, it calls
commit
, which is ugly -set_data
was not calling commit on it's own because it calledregion_attr_changed
, which does it. Forget about proper implementation of auto_commit...Description of changes
Reorganize the callbacks, and use heuristics for setting the type only if type is not recovered from the context (i.e., when no context matches).
Somebody should write tests for this. If nobody does it before the next release, we can still accept the PR as it is (if it's correct), because the widget is rather untested anyway.
Includes