-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if the settings in the workflow are from higher versions #67
Comments
We are, as developers, more often that not running a newest version of Orange, so we do not see those problems that often. But our users are not, so we could easily underestimate the importance of this issue. These warnings may be quite important. Not everyone likes to update so often. |
The check is trivial
The former is more appropirate, the latter is safer, because current migration methods on widget never call the base class method. In either case, the latter two methods must then remove the settings/context, as if I can do the above. But my knowledge of canvas is rather limited, and I don't know what would be a good way of communicating this to canvas, so it can show a dialog that some settings were removed. With this, I'm unassigning myself, hoping that @ales-erjavec or @irgolic will take over. |
This issue says we should check settings versions. On Slack we also discussed workflows. We could add checks for earlier and later versions and write something like:
In the latter case, the message appears only if there are no conflicting migrations discussed above. |
If we open some newer workflow on old Orange, the results are undefined. It could work, it might crash, or it could load but not work properly (forgets some settings).
On loading settings we should confirm that the setting version of the available widget is higher or equal to the saved setting version. If not, we should warn the user, and (if possible) show what to update (core orange or a specific add-on).
What to do after the warning? I do not know. I suggest we still try to use the settings as they are. If it crashes, well, fine, there was a warning.
The text was updated successfully, but these errors were encountered: