Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images in reports are too large #240

Open
janezd opened this issue Apr 3, 2023 · 1 comment · Fixed by #246
Open

Images in reports are too large #240

janezd opened this issue Apr 3, 2023 · 1 comment · Fixed by #246

Comments

@janezd
Copy link
Contributor

janezd commented Apr 3, 2023

After merging #208, images in reports are too large.

To reproduce, try reporting a box plot.

I assume that WebKit treats all images as 72dpi. Perhaps adding zoom: 0.5; to css would fix it. Edit: yes, but only if the image was taken on high-dpi screen.

@PrimozGodec
Copy link
Contributor

As agreed at the meeting, I merged #246. Anyway, as said, we will look at this one again, so I am reopening the issue.
As @markotoplak, I am also concerned that we skipped some possible cases.

I also see another problem (which was here already before) if I include a super big widget in the report image, the image sticks out of the report container when the report window is smaller. I think it could be fixed by updating the HTML so that the container div would not allow images to overflow (the image's max-width should not be wider than the container width). This solution can also solve problems with too-wide images on the retina without changing DPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants