Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add predict command #406

Merged
merged 81 commits into from
Sep 13, 2024
Merged

add predict command #406

merged 81 commits into from
Sep 13, 2024

Conversation

FynnBe
Copy link
Member

@FynnBe FynnBe commented Jul 23, 2024

This PR

  • updates the CLI (rewrite that now include a predict command)
  • includes some other changes to allow loading statistical measures from json with pydantic validation

@github-actions github-actions bot added the enhancement New feature or request label Jul 23, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 24, 2024
@FynnBe FynnBe marked this pull request as draft August 1, 2024 08:50
@thodkatz
Copy link

thodkatz commented Aug 5, 2024

This is very cool :) I have already tested with affable-shark and the test input data provided by the model.

I have one general question, maybe I am missing something. Since we can have multiple input tensors and output tensors, that means we can have multiple .npy files. Why we don't store the tensors in one .npy file as an object, or maybe use the .npz, so we can can make our lifes easier dealing with one input and one output file?

@FynnBe
Copy link
Member Author

FynnBe commented Aug 5, 2024

I used .npy as a file format default here, but in general we support many file formats. Users might want use .h5, .tif .png... which the imageio library takes care of for us.

As there is no .npz equivalent across file formats I would like to keep this simple approach.
We might want to use .h5 as a default and we should add .zarr and possibly make that the default instead.
Using numpy is the most hacker friendly, but not the most user friendly.

@FynnBe FynnBe mentioned this pull request Sep 13, 2024
@FynnBe FynnBe merged commit c59a1f8 into main Sep 13, 2024
13 checks passed
@FynnBe FynnBe deleted the predict_cmd branch September 13, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants