-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make coding style consistent with hgvs / enforce black and pylint #108
Comments
Also includes this as a check in CI.
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This issue was closed because it has been stalled for 7 days with no activity. |
I don't necessarily want to close this yet, but we're currently trying to be more purposeful about basing things like styling off of what's defined in the template first. That's entailed a slow (still ongoing) rollout of changes across biocommons - we've made some decisions about configs but are taking our time to populate them out to the repos because we don't want to impact ongoing PR discussions. This repo is pretty clean, though, so we could probably get them done soon. Broadly, unless there's a repo-specific configuration to implement, I think we generally want to form a consensus around linting/formatting/etc on the example repo first, and go from there. |
There is much more to coding style than indentation and static error analysis with lint. However, these can be enforced automatically.
Looking at the CI files for
hgvs
, the following appear to be useful:The text was updated successfully, but these errors were encountered: