Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail early when critical commands are missing #45

Closed
mgree opened this issue Jun 24, 2023 · 0 comments · Fixed by #67
Closed

Fail early when critical commands are missing #45

mgree opened this issue Jun 24, 2023 · 0 comments · Fixed by #67
Assignees
@ezrizhu
Labels
enhancement New feature or request

Comments

@mgree
Copy link
Contributor

mgree commented Jun 24, 2023

At the beginning of appropriate routines, (e.g., try()), we should ensure that any non-obvious binaries we need (e.g., findmnt) exist and fail early if they do not. Bonus points for appropriate depext suggestions.
@mgree mgree added the enhancement New feature or request label Jun 24, 2023
@ezrizhu ezrizhu self-assigned this Jun 25, 2023
@ezrizhu ezrizhu mentioned this issue Jun 25, 2023
Closed
@ezrizhu ezrizhu linked a pull request Jun 27, 2023 that will close this issue
Nested mount support #67
Merged
8 tasks
@mgree mgree mentioned this issue Jun 29, 2023
Closed
9 tasks
ezrizhu added a commit that referenced this issue Jun 29, 2023
@ezrizhu @gliargovas
@angelhof @mgree
Nested mount support (#67)
abe88f3 
* Allow for nested mount by using mergerfs

* Remove debug bash and echo

* mount /run with merger aswell

* refactor and use overlayfs via mergerfs if regular overlayfs fails

* Only mount /dev/{tty null zero full random urandom}

* improve docs, refactor from top_dir to mountpoint

* Fix mergerfs failing not showing mount log path

* Add support for unionfs, allow user to specify unionfs helper path

* Write mountpoint on unionhelper not found message

* exit if findmnt not installed

* nested mount docs

* add newlines to readme

* grammar fix

* Add -U option description to manpages

* Add shell completion for -U option

* Change -U flag autocompletion to only suggest executables

* Install mergerfs in ci

* Try reading from /run directory before testing

* Refactor and unmount devices for tests to pass

* Add a device test

* Some comments and redirect a test to /dev/null

Fixed #56 #45 #38 #20 #19 

---------

Co-authored-by: Eric Zhu <eric@debian-BULLSEYE-live-builder-AMD64>
Co-authored-by: gliargovas <[email protected]>
Co-authored-by: Konstantinos Kallas <[email protected]>
Co-authored-by: Michael Greenberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ezrizhu ezrizhu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Nested mount support binpash/try
2 participants
@mgree @ezrizhu