New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

free disk space improvements #4

Open

xwang1498 wants to merge 3 commits into bingmann:master from xwang1498:free-disk-size-windows

xwang1498 commented Dec 21, 2023 •

edited

Loading

a few improvements to free disk space calculation:

On Windows, use GetDiskFreeSpaceEx.
Use f_frsize instead of f_bsize, to get the correct block size on macOS (doesn't affect Windows or Linux).
Use f_bfree & f_bavail to compute free blocks. Previous f_blocks was computing total blocks, rather than free blocks. Choose bfree or bavail based on whether we're privileged or not. This matters on Linux, where part of the filesystem is often reserved for root.

Tested on Windows (x86_64-w64-mingw32-gcc), Cygwin (uses statvfs api), macOS, Linux, but not on MSVC.

xwang1498 added 3 commits

December 20, 2023 11:11


          support free disk size on Windows

e626528


          use f_frsize instead of f_bsize for correct free space on macOS

32abff0


          use f_bfree & f_bavail for correct number of free blocks on linux

f2d3783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet