Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect "in process" collisions comment #9

Open
aviranco opened this issue Jul 16, 2019 · 1 comment
Open

Detect "in process" collisions comment #9

aviranco opened this issue Jul 16, 2019 · 1 comment

Comments

@aviranco
Copy link

Hi,

I've read the code and noticed the following comment:
// TODO: detect "in process" collisions?

Can you explain if its relevant so I can create PR to fix it? what are these in-process collisions that can occur?

As far as I understand, when creating a hash there is "near-unique" number. If creating lock for the same string multiple times, multiple lock objects will be created, but they all going to function appropriately with their database interactions.

@olalonde
Copy link
Contributor

Hi, just letting you know I moved the repo to https://github.com/binded/advisory-lock and fixing bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants