Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebug 2.0 stopped showing internal data for all jQuery versions #39

Closed
pocesar opened this issue Jun 11, 2014 · 23 comments
Closed

Firebug 2.0 stopped showing internal data for all jQuery versions #39

pocesar opened this issue Jun 11, 2014 · 23 comments

Comments

@pocesar
Copy link

pocesar commented Jun 11, 2014

Firebug 2.0 stopped showing internal data for all jQuery versions, tested with 1.11 and 2.1.1, in the HTML tab.

@tobigit
Copy link

tobigit commented Jun 23, 2014

FireQuery stopped working also in my browser. No DOM-Bindings are shown anymore.

Firefox: 30.0
Firebug: 2.0.1
FireQuery: 1.4.1

@atwright147
Copy link

I believe this is a duplicate of issue #34

@tobigit
Copy link

tobigit commented Jun 25, 2014

No, the jQuery version is not the problem. We are using jQuery 1.10.2 which works fine with Firequery 1.41. a long time.

I did a downgrade of Firebug to 1.12.8 yesterday and now FireQuery works fine again. DOM-bindings are shown correctly!

FireQuery stopps working with Firebug 2.x

@darwin
Copy link
Member

darwin commented Jun 25, 2014

I assume format of tree-view in Firebug changed. I didn't have time to really install Firebug 2.0 and test my extensions there.

I'm still planning on doing that, but it does not have that big priority for me. Haven't been doing any serious webdev for a while.

@KODerFunk
Copy link

Fix it please.

@5im-0n
Copy link

5im-0n commented Aug 1, 2014

👍

@pocesar
Copy link
Author

pocesar commented Aug 15, 2014

it broke angular + ui-router + jquery 2.1.1 on page, this lack of support is dangerous.
angular-ui/ui-router#1104

@mhulse
Copy link

mhulse commented Aug 16, 2014

I'm still planning on doing that, but it does not have that big priority for me. Haven't been doing any serious webdev for a while.

This was a really useful plugin for jquery dev. Anyone out there able to help @darwin with a PR on this issue?

@darwin
Copy link
Member

darwin commented Aug 17, 2014

Hi again,

I think it is the time to face sad truth and call FireQuery unsupported software from my side.

The problem is that I don't have motivation to spend time on maintaining it. I hate broken software, but I have other projects which pay my bills and require constant maintenance (TotalFinder, TotalTerminal, etc.). I don't do heavy jQuery development anymore. And for my current web development tasks I switched completely to Chrome+Web Inspector.

Anyone want to step up and take this project?

@mhulse
Copy link

mhulse commented Aug 17, 2014

@darwin Totally understandable. I completely sympathize. I wish I knew enough to take this over, or, at least help maintain.

Dumb question: What's the main programming language used to create the FireQuery plugin?

Speaking of Chrome, are there tools, in that browser, that do the same job as FireQuery?

@darwin
Copy link
Member

darwin commented Aug 17, 2014

Firefox addons are written in javascript. FireQuery is quite ugly and convoluted piece of code:
https://github.com/binaryage/firequery/blob/master/firefox/chrome/content/firequery.js

I don't know about anything similar for Chrome.

@mhulse
Copy link

mhulse commented Aug 17, 2014

Firefox addons are written in javascript. FireQuery is quite ugly and convoluted piece of code:
https://github.com/binaryage/firequery/blob/master/firefox/chrome/content/firequery.js

Interesting! I'll take a closer look. 👍

I wonder what changed in Firebug that broke FireQuery? Part of me wonders if there's a simple fix.

What do you use to debug when developing a plugin? Might be interesting to turn on debug to see where/why Firequery isn't working. There's got to be some sort of API change that may (or may not be) easy to fix?

Anyway, thanks for the replies @darwin, much appreciated.

@darwin
Copy link
Member

darwin commented Aug 17, 2014

I don't know what broke it. FireQuery has to adapt three moving parts: jQuery internals, Firefox addons system and Firebug code. All three interfaces have been evolving over last 5 years. My bet is that this time something broke because of jQuery re-implementation of some internal $.data related code or Firebug changed the way how to render HTML panel.

For debugging I used debug prints, because good debuggers were not available for Mozilla platform at the time. Even setting up an add-ons development environment is quite challenging. Maybe things improved from last year - I saw quite active development of Firefox itself. You should find relevant docs here:
https://developer.mozilla.org/en-US/Add-ons

my $.02

@mhulse
Copy link

mhulse commented Aug 17, 2014

Interesting! Thanks for the feedback/link @darwin. If I find the free time I may look into this (though, I can totally relate to your time/money/pay the bills statement/sentiment).

@beam2web
Copy link

With attr() it seems to work partially, but for objects I'm not sure if that was possible in the past

var $input = $('#input'); // original <input id="input" type="text" />

$input
    .data('first', 'true')
    .data('second', {foo: 16, bar: "something"})
    .attr('data-third', 'true')
    .attr('data-fourth', {first: 16, last: "this is the last"});

// output <input id="input" type="text" data-third="true" data-fourth="[object Object]">

tested with: Firefox 32.0.2, Firebug 2.0.4, FireQuery 1.4.1, jQuery 1.10.2

@tobigit
Copy link

tobigit commented Oct 16, 2014

Has anybody a solution meanwhile? This plugin is very important for me.
Or has anybody a hint for me how i can debug this extension?

@tobigit
Copy link

tobigit commented Nov 10, 2014

Hi kbaniszack!
With your solution the DOM-bindings are shown only on the DOM-Element "html" under firebug 2.0.6. This is a good news so far. The Plugin works under firebug 2.x
Maybe it is only a trifle to get the rest working?! ;-)

@ms-berry
Copy link

ms-berry commented Jan 6, 2015

it seems to be problem with apply() function in jQuery.__FireQueryShared.removeData_originalReplacedByFireQuery
jQuery.__FireQueryShared.data_originalReplacedByFireQuery
i quickfix this and seems to work now, dont have time for more investigation at the moment:)
full /chorome/content/firequery.js here:
http://pastebin.com/N6gArmyP

@FlashJunior
Copy link

Any update?

@FlashJunior
Copy link

Any plans to fix this?

@darwin
Copy link
Member

darwin commented Feb 27, 2015

No immediate plans for update. I don't use Firefox&Firebug for my web development. Also I don't use jQuery anymore.

Sorry guys. You have to downgrade or fix it yourself.

@janodvarko
Copy link
Contributor

New version of FireQuery (beta 1) is available.

New FireQuery 2 is (re)built on top of native developer tools and is compatible with Firefox 36-39. FireQuery 2 doesn't require Firebug, but is nicely integrated with Firebug 3 (aka Firebug.next) that is also built on top of Firefox native developer tools.

FireQuery 2 new home page:
https://github.com/firebug/firequery/wiki

FireQuery 2 new issue list:
https://github.com/firebug/firequery/issues

FireQuery 2 is in beta phase now and we'd love to hear some feedback from you before we do the final release, thanks!

Honza

@FlashJunior
Copy link

@janodvarko great news! thx a lot!

@pocesar pocesar closed this as completed Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests