Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firequery spams warnings in console #11

Open
rvock opened this issue Apr 12, 2010 · 1 comment
Open

Firequery spams warnings in console #11

rvock opened this issue Apr 12, 2010 · 1 comment

Comments

@rvock
Copy link

rvock commented Apr 12, 2010

Firequery spams messages to the console of the webdeveloper plugin, when a page doesn't use jQuery (Click on right icon in the WebDeveloper Toolbar).

It's the check in Line 136:
if (window.jQuery) {

That results in many "Warning: window.jQuery is undefined" messages...
Better use a typeof check :)

@darwin
Copy link
Member

darwin commented Apr 13, 2010

Hm, that's interesting. IMHO that code should not cause any warnings if window object exists. window.jQuery should simply silently eval to undefined. Am I missing something? Why is webdeveloper plugin reporting it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants