Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize code and documentation to include Firefox #71

Open
SebastianZ opened this issue Nov 1, 2022 · 1 comment
Open

Generalize code and documentation to include Firefox #71

SebastianZ opened this issue Nov 1, 2022 · 1 comment

Comments

@SebastianZ
Copy link
Collaborator

An implementation for custom formatters in Firefox is on its way. So the code and documentaton of the CLJS DevTools should account for that.

Currently, there's an explicit check for Chrome 47 in the formatters code.

One possibility would be to simply remove the check and the logic around it as browsers not supporting custom formatters simply display the logged objects with their normal rendering.
The downside of that approach is, of course, that there won't be a hint anymore when the custom formatters couldn't be applied.

And the documentation is also still very much focused on Chrome as browser. Once the implementation in Firefox stands, all mentions in the documentation should reflect that. This means, adding Firefox where necessary or removing the wording related to Chrome where possible.

Sebastian

@elken
Copy link

elken commented Aug 11, 2023

https://firefox-source-docs.mozilla.org/devtools-user/custom_formatters/index.html it's actually out now :)
image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants