Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent RPi OS version aren't correctly detected #151

Open
martignoni opened this issue Jan 15, 2023 · 5 comments · May be fixed by #152
Open

Recent RPi OS version aren't correctly detected #151

martignoni opened this issue Jan 15, 2023 · 5 comments · May be fixed by #152

Comments

@martignoni
Copy link

martignoni commented Jan 15, 2023

Logic to detect RPi OS version has changed and should be taken in account. Notably

cat /etc/os-release | grep PRETTY

doesn't return "Raspbian" string any more.

@framps
Copy link

framps commented Jan 15, 2023

Added a fix on my branch

@martignoni martignoni linked a pull request Jan 15, 2023 that will close this issue
@martignoni
Copy link
Author

See #152 (more generic fix IMHO).

@J-Luc16
Copy link

J-Luc16 commented Feb 13, 2023

I am surprised, this is what is returned by a raspbian Bullseye :

cat /etc/os-release

PRETTY_NAME="Raspbian GNU/Linux 11 (bullseye)"
NAME="Raspbian GNU/Linux"
VERSION_ID="11"
VERSION="11 (bullseye)"
VERSION_CODENAME=bullseye

RPI_CLONE never stopped working for me, also with the bullseye.

@martignoni
Copy link
Author

This seems to be a 32bit version (what date?)

We have to take in account 64bit of RPiOS version too. The detection logic should work for both 32bit and 64bit version.

@J-Luc16
Copy link

J-Luc16 commented Feb 13, 2023

Built very recently (january). I understand your concern about the 32/64 bits, I am not skilled enough to give my advice.
FYI it's the latest kernel (6.1), I don't know if it matters in the answer to os-release.
Thanks for all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants