Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior in cases the template is not applicable #749

Open
kasnerz opened this issue Apr 27, 2022 · 1 comment
Open

Behavior in cases the template is not applicable #749

kasnerz opened this issue Apr 27, 2022 · 1 comment

Comments

@kasnerz
Copy link

kasnerz commented Apr 27, 2022

If the template is not applicable for a particular example, the prompt.apply() method returns only a single-element list with an empty string instead of a two-element list with the prompted input and the reference answer. This contradicts the docstring which says that two elements are returned.

Should we just update the docstring, or handle this case with more care?

Example: the e2e_nlg_cleaned dataset with QA-style templates such as food_qa (1acabbc3-c9b9-4624-a684-29faeccff46f). This manifests in the web interface by displaying "∅∅∅ Blank result" instead of an input-target pair.

screen-2022-04-27-11-30-16

@VictorSanh
Copy link
Member

hey @kasnerz !
yes that sounds about right. we should modify the docstring. Would you like to open a pr for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants