From 5e2000d252e55a570da2d356ee9b0c4309cef8ec Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Thu, 24 Mar 2022 11:50:06 +0200
Subject: [PATCH 01/28] feat: add invalidate item warehouses.

---
 src/hooks/query/bills.js      | 3 +++
 src/hooks/query/invoices.js   | 3 +++
 src/hooks/query/receipts.js   | 3 +++
 src/hooks/query/warehouses.js | 1 -
 4 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/hooks/query/bills.js b/src/hooks/query/bills.js
index 24806a3b6..e4421761d 100644
--- a/src/hooks/query/bills.js
+++ b/src/hooks/query/bills.js
@@ -33,6 +33,9 @@ const commonInvalidateQueries = (queryClient) => {
 
   // Invalidate items associated bills transactions.
   queryClient.invalidateQueries(t.ITEMS_ASSOCIATED_WITH_BILLS);
+
+  // Invalidate item warehouses.
+  queryClient.invalidateQueries(t.ITEM_WAREHOUSES_LOCATION);
 };
 
 /**
diff --git a/src/hooks/query/invoices.js b/src/hooks/query/invoices.js
index 39513148b..ef6679313 100644
--- a/src/hooks/query/invoices.js
+++ b/src/hooks/query/invoices.js
@@ -34,6 +34,9 @@ const commonInvalidateQueries = (queryClient) => {
 
   // Invalidate
   queryClient.invalidateQueries(t.ITEM_ASSOCIATED_WITH_INVOICES);
+
+  // Invalidate item warehouses.
+  queryClient.invalidateQueries(t.ITEM_WAREHOUSES_LOCATION);
 };
 
 /**
diff --git a/src/hooks/query/receipts.js b/src/hooks/query/receipts.js
index c2cbeaa22..725e9fecb 100644
--- a/src/hooks/query/receipts.js
+++ b/src/hooks/query/receipts.js
@@ -27,6 +27,9 @@ const commonInvalidateQueries = (queryClient) => {
   // Invalidate
   queryClient.invalidateQueries(t.ITEM_ASSOCIATED_WITH_RECEIPTS);
 
+  // Invalidate item warehouses.
+  queryClient.invalidateQueries(t.ITEM_WAREHOUSES_LOCATION);
+
   // Invalidate the settings.
   queryClient.invalidateQueries([t.SETTING, t.SETTING_RECEIPTS]);
 };
diff --git a/src/hooks/query/warehouses.js b/src/hooks/query/warehouses.js
index acea73d4a..703a66687 100644
--- a/src/hooks/query/warehouses.js
+++ b/src/hooks/query/warehouses.js
@@ -12,7 +12,6 @@ const commonInvalidateQueries = (queryClient) => {
 
   // Invalidate warehouses transfers.
   queryClient.invalidateQueries(t.WAREHOUSE_TRANSFERS);
-  // queryClient.invalidateQueries(t.WAREHOUSE_TRANSFER);
 
   queryClient.invalidateQueries(t.DASHBOARD_META);
 };

From 99a23889bcf30e52af9a43631d32166cd0062584 Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Thu, 24 Mar 2022 12:19:46 +0200
Subject: [PATCH 02/28] feat: add warehouses transfers query.

---
 src/hooks/query/warehouses.js          | 158 -----------------------
 src/hooks/query/warehousesTransfers.js | 172 +++++++++++++++++++++++++
 2 files changed, 172 insertions(+), 158 deletions(-)
 create mode 100644 src/hooks/query/warehousesTransfers.js

diff --git a/src/hooks/query/warehouses.js b/src/hooks/query/warehouses.js
index 703a66687..b2cd0eaea 100644
--- a/src/hooks/query/warehouses.js
+++ b/src/hooks/query/warehouses.js
@@ -104,164 +104,6 @@ export function useWarehouse(id, props, requestProps) {
   );
 }
 
-/**
- * Create a new warehouse transfer.
- */
-export function useCreateWarehouseTransfer(props) {
-  const queryClient = useQueryClient();
-  const apiRequest = useApiRequest();
-
-  return useMutation(
-    (values) => apiRequest.post('warehouses/transfers', values),
-    {
-      onSuccess: (res, values) => {
-        // Common invalidate queries.
-        commonInvalidateQueries(queryClient);
-      },
-      ...props,
-    },
-  );
-}
-
-/**
- * Edits the given warehouse transfer.
- */
-export function useEditWarehouseTransfer(props) {
-  const queryClient = useQueryClient();
-  const apiRequest = useApiRequest();
-
-  return useMutation(
-    ([id, values]) => apiRequest.post(`warehouses/transfers/${id}`, values),
-    {
-      onSuccess: (res, [id, values]) => {
-        // Invalidate specific sale invoice.
-        queryClient.invalidateQueries([t.WAREHOUSE_TRANSFER, id]);
-
-        // Common invalidate queries.
-        commonInvalidateQueries(queryClient);
-      },
-      ...props,
-    },
-  );
-}
-
-/**
- * Deletes the given warehouse Transfer.
- */
-export function useDeleteWarehouseTransfer(props) {
-  const queryClient = useQueryClient();
-  const apiRequest = useApiRequest();
-
-  return useMutation((id) => apiRequest.delete(`warehouses/transfers/${id}`), {
-    onSuccess: (res, id) => {
-      // Common invalidate queries.
-      commonInvalidateQueries(queryClient);
-    },
-    ...props,
-  });
-}
-
-const transformWarehousesTransfer = (res) => ({
-  warehousesTransfers: res.data.data,
-  pagination: transformPagination(res.data.pagination),
-  filterMeta: res.data.filter,
-});
-
-/**
- * Retrieve Warehoues list.
- */
-export function useWarehousesTransfers(query, props) {
-  return useRequestQuery(
-    [t.WAREHOUSE_TRANSFERS, query],
-    { method: 'get', url: 'warehouses/transfers', params: query },
-    {
-      select: transformWarehousesTransfer,
-      defaultData: {
-        warehousesTransfers: [],
-        pagination: {
-          page: 1,
-          pageSize: 20,
-          total: 0,
-        },
-        filterMeta: {},
-      },
-      ...props,
-    },
-  );
-}
-
-/**
- * Retrieve the warehouse transfer details.
- * @param {number}
- */
-export function useWarehouseTransfer(id, props, requestProps) {
-  return useRequestQuery(
-    [t.WAREHOUSE_TRANSFER, id],
-    { method: 'get', url: `warehouses/transfers/${id}`, ...requestProps },
-    {
-      select: (res) => res.data.data,
-      defaultData: {},
-      ...props,
-    },
-  );
-}
-
-/**
- *
- * @param {*} props
- * @returns
- */
-export function useInitiateWarehouseTransfer(props) {
-  const queryClient = useQueryClient();
-  const apiRequest = useApiRequest();
-
-  return useMutation(
-    (id) => apiRequest.put(`warehouses/transfers/${id}/initiate`),
-    {
-      onSuccess: (res, id) => {
-        queryClient.invalidateQueries([t.WAREHOUSE_TRANSFER, id]);
-
-        // Common invalidate queries.
-        commonInvalidateQueries(queryClient);
-      },
-      ...props,
-    },
-  );
-}
-
-/**
- *
- * @param {*} props
- * @returns
- */
-export function useTransferredWarehouseTransfer(props) {
-  const queryClient = useQueryClient();
-  const apiRequest = useApiRequest();
-
-  return useMutation(
-    (id) => apiRequest.put(`warehouses/transfers/${id}/transferred`),
-    {
-      onSuccess: (res, id) => {
-        queryClient.invalidateQueries([t.WAREHOUSE_TRANSFER, id]);
-
-        // Common invalidate queries.
-        commonInvalidateQueries(queryClient);
-      },
-      ...props,
-    },
-  );
-}
-
-export function useRefreshWarehouseTransfers() {
-  const queryClient = useQueryClient();
-
-  return {
-    refresh: () => {
-      queryClient.invalidateQueries(t.WAREHOUSE_TRANSFERS);
-    },
-  };
-}
-
 /**
  * Activate the given warehouse.
  */
diff --git a/src/hooks/query/warehousesTransfers.js b/src/hooks/query/warehousesTransfers.js
new file mode 100644
index 000000000..414201183
--- /dev/null
+++ b/src/hooks/query/warehousesTransfers.js
@@ -0,0 +1,172 @@
+import { useQueryClient, useMutation } from 'react-query';
+import { transformPagination } from 'utils';
+import { useRequestQuery } from '../useQueryRequest';
+import useApiRequest from '../useRequest';
+import t from './types';
+
+// Common invalidate queries.
+const commonInvalidateQueries = (queryClient) => {
+  // Invalidate warehouses transfers.
+  queryClient.invalidateQueries(t.WAREHOUSE_TRANSFERS);
+
+  // Invalidate item warehouses.
+  queryClient.invalidateQueries(t.ITEM_WAREHOUSES_LOCATION);
+};
+
+/**
+ * Create a new warehouse transfer.
+ */
+export function useCreateWarehouseTransfer(props) {
+  const queryClient = useQueryClient();
+  const apiRequest = useApiRequest();
+
+  return useMutation(
+    (values) => apiRequest.post('warehouses/transfers', values),
+    {
+      onSuccess: (res, values) => {
+        // Common invalidate queries.
+        commonInvalidateQueries(queryClient);
+      },
+      ...props,
+    },
+  );
+}
+
+/**
+ * Edits the given warehouse transfer.
+ */
+export function useEditWarehouseTransfer(props) {
+  const queryClient = useQueryClient();
+  const apiRequest = useApiRequest();
+
+  return useMutation(
+    ([id, values]) => apiRequest.post(`warehouses/transfers/${id}`, values),
+    {
+      onSuccess: (res, [id, values]) => {
+        // Invalidate specific sale invoice.
+        queryClient.invalidateQueries([t.WAREHOUSE_TRANSFER, id]);
+
+        // Common invalidate queries.
+        commonInvalidateQueries(queryClient);
+      },
+      ...props,
+    },
+  );
+}
+
+/**
+ * Deletes the given warehouse Transfer.
+ */
+export function useDeleteWarehouseTransfer(props) {
+  const queryClient = useQueryClient();
+  const apiRequest = useApiRequest();
+
+  return useMutation((id) => apiRequest.delete(`warehouses/transfers/${id}`), {
+    onSuccess: (res, id) => {
+      // Common invalidate queries.
+      commonInvalidateQueries(queryClient);
+    },
+    ...props,
+  });
+}
+
+const transformWarehousesTransfer = (res) => ({
+  warehousesTransfers: res.data.data,
+  pagination: transformPagination(res.data.pagination),
+  filterMeta: res.data.filter,
+});
+
+/**
+ * Retrieve Warehoues list.
+ */
+export function useWarehousesTransfers(query, props) {
+  return useRequestQuery(
+    [t.WAREHOUSE_TRANSFERS, query],
+    { method: 'get', url: 'warehouses/transfers', params: query },
+    {
+      select: transformWarehousesTransfer,
+      defaultData: {
+        warehousesTransfers: [],
+        pagination: {
+          page: 1,
+          pageSize: 20,
+          total: 0,
+        },
+        filterMeta: {},
+      },
+      ...props,
+    },
+  );
+}
+
+/**
+ * Retrieve the warehouse transfer details.
+ * @param {number}
+ */
+export function useWarehouseTransfer(id, props, requestProps) {
+  return useRequestQuery(
+    [t.WAREHOUSE_TRANSFER, id],
+    { method: 'get', url: `warehouses/transfers/${id}`, ...requestProps },
+    {
+      select: (res) => res.data.data,
+      defaultData: {},
+      ...props,
+    },
+  );
+}
+
+/**
+ *
+ * @param {*} props
+ * @returns
+ */
+export function useInitiateWarehouseTransfer(props) {
+  const queryClient = useQueryClient();
+  const apiRequest = useApiRequest();
+
+  return useMutation(
+    (id) => apiRequest.put(`warehouses/transfers/${id}/initiate`),
+    {
+      onSuccess: (res, id) => {
+        queryClient.invalidateQueries([t.WAREHOUSE_TRANSFER, id]);
+
+        // Common invalidate queries.
+        commonInvalidateQueries(queryClient);
+      },
+      ...props,
+    },
+  );
+}
+
+/**
+ *
+ * @param {*} props
+ * @returns
+ */
+export function useTransferredWarehouseTransfer(props) {
+  const queryClient = useQueryClient();
+  const apiRequest = useApiRequest();
+
+  return useMutation(
+    (id) => apiRequest.put(`warehouses/transfers/${id}/transferred`),
+    {
+      onSuccess: (res, id) => {
+        queryClient.invalidateQueries([t.WAREHOUSE_TRANSFER, id]);
+
+        // Common invalidate queries.
+        commonInvalidateQueries(queryClient);
+      },
+      ...props,
+    },
+  );
+}
+
+export function useRefreshWarehouseTransfers() {
+  const queryClient = useQueryClient();
+
+  return {
+    refresh: () => {
+      queryClient.invalidateQueries(t.WAREHOUSE_TRANSFERS);
+    },
+  };
+}

From 8404fee10a7bc8a701bd407e5567e7dfa58da78c Mon Sep 17 00:00:00 2001
From: Ahmed Bouhuolia <a.bouhuolia@live.com>
Date: Thu, 24 Mar 2022 13:12:14 +0200
Subject: [PATCH 03/28] dump v1.7.0-rc.1

---
 CHANGELOG.md | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 03f5da752..ab70adcb0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,26 @@
 
 All notable changes to Bigcapital server-side will be in this file.
 
+## [1.7.0-rc.1] - 24-03-2022
+
+## Added 
+ - Multiply currencies with foreign currencies.
+ - Multiply warehouses to track inventory items.
+ - Multiply branches to track organization transactions.
+ - Transfer orders between warehouses.
+ - Integrate financial reports with multiply branches.
+ - Integrate inventory reports with multiply warehouses.
+
+## Changes
+ - Optimize style of sale invoice form.
+ - Optimize style of sale receipt form.
+ - Optimize style of credit note form.
+ - Optimize style of payment receive form.
+ - Optimize style of bill form.
+ - Optimize style of payment made form.
+ - Optimize style of manual journal form.
+ - Optimize style of expense form.
+
 ## [1.6.3] - 21-02-2022
 
 ### Fixed

From 86cab7988c6cfba4586d80f55ef036edb1f69db2 Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Thu, 24 Mar 2022 15:03:25 +0200
Subject: [PATCH 04/28] feat: handle item error.

---
 src/containers/Items/utils.js | 8 ++++++++
 src/lang/ar/index.json        | 6 ++----
 src/lang/en/index.json        | 1 +
 3 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/src/containers/Items/utils.js b/src/containers/Items/utils.js
index 406746786..8031e56ea 100644
--- a/src/containers/Items/utils.js
+++ b/src/containers/Items/utils.js
@@ -104,6 +104,14 @@ export const handleDeleteErrors = (errors) => {
       intent: Intent.DANGER,
     });
   }
+  if (
+    errors.find((error) => error.type === 'ITEM_HAS_ASSOCIATED_TRANSACTIONS')
+  ) {
+    AppToaster.show({
+      message: intl.get('item.error.you_could_not_delete_item_has_associated'),
+      intent: Intent.DANGER,
+    });
+  }
 };
 
 /**
diff --git a/src/lang/ar/index.json b/src/lang/ar/index.json
index 3accd9b2f..880af1586 100644
--- a/src/lang/ar/index.json
+++ b/src/lang/ar/index.json
@@ -1795,13 +1795,10 @@
   "profit_loss_sheet.percentage_of_row": "% التغير الأفقي",
   "profit_loss_sheet.percentage_of_expense": "% التغير في المصاريف",
   "profit_loss_sheet.percentage_of_income": "% التغير الإيرادات",
-  
   "report.balance_sheet_comparison.title": "مقارنة الميزانية العمومية",
   "report.balance_sheet_comparison.desc": "يعرض أصول الشركة والتزاماتها وحقوق المساهمين في نقطة زمنية محددة مقارنة بالسنة الماضية.",
-
   "report.profit_loss_sheet_comparison.title": "مقارنة قائمة الدخل",
   "report.profit_loss_sheet_comparison.desc": "يعرض الإيرادات والتكاليف والمصاريف المتكبدة في نقطة محددة ومقارنة بالعام السابق.",
-
   "warehouse_locations.label": "المخازن",
   "warehouse_locations.column.warehouse_name": "اسم المخزن",
   "warehouse_locations.column.quantity": "الكمية",
@@ -2007,5 +2004,6 @@
   "receipt.branch_button.label": "الفرع: {label}",
   "receipt.warehouse_button.label": "المخزن: {label}",
   "warehouse_transfer.empty_status.title": "",
-  "warehouse_transfer.empty_status.description": ""
+  "warehouse_transfer.empty_status.description": "",
+  "item.error.you_could_not_delete_item_has_associated": "لا يمكنك حذف العنصر لديه معاملات مرتبطة به "
 }
\ No newline at end of file
diff --git a/src/lang/en/index.json b/src/lang/en/index.json
index 41d4ebc9e..fd2ad8d65 100644
--- a/src/lang/en/index.json
+++ b/src/lang/en/index.json
@@ -1440,6 +1440,7 @@
   "AP_aging_summary.filter_options.label": "Filter vendors",
   "item.error.type_cannot_change_with_item_has_transactions": "Cannot change item type to inventory with item has associated transactions.",
   "item.error.cannot_change_inventory_account": "Cannot change item inventory account while the item has transactions.",
+  "item.error.you_could_not_delete_item_has_associated":"You could not delete item that has associated transactions",
   "customer.link.customer_details": "Customer details ({amount})",
   "bad_debt.dialog.written_off_amount": "Written-off amount",
   "bad_debt.dialog.bad_debt": "Bad debt",

From 6a8137729ff7ef2fc53776a6ec9b160fef39a6fb Mon Sep 17 00:00:00 2001
From: "a.bouhuolia" <a.bouhuolia@live.com>
Date: Mon, 28 Mar 2022 12:01:29 +0200
Subject: [PATCH 05/28] fix(Account): `BIG-296` Issue when creating a new child
 account from chart of accounts list.

---
 src/common/index.js                           |  1 +
 src/containers/Accounts/AccountsDataTable.js  |  9 +++--
 .../CashFlowAccountsActionsBar.js             | 11 +++---
 .../AccountDialog/AccountDialogContent.js     | 16 ++-------
 .../AccountDialog/AccountDialogForm.js        | 13 ++-----
 .../AccountDialog/AccountDialogFormContent.js | 11 +++---
 .../AccountDialog/AccountDialogProvider.js    | 36 ++++++++++---------
 src/containers/Dialogs/AccountDialog/index.js | 20 ++++-------
 src/containers/Dialogs/AccountDialog/utils.js | 36 +++++++++++++++----
 .../AccountDrawer/AccountDrawerActionBar.js   | 17 ++++-----
 src/lang/ar/index.json                        |  4 +--
 11 files changed, 90 insertions(+), 84 deletions(-)

diff --git a/src/common/index.js b/src/common/index.js
index ffd40825e..c2922a515 100644
--- a/src/common/index.js
+++ b/src/common/index.js
@@ -1,3 +1,4 @@
+export * from './accountTypes';
 export * from './TableStyle';
 export * from './features';
 export * from './cellTypes';
diff --git a/src/containers/Accounts/AccountsDataTable.js b/src/containers/Accounts/AccountsDataTable.js
index 8d12404ee..ab45025eb 100644
--- a/src/containers/Accounts/AccountsDataTable.js
+++ b/src/containers/Accounts/AccountsDataTable.js
@@ -15,6 +15,8 @@ import withSettings from '../Settings/withSettings';
 import { useAccountsChartContext } from './AccountsChartProvider';
 import { useMemorizedColumnsWidths } from '../../hooks';
 
+import { AccountDialogAction } from '../Dialogs/AccountDialog/utils';
+
 import withAlertsActions from 'containers/Alert/withAlertActions';
 import withDialogActions from 'containers/Dialog/withDialogActions';
 import withDrawerActions from 'containers/Drawer/withDrawerActions';
@@ -58,7 +60,10 @@ function AccountsDataTable({
 
   // Handle edit account action.
   const handleEditAccount = (account) => {
-    openDialog('account-form', { action: 'edit', id: account.id });
+    openDialog('account-form', {
+      action: AccountDialogAction.Edit,
+      id: account.id,
+    });
   };
 
   // Handle view detail account.
@@ -69,7 +74,7 @@ function AccountsDataTable({
   // Handle new child button click.
   const handleNewChildAccount = (account) => {
     openDialog('account-form', {
-      action: 'new_child',
+      action: AccountDialogAction.NewChild,
       parentAccountId: account.id,
       accountType: account.account_type,
     });
diff --git a/src/containers/CashFlow/CashFlowAccounts/CashFlowAccountsActionsBar.js b/src/containers/CashFlow/CashFlowAccounts/CashFlowAccountsActionsBar.js
index f21b9f463..f4947ee68 100644
--- a/src/containers/CashFlow/CashFlowAccounts/CashFlowAccountsActionsBar.js
+++ b/src/containers/CashFlow/CashFlowAccounts/CashFlowAccountsActionsBar.js
@@ -16,6 +16,9 @@ import DashboardActionsBar from 'components/Dashboard/DashboardActionsBar';
 import withDialogActions from 'containers/Dialog/withDialogActions';
 import withCashflowAccountsTableActions from '../AccountTransactions/withCashflowAccountsTableActions';
 
+import { AccountDialogAction } from '../../Dialogs/AccountDialog/utils';
+import { ACCOUNT_TYPE } from '../../../common';
+
 import { compose } from 'utils';
 
 /**
@@ -37,15 +40,15 @@ function CashFlowAccountsActionsBar({
   // Handle add bank account.
   const handleAddBankAccount = () => {
     openDialog('account-form', {
-      action: 'NEW_ACCOUNT_DEFINED_TYPE',
-      accountType: 'cash',
+      action: AccountDialogAction.NewDefinedType,
+      accountType: ACCOUNT_TYPE.CASH,
     });
   };
   // Handle add cash account.
   const handleAddCashAccount = () => {
     openDialog('account-form', {
-      action: 'NEW_ACCOUNT_DEFINED_TYPE',
-      accountType: 'bank',
+      action: AccountDialogAction.NewDefinedType,
+      accountType: ACCOUNT_TYPE.BANK,
     });
   };
   // Handle inactive switch changing.
diff --git a/src/containers/Dialogs/AccountDialog/AccountDialogContent.js b/src/containers/Dialogs/AccountDialog/AccountDialogContent.js
index 2c9856cba..cf373474e 100644
--- a/src/containers/Dialogs/AccountDialog/AccountDialogContent.js
+++ b/src/containers/Dialogs/AccountDialog/AccountDialogContent.js
@@ -5,21 +5,9 @@ import AccountDialogForm from './AccountDialogForm';
 /**
  * Account dialog content.
  */
-export default function AccountDialogContent({
-  dialogName,
-  accountId,
-  action,
-  parentAccountId,
-  accountType,
-}) {
+export default function AccountDialogContent({ dialogName, payload }) {
   return (
-    <AccountDialogProvider
-      dialogName={dialogName}
-      accountId={accountId}
-      action={action}
-      parentAccountId={parentAccountId}
-      accountType={accountType}
-    >
+    <AccountDialogProvider dialogName={dialogName} payload={payload}>
       <AccountDialogForm />
     </AccountDialogProvider>
   );
diff --git a/src/containers/Dialogs/AccountDialog/AccountDialogForm.js b/src/containers/Dialogs/AccountDialog/AccountDialogForm.js
index 809ae6ea6..30c9e210f 100644
--- a/src/containers/Dialogs/AccountDialog/AccountDialogForm.js
+++ b/src/containers/Dialogs/AccountDialog/AccountDialogForm.js
@@ -43,9 +43,7 @@ function AccountFormDialogContent({
     account,
 
     accountId,
-    action,
-    parentAccountId,
-    accountType,
+    payload,
     isNewMode,
     dialogName,
   } = useAccountDialogContext();
@@ -101,7 +99,6 @@ function AccountFormDialogContent({
         .catch(handleError);
     }
   };
-
   // Form initial values in create and edit mode.
   const initialValues = {
     ...defaultInitialValues,
@@ -111,11 +108,7 @@ function AccountFormDialogContent({
      * as well.
      */
     ...transformToForm(
-      transformAccountToForm(account, {
-        action,
-        parentAccountId,
-        accountType,
-      }),
+      transformAccountToForm(account, payload),
       defaultInitialValues,
     ),
   };
@@ -133,7 +126,7 @@ function AccountFormDialogContent({
     >
       <AccountDialogFormContent
         dialogName={dialogName}
-        action={action}
+        action={payload?.action}
         onClose={handleClose}
       />
     </Formik>
diff --git a/src/containers/Dialogs/AccountDialog/AccountDialogFormContent.js b/src/containers/Dialogs/AccountDialog/AccountDialogFormContent.js
index 2350b0f4e..4de48166e 100644
--- a/src/containers/Dialogs/AccountDialog/AccountDialogFormContent.js
+++ b/src/containers/Dialogs/AccountDialog/AccountDialogFormContent.js
@@ -39,7 +39,8 @@ function AccountFormDialogFields({
   const accountNameFieldRef = useAutofocus();
 
   // Account form context.
-  const { accounts, accountsTypes, currencies } = useAccountDialogContext();
+  const { fieldsDisabled, accounts, accountsTypes, currencies } =
+    useAccountDialogContext();
 
   return (
     <Form>
@@ -62,11 +63,7 @@ function AccountFormDialogFields({
                   form.setFieldValue('account_type', accountType.key);
                   form.setFieldValue('currency_code', '');
                 }}
-                disabled={
-                  action === 'edit' ||
-                  action === 'new_child' ||
-                  action === 'NEW_ACCOUNT_DEFINED_TYPE'
-                }
+                disabled={fieldsDisabled.accountType}
                 popoverProps={{ minimal: true }}
                 popoverFill={true}
               />
@@ -209,7 +206,7 @@ function AccountFormDialogFields({
           <Button
             intent={Intent.PRIMARY}
             loading={isSubmitting}
-            style={{ minWidth: '75px' }}
+            style={{ minWidth: '95px' }}
             type="submit"
           >
             {action === 'edit' ? <T id={'edit'} /> : <T id={'submit'} />}
diff --git a/src/containers/Dialogs/AccountDialog/AccountDialogProvider.js b/src/containers/Dialogs/AccountDialog/AccountDialogProvider.js
index bf4377106..c175173f4 100644
--- a/src/containers/Dialogs/AccountDialog/AccountDialogProvider.js
+++ b/src/containers/Dialogs/AccountDialog/AccountDialogProvider.js
@@ -8,21 +8,14 @@ import {
   useAccounts,
   useEditAccount,
 } from 'hooks/query';
+import { AccountDialogAction, getDisabledFormFields } from './utils';
 
 const AccountDialogContext = createContext();
 
 /**
  * Account form provider.
  */
-function AccountDialogProvider({
-  accountId,
-  parentAccountId,
-  action,
-  accountType,
-
-  dialogName,
-  ...props
-}) {
+function AccountDialogProvider({ dialogName, payload, ...props }) {
   // Create and edit account mutations.
   const { mutateAsync: createAccountMutate } = useCreateAccount();
   const { mutateAsync: editAccountMutate } = useEditAccount();
@@ -35,22 +28,31 @@ function AccountDialogProvider({
     useAccountsTypes();
 
   // Fetches the specific account details.
-  const { data: account, isLoading: isAccountLoading } = useAccount(accountId, {
-    enabled: !!accountId,
-  });
+  const { data: account, isLoading: isAccountLoading } = useAccount(
+    payload.accountId,
+    {
+      enabled:
+        !!payload.accountId && payload.action === AccountDialogAction.Edit,
+    },
+  );
 
   // Handle fetch Currencies data table
   const { data: currencies, isLoading: isCurrenciesLoading } = useCurrencies();
 
-  const isNewMode = !accountId;
+  const isNewMode = !payload?.action;
+
+  // Retrieves the disabled fields of the form.
+  const fieldsDisabled = React.useMemo(
+    () => getDisabledFormFields(account, payload),
+    [account, payload],
+  );
 
   // Provider payload.
   const provider = {
     dialogName,
-    accountId,
-    parentAccountId,
-    action,
-    accountType,
+    payload,
+    fieldsDisabled,
+
     currencies,
 
     createAccountMutate,
diff --git a/src/containers/Dialogs/AccountDialog/index.js b/src/containers/Dialogs/AccountDialog/index.js
index c417ac1de..3c6d73f58 100644
--- a/src/containers/Dialogs/AccountDialog/index.js
+++ b/src/containers/Dialogs/AccountDialog/index.js
@@ -18,9 +18,11 @@ function AccountFormDialog({
     <Dialog
       name={dialogName}
       title={
-        (payload.action === 'edit') ?
-          (<T id={'edit_account'} />) :
-          (<T id={'new_account'} />)
+        payload.action === 'edit' ? (
+          <T id={'edit_account'} />
+        ) : (
+          <T id={'new_account'} />
+        )
       }
       className={'dialog--account-form'}
       autoFocus={true}
@@ -28,18 +30,10 @@ function AccountFormDialog({
       isOpen={isOpen}
     >
       <DialogSuspense>
-        <AccountDialogContent
-          dialogName={dialogName}
-          accountId={payload.id}
-          action={payload.action}
-          parentAccountId={payload.parentAccountId}
-          accountType={payload.accountType}
-        />
+        <AccountDialogContent dialogName={dialogName} payload={payload} />
       </DialogSuspense>
     </Dialog>
   );
 }
 
-export default compose(
-  withDialogRedux(),
-)(AccountFormDialog);
\ No newline at end of file
+export default compose(withDialogRedux())(AccountFormDialog);
diff --git a/src/containers/Dialogs/AccountDialog/utils.js b/src/containers/Dialogs/AccountDialog/utils.js
index 3c165d862..3a7985bda 100644
--- a/src/containers/Dialogs/AccountDialog/utils.js
+++ b/src/containers/Dialogs/AccountDialog/utils.js
@@ -1,7 +1,17 @@
 import intl from 'react-intl-universal';
 import * as R from 'ramda';
-import { isEmpty } from 'lodash';
+import { isUndefined } from 'lodash';
 
+//
+export const AccountDialogAction = {
+  Edit: 'edit',
+  NewChild: 'NewChild',
+  NewDefinedType: 'NewDefinedType',
+};
+
+/**
+ * Transformes the response API errors.
+ */
 export const transformApiErrors = (errors) => {
   const fields = {};
   if (errors.find((e) => e.type === 'NOT_UNIQUE_CODE')) {
@@ -23,7 +33,7 @@ export const transformApiErrors = (errors) => {
 /**
  * Payload transformer in account edit mode.
  */
-function transformEditMode(payload) {
+function tranformNewChildAccountPayload(payload) {
   return {
     parent_account_id: payload.parentAccountId || '',
     account_type: payload.accountType || '',
@@ -34,7 +44,7 @@ function transformEditMode(payload) {
 /**
  * Payload transformer in new account with defined type.
  */
-function transformNewAccountDefinedType(payload) {
+function transformNewDefinedTypePayload(payload) {
   return {
     account_type: payload.accountType || '',
   };
@@ -60,9 +70,9 @@ const defaultPayloadTransform = () => ({});
  */
 function getConditions() {
   return [
-    ['edit'],
-    ['new_child', transformEditMode],
-    ['NEW_ACCOUNT_DEFINED_TYPE', transformNewAccountDefinedType],
+    [AccountDialogAction.Edit],
+    [AccountDialogAction.NewChild, tranformNewChildAccountPayload],
+    [AccountDialogAction.NewDefinedType, transformNewDefinedTypePayload],
   ];
 }
 
@@ -73,7 +83,7 @@ export const transformAccountToForm = (account, payload) => {
   const conditions = getConditions();
 
   const results = conditions.map((condition) => {
-    const transformer = !isEmpty(condition[1])
+    const transformer = !isUndefined(condition[1])
       ? condition[1]
       : defaultPayloadTransform;
 
@@ -84,3 +94,15 @@ export const transformAccountToForm = (account, payload) => {
   });
   return R.cond(results)(account);
 };
+
+/**
+ * Detarmines whether the for fields are disabled.
+ */
+export const getDisabledFormFields = (account, payload) => {
+  return {
+    accountType:
+      payload.action === AccountDialogAction.Edit ||
+      payload.action === AccountDialogAction.NewChild ||
+      payload.action === AccountDialogAction.NewDefinedType,
+  };
+};
diff --git a/src/containers/Drawers/AccountDrawer/AccountDrawerActionBar.js b/src/containers/Drawers/AccountDrawer/AccountDrawerActionBar.js
index a65f3042b..30d8b145e 100644
--- a/src/containers/Drawers/AccountDrawer/AccountDrawerActionBar.js
+++ b/src/containers/Drawers/AccountDrawer/AccountDrawerActionBar.js
@@ -9,15 +9,15 @@ import {
 } from '@blueprintjs/core';
 import { Can, FormattedMessage as T } from 'components';
 
+import { AccountAction, AbilitySubject } from '../../../common/abilityOption';
 import DashboardActionsBar from 'components/Dashboard/DashboardActionsBar';
+
 import withDialogActions from 'containers/Dialog/withDialogActions';
 import withAlertsActions from 'containers/Alert/withAlertActions';
 
-import { safeCallback } from 'utils';
-import { AccountAction, AbilitySubject } from '../../../common/abilityOption';
-
-import { compose } from 'utils';
+import { AccountDialogAction } from 'containers/Dialogs/AccountDialog/utils';
 import { useAccountDrawerContext } from './AccountDrawerProvider';
+import { compose, safeCallback } from 'utils';
 
 /**
  * Account drawer action bar.
@@ -35,17 +35,18 @@ function AccountDrawerActionBar({
   // Handle new child button click.
   const onNewChildAccount = () => {
     openDialog('account-form', {
-      action: 'new_child',
+      action: AccountDialogAction.NewChild,
       parentAccountId: account.id,
       accountType: account.account_type,
     });
   };
-
   // Handle edit account action.
   const onEditAccount = () => {
-    openDialog('account-form', { action: 'edit', id: account.id });
+    openDialog('account-form', {
+      action: AccountDialogAction.Edit,
+      id: account.id,
+    });
   };
-
   // Handle delete action account.
   const onDeleteAccount = () => {
     openAlert('account-delete', { accountId: account.id });
diff --git a/src/lang/ar/index.json b/src/lang/ar/index.json
index 3accd9b2f..0c4635ba9 100644
--- a/src/lang/ar/index.json
+++ b/src/lang/ar/index.json
@@ -1778,7 +1778,7 @@
   "credit_note_preview.dialog.title": "معاينة إشعار الدائن PDF",
   "payment_receive_preview.dialog.title": "معاينة سند الزبون PDF",
   "balance_sheet.comparisons": "مقارنات",
-  "balance_sheet.dimensions": "Dimensions",
+  "balance_sheet.dimensions": "الابعاد",
   "balance_sheet.percentage_of_column": "% التغير العمودي",
   "balance_sheet.percentage_of_row": "% التغير الأفقي",
   "balance_sheet.previous_year": "السنة السابقة (س.س)",
@@ -1786,7 +1786,7 @@
   "balance_sheet.change": "% التغيرات",
   "balance_sheet.previous_period": "الفترة السابقة (ف.س) ",
   "profit_loss_sheet.comparisons": "مقارنات",
-  "profit_loss_sheet.dimensions": "Dimensions",
+  "profit_loss_sheet.dimensions": "الابعاد",
   "profit_loss_sheet.previous_year": "السنة السابقة (س.س)",
   "profit_loss_sheet.total_change": "إجمالي التغيرات",
   "profit_loss_sheet.perentage_change": "% التغيرات",

From d842722183a3206466d440a8503e0956a60f3091 Mon Sep 17 00:00:00 2001
From: "a.bouhuolia" <a.bouhuolia@live.com>
Date: Mon, 28 Mar 2022 12:08:53 +0200
Subject: [PATCH 06/28] fix: add the missed imported warehouse transfers.

---
 src/hooks/query/index.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/hooks/query/index.js b/src/hooks/query/index.js
index 1d4fa2f8d..4fe11e9b7 100644
--- a/src/hooks/query/index.js
+++ b/src/hooks/query/index.js
@@ -33,5 +33,6 @@ export * from './roles';
 export * from './creditNote';
 export * from './vendorCredit';
 export * from './transactionsLocking';
-export * from './warehouses'
+export * from './warehouses';
 export * from './branches';
+export * from './warehousesTransfers';

From e0eaa56b5cd86c5aa7d6ed677a38c2a00a0a4973 Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Mon, 28 Mar 2022 13:26:21 +0200
Subject: [PATCH 07/28] fix: navbar divider.

---
 src/containers/Drawers/BillDrawer/BillDetailActionsBar.js     | 2 +-
 .../CustomerDetailsDrawer/CustomerDetailsActionsBar.js        | 4 ++--
 .../Drawers/EstimateDetailDrawer/EstimateDetailActionsBar.js  | 2 +-
 .../Drawers/ExpenseDrawer/ExpenseDrawerActionBar.js           | 2 +-
 .../Drawers/ItemDetailDrawer/ItemDetailActionsBar.js          | 3 +--
 .../ManualJournalDrawer/ManualJournalDrawerActionBar.js       | 2 +-
 .../PaymentMadeDetailDrawer/PaymentMadeDetailActionsBar.js    | 2 +-
 .../PaymentReceiveDetailDrawer/PaymentReceiveActionsBar.js    | 2 +-
 .../Drawers/ReceiptDetailDrawer/ReceiptDetailActionBar.js     | 2 +-
 .../VendorCreditDetailDrawer/VendorCreditDetailActionsBar.js  | 2 +-
 .../Drawers/VendorDetailsDrawer/VendorDetailsActionsBar.js    | 4 ++--
 11 files changed, 13 insertions(+), 14 deletions(-)

diff --git a/src/containers/Drawers/BillDrawer/BillDetailActionsBar.js b/src/containers/Drawers/BillDrawer/BillDetailActionsBar.js
index 7f78410b5..833b156d9 100644
--- a/src/containers/Drawers/BillDrawer/BillDetailActionsBar.js
+++ b/src/containers/Drawers/BillDrawer/BillDetailActionsBar.js
@@ -95,9 +95,9 @@ function BillDetailActionsBar({
               onClick={handleQuickBillPayment}
             />
           </If>
-          <NavbarDivider />
         </Can>
         <Can I={BillAction.Delete} a={AbilitySubject.Bill}>
+          <NavbarDivider />
           <Button
             className={Classes.MINIMAL}
             icon={<Icon icon={'trash-16'} iconSize={16} />}
diff --git a/src/containers/Drawers/CustomerDetailsDrawer/CustomerDetailsActionsBar.js b/src/containers/Drawers/CustomerDetailsDrawer/CustomerDetailsActionsBar.js
index 226927dba..f27a0e281 100644
--- a/src/containers/Drawers/CustomerDetailsDrawer/CustomerDetailsActionsBar.js
+++ b/src/containers/Drawers/CustomerDetailsDrawer/CustomerDetailsActionsBar.js
@@ -131,17 +131,17 @@ function CustomerDetailsActionsBar({
           />
         </Popover>
 
-        <NavbarDivider />
         <Can I={CustomerAction.Edit} a={AbilitySubject.Customer}>
+          <NavbarDivider />
           <Button
             className={Classes.MINIMAL}
             icon={<Icon icon="pen-18" />}
             text={intl.get('customer.drawer.action.edit')}
             onClick={handleEditContact}
           />
-          <NavbarDivider />
         </Can>
         <Can I={CustomerAction.Delete} a={AbilitySubject.Customer}>
+          <NavbarDivider />
           <Button
             className={Classes.MINIMAL}
             icon={<Icon icon={'trash-16'} iconSize={16} />}
diff --git a/src/containers/Drawers/EstimateDetailDrawer/EstimateDetailActionsBar.js b/src/containers/Drawers/EstimateDetailDrawer/EstimateDetailActionsBar.js
index 21c669274..fd28a0952 100644
--- a/src/containers/Drawers/EstimateDetailDrawer/EstimateDetailActionsBar.js
+++ b/src/containers/Drawers/EstimateDetailDrawer/EstimateDetailActionsBar.js
@@ -96,9 +96,9 @@ function EstimateDetailActionsBar({
             intent={Intent.DANGER}
             onClick={handleDeleteEstimate}
           />
-          <NavbarDivider />
         </Can>
         <Can I={SaleEstimateAction.NotifyBySms} a={AbilitySubject.Estimate}>
+          <NavbarDivider />
           <MoreMenuItems
             payload={{
               onNotifyViaSMS: handleNotifyViaSMS,
diff --git a/src/containers/Drawers/ExpenseDrawer/ExpenseDrawerActionBar.js b/src/containers/Drawers/ExpenseDrawer/ExpenseDrawerActionBar.js
index 65093a190..129328fd2 100644
--- a/src/containers/Drawers/ExpenseDrawer/ExpenseDrawerActionBar.js
+++ b/src/containers/Drawers/ExpenseDrawer/ExpenseDrawerActionBar.js
@@ -55,9 +55,9 @@ function ExpenseDrawerActionBar({
             text={<T id={'edit_expense'} />}
             onClick={handleEditExpense}
           />
-          <NavbarDivider />
         </Can>
         <Can I={ExpenseAction.Delete} a={AbilitySubject.Expense}>
+          <NavbarDivider />
           <Button
             className={Classes.MINIMAL}
             icon={<Icon icon="trash-16" iconSize={16} />}
diff --git a/src/containers/Drawers/ItemDetailDrawer/ItemDetailActionsBar.js b/src/containers/Drawers/ItemDetailDrawer/ItemDetailActionsBar.js
index 39489bb90..738d82781 100644
--- a/src/containers/Drawers/ItemDetailDrawer/ItemDetailActionsBar.js
+++ b/src/containers/Drawers/ItemDetailDrawer/ItemDetailActionsBar.js
@@ -55,10 +55,9 @@ function ItemDetailActionsBar({
             text={<T id={'edit_item'} />}
             onClick={handleEditItem}
           />
-
-          <NavbarDivider />
         </Can>
         <Can I={ItemAction.Delete} a={AbilitySubject.Item}>
+          <NavbarDivider />
           <Button
             className={Classes.MINIMAL}
             icon={<Icon icon={'trash-16'} iconSize={16} />}
diff --git a/src/containers/Drawers/ManualJournalDrawer/ManualJournalDrawerActionBar.js b/src/containers/Drawers/ManualJournalDrawer/ManualJournalDrawerActionBar.js
index a4d435107..31f29a0e7 100644
--- a/src/containers/Drawers/ManualJournalDrawer/ManualJournalDrawerActionBar.js
+++ b/src/containers/Drawers/ManualJournalDrawer/ManualJournalDrawerActionBar.js
@@ -55,9 +55,9 @@ function ManualJournalDrawerActionBar({
             text={<T id={'edit_journal'} />}
             onClick={handleEditManualJournal}
           />
-          <NavbarDivider />
         </Can>
         <Can I={ManualJournalAction.Delete} a={AbilitySubject.ManualJournal}>
+          <NavbarDivider />
           <Button
             className={Classes.MINIMAL}
             icon={<Icon icon="trash-16" iconSize={16} />}
diff --git a/src/containers/Drawers/PaymentMadeDetailDrawer/PaymentMadeDetailActionsBar.js b/src/containers/Drawers/PaymentMadeDetailDrawer/PaymentMadeDetailActionsBar.js
index d0731aeac..2ecdf1a12 100644
--- a/src/containers/Drawers/PaymentMadeDetailDrawer/PaymentMadeDetailActionsBar.js
+++ b/src/containers/Drawers/PaymentMadeDetailDrawer/PaymentMadeDetailActionsBar.js
@@ -58,9 +58,9 @@ function PaymentMadeDetailActionsBar({
             text={<T id={'edit_payment_made'} />}
             onClick={handleEditPaymentMade}
           />
-          <NavbarDivider />
         </Can>
         <Can I={PaymentMadeAction.Delete} a={AbilitySubject.PaymentMade}>
+          <NavbarDivider />
           <Button
             className={Classes.MINIMAL}
             icon={<Icon icon={'trash-16'} iconSize={16} />}
diff --git a/src/containers/Drawers/PaymentReceiveDetailDrawer/PaymentReceiveActionsBar.js b/src/containers/Drawers/PaymentReceiveDetailDrawer/PaymentReceiveActionsBar.js
index 14f305f80..3ef447af7 100644
--- a/src/containers/Drawers/PaymentReceiveDetailDrawer/PaymentReceiveActionsBar.js
+++ b/src/containers/Drawers/PaymentReceiveDetailDrawer/PaymentReceiveActionsBar.js
@@ -95,12 +95,12 @@ function PaymentReceiveActionsBar({
             intent={Intent.DANGER}
             onClick={handleDeletePaymentReceive}
           />
-          <NavbarDivider />
         </Can>
         <Can
           I={PaymentReceiveAction.NotifyBySms}
           a={AbilitySubject.PaymentReceive}
         >
+          <NavbarDivider />
           <MoreMenuItems
             payload={{
               onNotifyViaSMS: handleNotifyViaSMS,
diff --git a/src/containers/Drawers/ReceiptDetailDrawer/ReceiptDetailActionBar.js b/src/containers/Drawers/ReceiptDetailDrawer/ReceiptDetailActionBar.js
index 4d78f8d74..41bcf775b 100644
--- a/src/containers/Drawers/ReceiptDetailDrawer/ReceiptDetailActionBar.js
+++ b/src/containers/Drawers/ReceiptDetailDrawer/ReceiptDetailActionBar.js
@@ -92,9 +92,9 @@ function ReceiptDetailActionBar({
             intent={Intent.DANGER}
             onClick={safeCallback(onDeleteReceipt)}
           />
-          <NavbarDivider />
         </Can>
         <Can I={SaleReceiptAction.NotifyBySms} a={AbilitySubject.Receipt}>
+          <NavbarDivider />
           <MoreMenuItems
             payload={{
               onNotifyViaSMS: handleNotifyViaSMS,
diff --git a/src/containers/Drawers/VendorCreditDetailDrawer/VendorCreditDetailActionsBar.js b/src/containers/Drawers/VendorCreditDetailDrawer/VendorCreditDetailActionsBar.js
index 5a7cf5f42..2ae2b406a 100644
--- a/src/containers/Drawers/VendorCreditDetailDrawer/VendorCreditDetailActionsBar.js
+++ b/src/containers/Drawers/VendorCreditDetailDrawer/VendorCreditDetailActionsBar.js
@@ -79,10 +79,10 @@ function VendorCreditDetailActionsBar({
               text={<T id={'refund'} />}
               onClick={handleRefundVendorCredit}
             />
-            <NavbarDivider />
           </If>
         </Can>
         <Can I={VendorCreditAction.Delete} a={AbilitySubject.VendorCredit}>
+          <NavbarDivider />
           <Button
             className={Classes.MINIMAL}
             icon={<Icon icon={'trash-16'} iconSize={16} />}
diff --git a/src/containers/Drawers/VendorDetailsDrawer/VendorDetailsActionsBar.js b/src/containers/Drawers/VendorDetailsDrawer/VendorDetailsActionsBar.js
index 82d1c2967..74d346ea7 100644
--- a/src/containers/Drawers/VendorDetailsDrawer/VendorDetailsActionsBar.js
+++ b/src/containers/Drawers/VendorDetailsDrawer/VendorDetailsActionsBar.js
@@ -102,17 +102,17 @@ function VendorDetailsActionsBar({
             icon={<Icon icon={'plus'} />}
           />
         </Popover>
-        <NavbarDivider />
         <Can I={VendorAction.Edit} a={AbilitySubject.Vendor}>
+          <NavbarDivider />
           <Button
             className={Classes.MINIMAL}
             icon={<Icon icon="pen-18" />}
             text={<T id={'vendor.drawer.action.edit'} />}
             onClick={safeCallback(onEditContact)}
           />
-          <NavbarDivider />
         </Can>
         <Can I={VendorAction.Delete} a={AbilitySubject.Vendor}>
+          <NavbarDivider />
           <Button
             className={Classes.MINIMAL}
             icon={<Icon icon={'trash-16'} iconSize={16} />}

From e87b22801b76ae3bf8488464e3b482e4df59fa73 Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Mon, 28 Mar 2022 13:46:41 +0200
Subject: [PATCH 08/28] BIG-221: remove non inventory radio.

---
 src/containers/Items/ItemFormPrimarySection.js | 12 +++++-------
 src/containers/Items/utils.js                  |  1 -
 2 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/src/containers/Items/ItemFormPrimarySection.js b/src/containers/Items/ItemFormPrimarySection.js
index 4e779f514..88987a2a7 100644
--- a/src/containers/Items/ItemFormPrimarySection.js
+++ b/src/containers/Items/ItemFormPrimarySection.js
@@ -47,11 +47,6 @@ export default function ItemFormPrimarySection() {
       <div class="mb1">
         <FormattedHTMLMessage id={'products_you_buy_and_or_sell'} />
       </div>
-      <div class="mb1">
-        <FormattedHTMLMessage
-          id={'products_you_buy_and_or_sell_but_don_t_need'}
-        />
-      </div>
     </>
   );
 
@@ -86,7 +81,6 @@ export default function ItemFormPrimarySection() {
               disabled={!isNewMode && item.type === 'inventory'}
             >
               <Radio label={<T id={'service'} />} value="service" />
-              <Radio label={<T id={'non_inventory'} />} value="non-inventory" />
               <Radio label={<T id={'inventory'} />} value="inventory" />
             </RadioGroup>
           </FormGroup>
@@ -126,7 +120,11 @@ export default function ItemFormPrimarySection() {
                 helperText={<ErrorMessage name={'code'} />}
                 inline={true}
               >
-                <InputGroup medium={true} intent={inputIntent({ error, touched })} {...field} />
+                <InputGroup
+                  medium={true}
+                  intent={inputIntent({ error, touched })}
+                  {...field}
+                />
               </FormGroup>
             )}
           </FastField>
diff --git a/src/containers/Items/utils.js b/src/containers/Items/utils.js
index 8031e56ea..6f3da4c94 100644
--- a/src/containers/Items/utils.js
+++ b/src/containers/Items/utils.js
@@ -64,7 +64,6 @@ export const transitionItemTypeKeyToLabel = (itemTypeKey) => {
   const table = {
     service: intl.get('service'),
     inventory: intl.get('inventory'),
-    'non-inventory': intl.get('non_inventory'),
   };
   return typeof table[itemTypeKey] === 'string' ? table[itemTypeKey] : '';
 };

From 79099e1abc878a56c92ac9af2a296ede537c6a60 Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Mon, 28 Mar 2022 15:46:37 +0200
Subject: [PATCH 09/28] BIG-280: optimize select.

---
 src/components/Accounts/AccountMultiSelect.js | 73 +++++++++++++++++++
 src/components/Accounts/index.js              |  1 +
 src/components/index.js                       |  1 +
 .../GeneralLedgerHeaderGeneralPane.js         | 12 +--
 .../GeneralLedger/common.js                   |  1 +
 5 files changed, 83 insertions(+), 5 deletions(-)
 create mode 100644 src/components/Accounts/AccountMultiSelect.js
 create mode 100644 src/components/Accounts/index.js

diff --git a/src/components/Accounts/AccountMultiSelect.js b/src/components/Accounts/AccountMultiSelect.js
new file mode 100644
index 000000000..8e9d54882
--- /dev/null
+++ b/src/components/Accounts/AccountMultiSelect.js
@@ -0,0 +1,73 @@
+import React from 'react';
+import styled from 'styled-components';
+import { MenuItem } from '@blueprintjs/core';
+import { FMultiSelect } from '../Forms';
+import classNames from 'classnames';
+import { Classes } from '@blueprintjs/popover2';
+
+/**
+ *
+ * @param {*} query
+ * @param {*} account
+ * @param {*} _index
+ * @param {*} exactMatch
+ * @returns
+ */
+const accountItemPredicate = (query, account, _index, exactMatch) => {
+  const normalizedTitle = account.name.toLowerCase();
+  const normalizedQuery = query.toLowerCase();
+
+  if (exactMatch) {
+    return normalizedTitle === normalizedQuery;
+  } else {
+    return `${account.code}. ${normalizedTitle}`.indexOf(normalizedQuery) >= 0;
+  }
+};
+
+/**
+ *
+ * @param {*} account
+ * @param {*} param1
+ * @returns
+ */
+const accountItemRenderer = (
+  account,
+  { handleClick, modifiers, query },
+  { isSelected },
+) => {
+  return (
+    <MenuItem
+      icon={isSelected ? 'tick' : 'blank'}
+      text={account.name}
+      label={account.code}
+      key={account.id}
+      onClick={handleClick}
+    />
+  );
+};
+
+const accountSelectProps = {
+  itemPredicate: accountItemPredicate,
+  itemRenderer: accountItemRenderer,
+  valueAccessor: (item) => item.id,
+  labelAccessor: (item) => item.code,
+  tagRenderer: (item) => item.name,
+};
+
+/**
+ * branches mulit select.
+ * @param {*} param0
+ * @returns {JSX.Element}
+ */
+export function AccountMultiSelect({ accounts, ...rest }) {
+  return (
+    <FMultiSelect
+      items={accounts}
+      popoverProps={{
+        minimal: true,
+      }}
+      {...accountSelectProps}
+      {...rest}
+    />
+  );
+}
diff --git a/src/components/Accounts/index.js b/src/components/Accounts/index.js
new file mode 100644
index 000000000..791394be9
--- /dev/null
+++ b/src/components/Accounts/index.js
@@ -0,0 +1 @@
+export * from './AccountMultiSelect';
diff --git a/src/components/index.js b/src/components/index.js
index 16e1003b6..c91a4f1a1 100644
--- a/src/components/index.js
+++ b/src/components/index.js
@@ -104,6 +104,7 @@ export * from './Warehouses';
 export * from './Currencies';
 export * from './FormTopbar'
 export * from './Paper';
+export * from './Accounts'
 
 const Hint = FieldHint;
 
diff --git a/src/containers/FinancialStatements/GeneralLedger/GeneralLedgerHeaderGeneralPane.js b/src/containers/FinancialStatements/GeneralLedger/GeneralLedgerHeaderGeneralPane.js
index 5aef980ec..3c196589c 100644
--- a/src/containers/FinancialStatements/GeneralLedger/GeneralLedgerHeaderGeneralPane.js
+++ b/src/containers/FinancialStatements/GeneralLedger/GeneralLedgerHeaderGeneralPane.js
@@ -3,7 +3,8 @@ import { FormGroup, Classes } from '@blueprintjs/core';
 import { FormattedMessage as T } from 'components';
 import classNames from 'classnames';
 
-import { AccountsMultiSelect, Row, Col } from 'components';
+import { AccountMultiSelect, Row, Col } from 'components';
+import { FFormGroup } from '../../../components/Forms';
 
 import FinancialStatementDateRange from 'containers/FinancialStatements/FinancialStatementDateRange';
 import RadiosAccountingBasis from '../RadiosAccountingBasis';
@@ -44,12 +45,13 @@ function GLHeaderGeneralPaneContent() {
       </Row>
       <Row>
         <Col xs={4}>
-          <FormGroup
+          <FFormGroup
             label={<T id={'specific_accounts'} />}
-            className={classNames('form-group--select-list', Classes.FILL)}
+            name={'accounts'}
+            className={Classes.FILL}
           >
-            <AccountsMultiSelect items={accounts} />
-          </FormGroup>
+            <AccountMultiSelect name="accounts" accounts={accounts} />
+          </FFormGroup>
         </Col>
       </Row>
 
diff --git a/src/containers/FinancialStatements/GeneralLedger/common.js b/src/containers/FinancialStatements/GeneralLedger/common.js
index 8463342b1..5d97024c6 100644
--- a/src/containers/FinancialStatements/GeneralLedger/common.js
+++ b/src/containers/FinancialStatements/GeneralLedger/common.js
@@ -32,6 +32,7 @@ export const getDefaultGeneralLedgerQuery = () => {
     basis: 'accural',
     filterByOption: 'with-transactions',
     branchesIds: [],
+    accounts: [],
   };
 };
 

From 2b079173995d621a973bd03fd2bf747c110fb221 Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Mon, 28 Mar 2022 15:48:36 +0200
Subject: [PATCH 10/28] BIG-352: invalid date.

---
 .../InventoryAdjustmentDetailHeader.js                    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/containers/Drawers/InventoryAdjustmentDetailDrawer/InventoryAdjustmentDetailHeader.js b/src/containers/Drawers/InventoryAdjustmentDetailDrawer/InventoryAdjustmentDetailHeader.js
index 91529092d..c047132b4 100644
--- a/src/containers/Drawers/InventoryAdjustmentDetailDrawer/InventoryAdjustmentDetailHeader.js
+++ b/src/containers/Drawers/InventoryAdjustmentDetailDrawer/InventoryAdjustmentDetailHeader.js
@@ -5,7 +5,7 @@ import intl from 'react-intl-universal';
 import { defaultTo } from 'lodash';
 import clsx from 'classnames';
 
-import { DetailsMenu, DetailItem } from 'components';
+import { DetailsMenu, DetailItem, FormatDate } from 'components';
 import { useInventoryAdjustmentDrawerContext } from './InventoryAdjustmentDrawerProvider';
 
 import InventoryAdjustmentDrawerCls from 'style/components/Drawers/InventoryAdjustmentDrawer.module.scss';
@@ -20,7 +20,7 @@ export default function InventoryAdjustmentDetailHeader() {
     <div className={clsx(InventoryAdjustmentDrawerCls.detail_panel_header)}>
       <DetailsMenu direction={'horizantal'} minLabelSize={'180px'}>
         <DetailItem label={intl.get('date')}>
-          {moment(inventoryAdjustment.date).format('YYYY MMM DD')}
+          <FormatDate value={inventoryAdjustment.date} />
         </DetailItem>
 
         <DetailItem label={intl.get('type')}>
@@ -36,7 +36,7 @@ export default function InventoryAdjustmentDetailHeader() {
         </DetailItem>
 
         <DetailItem label={intl.get('published_at')}>
-          {moment(inventoryAdjustment.published_at).format('YYYY MMM DD')}
+          <FormatDate value={inventoryAdjustment.published_at} />
         </DetailItem>
 
         <DetailItem label={intl.get('reason')}>
@@ -44,7 +44,7 @@ export default function InventoryAdjustmentDetailHeader() {
         </DetailItem>
 
         <DetailItem label={intl.get('created_at')}>
-          {moment(inventoryAdjustment.created_at).format('YYYY MMM DD')}
+          <FormatDate value={inventoryAdjustment.created_at} />
         </DetailItem>
       </DetailsMenu>
     </div>

From 7774d9f5ab9177b8cd54c162f62af5596cb44772 Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Mon, 28 Mar 2022 16:01:07 +0200
Subject: [PATCH 11/28] BIG: add keepPreviousData .

---
 .../APAgingSummaryHeaderDimensionsProvider.js          |  1 +
 .../ARAgingSummaryHeaderDimensionsProvider.js          |  1 +
 .../BalanceSheetHeaderDimensionsProvider.js            |  1 +
 .../CashFlowStatementDimensionsPanelProvider.js        | 10 +++++-----
 .../GeneralLedgerHeaderDimensionsPanelProvider.js      |  1 +
 .../InventoryValuationHeaderDimensionsPanelProvider.js |  3 ++-
 .../ProfitLossSheet/ProfitLossProvider.js              |  9 ++++++---
 .../ProfitLossSheetHeaderDimensionsProvider.js         |  1 +
 .../TrialBalanceSheetHeaderDimensionsPanelProvider.js  |  1 +
 9 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/src/containers/FinancialStatements/APAgingSummary/APAgingSummaryHeaderDimensionsProvider.js b/src/containers/FinancialStatements/APAgingSummary/APAgingSummaryHeaderDimensionsProvider.js
index d3a9e733b..3b28d8dcf 100644
--- a/src/containers/FinancialStatements/APAgingSummary/APAgingSummaryHeaderDimensionsProvider.js
+++ b/src/containers/FinancialStatements/APAgingSummary/APAgingSummaryHeaderDimensionsProvider.js
@@ -18,6 +18,7 @@ function APAgingSummaryHeaderDimensionsProvider({ query, ...props }) {
   // Fetches the branches list.
   const { isLoading: isBranchesLoading, data: branches } = useBranches(query, {
     enabled: isBranchFeatureCan,
+    keepPreviousData: true,
   });
 
   // Provider
diff --git a/src/containers/FinancialStatements/ARAgingSummary/ARAgingSummaryHeaderDimensionsProvider.js b/src/containers/FinancialStatements/ARAgingSummary/ARAgingSummaryHeaderDimensionsProvider.js
index fdd7c278b..71ad214ec 100644
--- a/src/containers/FinancialStatements/ARAgingSummary/ARAgingSummaryHeaderDimensionsProvider.js
+++ b/src/containers/FinancialStatements/ARAgingSummary/ARAgingSummaryHeaderDimensionsProvider.js
@@ -18,6 +18,7 @@ function ARAgingSummaryHeaderDimensionsProvider({ query, ...props }) {
   // Fetches the branches list.
   const { isLoading: isBranchesLoading, data: branches } = useBranches(query, {
     enabled: isBranchFeatureCan,
+    keepPreviousData: true,
   });
 
   // Provider
diff --git a/src/containers/FinancialStatements/BalanceSheet/BalanceSheetHeaderDimensionsProvider.js b/src/containers/FinancialStatements/BalanceSheet/BalanceSheetHeaderDimensionsProvider.js
index aaa1fe40a..be4fae5f6 100644
--- a/src/containers/FinancialStatements/BalanceSheet/BalanceSheetHeaderDimensionsProvider.js
+++ b/src/containers/FinancialStatements/BalanceSheet/BalanceSheetHeaderDimensionsProvider.js
@@ -19,6 +19,7 @@ function BalanceSheetHeaderDimensionsProvider({ query, ...props }) {
   // Fetches the branches list.
   const { isLoading: isBranchesLoading, data: branches } = useBranches(query, {
     enabled: isBranchFeatureCan,
+    keepPreviousData: true,
   });
 
   // Provider
diff --git a/src/containers/FinancialStatements/CashFlowStatement/CashFlowStatementDimensionsPanelProvider.js b/src/containers/FinancialStatements/CashFlowStatement/CashFlowStatementDimensionsPanelProvider.js
index 9b4ac1a79..a570eda1d 100644
--- a/src/containers/FinancialStatements/CashFlowStatement/CashFlowStatementDimensionsPanelProvider.js
+++ b/src/containers/FinancialStatements/CashFlowStatement/CashFlowStatementDimensionsPanelProvider.js
@@ -10,16 +10,16 @@ const CashFlowStatementDimensionsPanelContext = React.createContext();
  * cash flow statement dimensions panel provider.
  * @returns
  */
-function CashFlowStatementDimensionsPanelProvider({ query,...props }) {
+function CashFlowStatementDimensionsPanelProvider({ query, ...props }) {
   // Features guard.
   const { featureCan } = useFeatureCan();
   const isBranchFeatureCan = featureCan(Features.Branches);
 
   // Fetches the branches list.
-  const { isLoading: isBranchesLoading, data: branches } = useBranches(
-    query,
-    { enabled: isBranchFeatureCan },
-  );
+  const { isLoading: isBranchesLoading, data: branches } = useBranches(query, {
+    enabled: isBranchFeatureCan,
+    keepPreviousData: true,
+  });
 
   // Provider
   const provider = {
diff --git a/src/containers/FinancialStatements/GeneralLedger/GeneralLedgerHeaderDimensionsPanelProvider.js b/src/containers/FinancialStatements/GeneralLedger/GeneralLedgerHeaderDimensionsPanelProvider.js
index bdc93a85c..54df09df7 100644
--- a/src/containers/FinancialStatements/GeneralLedger/GeneralLedgerHeaderDimensionsPanelProvider.js
+++ b/src/containers/FinancialStatements/GeneralLedger/GeneralLedgerHeaderDimensionsPanelProvider.js
@@ -19,6 +19,7 @@ function GeneralLedgerHeaderDimensionsPanelProvider({ query, ...props }) {
   // Fetches the branches list.
   const { isLoading: isBranchesLoading, data: branches } = useBranches(query, {
     enabled: isBranchFeatureCan,
+    keepPreviousData: true,
   });
 
   // Provider
diff --git a/src/containers/FinancialStatements/InventoryValuation/InventoryValuationHeaderDimensionsPanelProvider.js b/src/containers/FinancialStatements/InventoryValuation/InventoryValuationHeaderDimensionsPanelProvider.js
index 1985ffaa5..f314aae68 100644
--- a/src/containers/FinancialStatements/InventoryValuation/InventoryValuationHeaderDimensionsPanelProvider.js
+++ b/src/containers/FinancialStatements/InventoryValuation/InventoryValuationHeaderDimensionsPanelProvider.js
@@ -24,12 +24,13 @@ function InventoryValuationHeaderDimensionsProvider({ ...props }) {
   // Fetches the warehouses list.
   const { data: warehouses, isLoading: isWarehouesLoading } = useWarehouses(
     null,
-    { enabled: isWarehouseFeatureCan },
+    { enabled: isWarehouseFeatureCan, keepPreviousData: true },
   );
 
   // Fetches the branches list.
   const { data: branches, isLoading: isBranchLoading } = useBranches(null, {
     enabled: isBranchFeatureCan,
+    keepPreviousData: true,
   });
 
   // Provider
diff --git a/src/containers/FinancialStatements/ProfitLossSheet/ProfitLossProvider.js b/src/containers/FinancialStatements/ProfitLossSheet/ProfitLossProvider.js
index 6ae218172..447437764 100644
--- a/src/containers/FinancialStatements/ProfitLossSheet/ProfitLossProvider.js
+++ b/src/containers/FinancialStatements/ProfitLossSheet/ProfitLossProvider.js
@@ -15,9 +15,12 @@ function ProfitLossSheetProvider({ query, ...props }) {
     isFetching,
     isLoading,
     refetch,
-  } = useProfitLossSheet({
-    ...transformFilterFormToQuery(query),
-  });
+  } = useProfitLossSheet(
+    {
+      ...transformFilterFormToQuery(query),
+    },
+    { keepPreviousData: true },
+  );
 
   const provider = {
     profitLossSheet,
diff --git a/src/containers/FinancialStatements/ProfitLossSheet/ProfitLossSheetHeaderDimensionsProvider.js b/src/containers/FinancialStatements/ProfitLossSheet/ProfitLossSheetHeaderDimensionsProvider.js
index b1ac95e97..def49072f 100644
--- a/src/containers/FinancialStatements/ProfitLossSheet/ProfitLossSheetHeaderDimensionsProvider.js
+++ b/src/containers/FinancialStatements/ProfitLossSheet/ProfitLossSheetHeaderDimensionsProvider.js
@@ -19,6 +19,7 @@ function ProfitLossSheetHeaderDimensionsProvider({ query, ...props }) {
   // Fetches the branches list.
   const { isLoading: isBranchesLoading, data: branches } = useBranches(query, {
     enabled: isBranchFeatureCan,
+    keepPreviousData: true,
   });
 
   // Provider
diff --git a/src/containers/FinancialStatements/TrialBalanceSheet/TrialBalanceSheetHeaderDimensionsPanelProvider.js b/src/containers/FinancialStatements/TrialBalanceSheet/TrialBalanceSheetHeaderDimensionsPanelProvider.js
index ece357e23..3a49470e7 100644
--- a/src/containers/FinancialStatements/TrialBalanceSheet/TrialBalanceSheetHeaderDimensionsPanelProvider.js
+++ b/src/containers/FinancialStatements/TrialBalanceSheet/TrialBalanceSheetHeaderDimensionsPanelProvider.js
@@ -18,6 +18,7 @@ function TrialBLHeaderDimensionsPanelProvider({ query, ...props }) {
   // Fetches the branches list.
   const { isLoading: isBranchesLoading, data: branches } = useBranches(query, {
     enabled: isBranchFeatureCan,
+    keepPreviousData: true,
   });
 
   // Provider

From 03ea8643e77bb1470cb161f4267729b4c278c28c Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Mon, 28 Mar 2022 16:18:54 +0200
Subject: [PATCH 12/28] BIG-284: cash flow statment loading bar.

---
 .../FinancialStatements/CashFlowStatement/components.js       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/containers/FinancialStatements/CashFlowStatement/components.js b/src/containers/FinancialStatements/CashFlowStatement/components.js
index 6cbd8e796..09c042a02 100644
--- a/src/containers/FinancialStatements/CashFlowStatement/components.js
+++ b/src/containers/FinancialStatements/CashFlowStatement/components.js
@@ -26,9 +26,9 @@ export const useCashFlowStatementColumns = () => {
  * Cash flow statement loading bar.
  */
 export function CashFlowStatementLoadingBar() {
-  const { isCashFlowLoading } = useCashFlowStatementContext();
+  const { isCashFlowFetching } = useCashFlowStatementContext();
   return (
-    <If condition={isCashFlowLoading}>
+    <If condition={isCashFlowFetching}>
       <FinancialLoadingBar />
     </If>
   );

From 767d8074902d1cff8f03ed912e261e03d1bd2615 Mon Sep 17 00:00:00 2001
From: "a.bouhuolia" <a.bouhuolia@live.com>
Date: Mon, 28 Mar 2022 19:06:38 +0200
Subject: [PATCH 13/28] fix: `BIG-352` Add terms and conditions/notes field to
 a warehouse transfer.

---
 .../PaymentForm/PaymentMadeFormFooterLeft.js  | 22 ++++++----
 .../PaymentForm/PaymentMadeFormProvider.js    |  2 +-
 .../CreditNoteFormFooterLeft.js               |  7 ++--
 .../InvoiceForm/InvoiceFormFooterLeft.js      |  3 +-
 .../PaymentReceiveFormFootetLeft.js           | 34 ++++++++++++---
 .../WarehouseTransferFormFooterLeft.js        |  7 ++--
 .../WarehouseTransferFormHeader.js            |  2 -
 .../WarehouseTransferFormHeaderFields.js      | 14 -------
 src/lang/ar/index.json                        |  4 +-
 src/lang/en/index.json                        | 41 ++++++++++++-------
 10 files changed, 79 insertions(+), 57 deletions(-)

diff --git a/src/containers/Purchases/PaymentMades/PaymentForm/PaymentMadeFormFooterLeft.js b/src/containers/Purchases/PaymentMades/PaymentForm/PaymentMadeFormFooterLeft.js
index 700c2ba9a..1cedd9ef9 100644
--- a/src/containers/Purchases/PaymentMades/PaymentForm/PaymentMadeFormFooterLeft.js
+++ b/src/containers/Purchases/PaymentMades/PaymentForm/PaymentMadeFormFooterLeft.js
@@ -3,24 +3,28 @@ import intl from 'react-intl-universal';
 import styled from 'styled-components';
 import { FFormGroup, FEditableText, FormattedMessage as T } from 'components';
 
+/**
+ * Payment made form footer left-side.
+ * @returns {JSX.Element}
+ */
 export function PaymentMadeFormFooterLeft() {
   return (
     <React.Fragment>
-      {/* --------- Statement--------- */}
-      <StatementFormGroup
-        name={'statement'}
-        label={<T id={'payment_made_form.label.statement'} />}
-        hintText={'Will be displayed on the Payment'}
+      {/* --------- Internal Note--------- */}
+      <InternalNoteFormGroup
+        name={'internal_note'}
+        label={<T id={'payment_made.form.internal_note.label'} />}
       >
         <FEditableText
-          name={'statement'}
-          placeholder={intl.get('payment_made_form.statement.placeholder')}
+          name={'internal_note'}
+          placeholder={intl.get('payment_made.form.internal_note.placeholder')}
         />
-      </StatementFormGroup>
+      </InternalNoteFormGroup>
     </React.Fragment>
   );
 }
-const StatementFormGroup = styled(FFormGroup)`
+
+const InternalNoteFormGroup = styled(FFormGroup)`
   &.bp3-form-group {
     margin-bottom: 40px;
 
diff --git a/src/containers/Purchases/PaymentMades/PaymentForm/PaymentMadeFormProvider.js b/src/containers/Purchases/PaymentMades/PaymentForm/PaymentMadeFormProvider.js
index af51416f8..e11f0a691 100644
--- a/src/containers/Purchases/PaymentMades/PaymentForm/PaymentMadeFormProvider.js
+++ b/src/containers/Purchases/PaymentMades/PaymentForm/PaymentMadeFormProvider.js
@@ -103,7 +103,7 @@ function PaymentMadeFormProvider({ query, paymentMadeId, ...props }) {
     <DashboardInsider
       loading={
         isVendorsLoading ||
-        isItemsFetching ||
+        isItemsLoading ||
         isAccountsLoading ||
         isPaymentLoading
       }
diff --git a/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormFooterLeft.js b/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormFooterLeft.js
index c0c3c2391..b0e0db116 100644
--- a/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormFooterLeft.js
+++ b/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormFooterLeft.js
@@ -10,7 +10,6 @@ export function CreditNoteFormFooterLeft() {
       <CreditNoteMsgFormGroup
         name={'note'}
         label={<T id={'credit_note.label_customer_note'} />}
-        hintText={'Will be displayed on the invoice'}
       >
         <FEditableText
           name={'note'}
@@ -24,9 +23,9 @@ export function CreditNoteFormFooterLeft() {
       >
         <FEditableText
           name={'terms_conditions'}
-          placeholder={
-            <T id={'credit_note.label_terms_and_conditions.placeholder'} />
-          }
+          placeholder={intl.get(
+            'credit_note.label_terms_and_conditions.placeholder',
+          )}
         />
       </TermsConditsFormGroup>
     </React.Fragment>
diff --git a/src/containers/Sales/Invoices/InvoiceForm/InvoiceFormFooterLeft.js b/src/containers/Sales/Invoices/InvoiceForm/InvoiceFormFooterLeft.js
index 426c67f94..98181f91a 100644
--- a/src/containers/Sales/Invoices/InvoiceForm/InvoiceFormFooterLeft.js
+++ b/src/containers/Sales/Invoices/InvoiceForm/InvoiceFormFooterLeft.js
@@ -10,7 +10,6 @@ export function InvoiceFormFooterLeft() {
       <InvoiceMsgFormGroup
         name={'invoice_message'}
         label={<T id={'invoice_message'} />}
-        hintText={'Will be displayed on the invoice'}
       >
         <FEditableText
           name={'invoice_message'}
@@ -20,7 +19,7 @@ export function InvoiceFormFooterLeft() {
 
       {/* --------- Terms and conditions --------- */}
       <TermsConditsFormGroup
-        label={<T id={'invoice_form.label.invoice_message'} />}
+        label={<T id={'invoice_form.label.terms_conditions'} />}
         name={'terms_conditions'}
       >
         <FEditableText
diff --git a/src/containers/Sales/PaymentReceives/PaymentReceiveForm/PaymentReceiveFormFootetLeft.js b/src/containers/Sales/PaymentReceives/PaymentReceiveForm/PaymentReceiveFormFootetLeft.js
index bc15a5b1f..486883543 100644
--- a/src/containers/Sales/PaymentReceives/PaymentReceiveForm/PaymentReceiveFormFootetLeft.js
+++ b/src/containers/Sales/PaymentReceives/PaymentReceiveForm/PaymentReceiveFormFootetLeft.js
@@ -7,14 +7,24 @@ export function PaymentReceiveFormFootetLeft() {
   return (
     <React.Fragment>
       {/* --------- Statement--------- */}
+      <PaymentMsgFormGroup
+        name={'message'}
+        label={<T id={'payment_receive_form.message.label'} />}
+      >
+        <FEditableText
+          name={'message'}
+          placeholder={intl.get('payment_receive_form.message.placeholder')}
+        />
+      </PaymentMsgFormGroup>
+
+      {/* --------- Internal Note--------- */}
       <TermsConditsFormGroup
-        name={'statement'}
-        label={<T id={'payment_receive_form.label.statement'} />}
-        hintText={'Will be displayed on the Payment'}
+        name={'internal_note'}
+        label={<T id={'payment_receive_form.label.internal_note'} />}
       >
         <FEditableText
-          name={'statement'}
-          placeholder={intl.get('payment_receive_form.statement.placeholder')}
+          name={'internal_note'}
+          placeholder={intl.get('payment_receive_form.internal_note.placeholder')}
         />
       </TermsConditsFormGroup>
     </React.Fragment>
@@ -32,3 +42,17 @@ const TermsConditsFormGroup = styled(FFormGroup)`
     }
   }
 `;
+
+const PaymentMsgFormGroup = styled(FFormGroup)`
+  &.bp3-form-group {
+    margin-bottom: 40px;
+
+    .bp3-label {
+      font-size: 12px;
+      margin-bottom: 12px;
+    }
+    .bp3-form-content {
+      margin-left: 10px;
+    }
+  }
+`;
diff --git a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormFooterLeft.js b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormFooterLeft.js
index c09d7db5e..4f3edc6ec 100644
--- a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormFooterLeft.js
+++ b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormFooterLeft.js
@@ -1,5 +1,6 @@
 import React from 'react';
 import styled from 'styled-components';
+import intl from 'react-intl-universal';
 import { FFormGroup, FEditableText, FormattedMessage as T } from 'components';
 
 export function WarehouseTransferFormFooterLeft() {
@@ -7,14 +8,12 @@ export function WarehouseTransferFormFooterLeft() {
     <React.Fragment>
       {/* --------- Terms and conditions --------- */}
       <TermsConditsFormGroup
-        label={<T id={'terms_conditions'} />}
+        label={<T id={'warehouse_transfer.form.reason.label'} />}
         name={'reason'}
       >
         <FEditableText
           name={'reason'}
-          placeholder={
-            'Enter the terms and conditions of your business to be displayed in your transaction'
-          }
+          placeholder={intl.get('warehouse_transfer.form.reason.placeholder')}
         />
       </TermsConditsFormGroup>
     </React.Fragment>
diff --git a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormHeader.js b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormHeader.js
index 3137b1e99..7a6ebc57a 100644
--- a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormHeader.js
+++ b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormHeader.js
@@ -1,7 +1,5 @@
 import React from 'react';
 import classNames from 'classnames';
-import { useFormikContext  } from 'formik';
-import intl from 'react-intl-universal';
 import { CLASSES } from 'common/classes';
 
 import WarehouseTransferFormHeaderFields from './WarehouseTransferFormHeaderFields';
diff --git a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormHeaderFields.js b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormHeaderFields.js
index 038d99a8a..acebd4c14 100644
--- a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormHeaderFields.js
+++ b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormHeaderFields.js
@@ -183,20 +183,6 @@ function WarehouseTransferFormHeaderFields({
           </FormGroup>
         )}
       </FastField>
-      {/*------------ reason -----------*/}
-      <FastField name={'reason'}>
-        {({ field, meta: { error, touched } }) => (
-          <FormGroup
-            label={<T id={'reason'} />}
-            className={'form-group--reason'}
-            intent={inputIntent({ error, touched })}
-            inline={true}
-            helperText={<ErrorMessage name={'reason'} />}
-          >
-            <InputGroup minimal={true} {...field} />
-          </FormGroup>
-        )}
-      </FastField>
     </div>
   );
 }
diff --git a/src/lang/ar/index.json b/src/lang/ar/index.json
index 1c5cde331..48edb6793 100644
--- a/src/lang/ar/index.json
+++ b/src/lang/ar/index.json
@@ -2003,7 +2003,7 @@
   "estimate.warehouse_button.label": "المخزن: {label}",
   "receipt.branch_button.label": "الفرع: {label}",
   "receipt.warehouse_button.label": "المخزن: {label}",
-  "warehouse_transfer.empty_status.title": "",
-  "warehouse_transfer.empty_status.description": "",
+  "warehouse_transfer.empty_status.title": "إدارة عمليات النقل بين المستودعات",
+  "warehouse_transfer.empty_status.description": "غالبًا ماتحتاج الاعمال ذات مستودعات متعددة لطلبات نقل البضائع من مستودع إلى آخر عندما تكون في حاجة ماسة إلى البائعين.",
   "item.error.you_could_not_delete_item_has_associated": "لا يمكنك حذف العنصر لديه معاملات مرتبطة به "
 }
\ No newline at end of file
diff --git a/src/lang/en/index.json b/src/lang/en/index.json
index fd2ad8d65..43e936ab8 100644
--- a/src/lang/en/index.json
+++ b/src/lang/en/index.json
@@ -1525,9 +1525,9 @@
   "credit_note.label_credit_note": "Credit Note #",
   "credit_note.label_amount_to_credit": "Amount to credit",
   "credit_note.label_credit_note_details": "Credit Note details",
-  "credit_note.label_customer_note": "Customer note",
-  "credit_note.label_terms_conditions": "Terms conditions",
-  "credit_note.label_customer_note.placeholder": "Thanks for your business and have a great day!",
+  "credit_note.label_customer_note": "Customer Note",
+  "credit_note.label_terms_conditions": "Terms & Conditions",
+  "credit_note.label_customer_note.placeholder": "The customer note will be displayed on the credit note.",
   "credit_note.label_terms_and_conditions.placeholder": "Enter the terms and conditions of your business to be displayed in your transaction",
   "credit_note.label_total": "TOTAL",
   "credit_note.label_subtotal": "Subtotal",
@@ -1948,42 +1948,51 @@
   "estimate_form.label.total": "TOTAL",
   "estimate_form.label.subtotal": "Subtotal",
   "estimate_form.label.customer_note": "Customer Note",
-  "estimate_form.label.terms_conditions": "Terms conditions",
-  "estimate_form.customer_note.placeholder": "Thanks for your business and have a great day!",
+  "estimate_form.label.terms_conditions": "Terms & Conditions",
+  "estimate_form.customer_note.placeholder": "This message will be displayed on the estimate.",
   "estimate_form.terms_and_conditions.placeholder": "Enter the terms and conditions of your business to be displayed in your transaction",
   "invoice_form.label.total": "TOTAL",
   "invoice_form.label.subtotal": "Subtotal",
   "invoice_form.label.due_amount": "Due amount",
   "invoice_form.label.payment_amount": "Payment amount",
   "invoice_form.label.invoice_message": "Invoice Message",
-  "invoice_form.invoice_message.placeholder": "Thanks for your business and have a great day!",
-  "invoice_form.terms_and_conditions.placeholder": "Enter the terms and conditions of your business to be displayed in your transaction",
+  "invoice_form.label.terms_conditions": "Terms & Conditions",
+  "invoice_form.invoice_message.placeholder": "This message will be displayed on the invoice.",
+  "invoice_form.terms_and_conditions.placeholder": "Enter the terms and conditions of your business to be displayed in your transaction.",
   "receipt_form.label.total": "TOTAL",
   "receipt_form.label.subtotal": "Subtotal",
   "receipt_form.label.due_amount": "Due amount",
   "receipt_form.label.payment_amount": "Payment amount",
   "receipt_form.label.receipt_message": "Receipt Message",
-  "receipt_form.receipt_message.placeholder": "Thanks for your business and have a great day!",
+  "receipt_form.receipt_message.placeholder": "This message will be displayed on the receipt.",
   "receipt_form.label.statement": "Statement",
   "receipt_form.statement.placeholder": "Thanks for your business and have a great day!",
-  "payment_receive_form.label.statement": "Statement",
-  "payment_receive_form.statement.placeholder": "Thanks for your business and have a great day!",
+
+  "payment_receive_form.label.internal_note": "Internal Note",
+  "payment_receive_form.internal_note.placeholder": "Internal notes, Not visible to the customer.",
+
+  "payment_receive_form.message.label": "Payment Message",
+  "payment_receive_form.message.placeholder": "This message will be displayed on the payment receipt.",
+
   "payment_receive_form.label.subtotal": "Subtotal",
   "payment_receive_form.label.total": "TOTAL",
+
   "bill_form.label.note": "Note",
-  "bill_form.label.note.placeholder": "Enter the terms and conditions of your business to be displayed in your transaction",
+  "bill_form.label.note.placeholder": "Internal note. Not visible to the vendor.",
   "bill_form.label.subtotal": "Subtotal",
   "bill_form.label.total": "TOTAL",
   "bill_form.label.due_amount": "Due amount",
   "bill_form.label.payment_amount": "Payment amount",
   "vendor_credit_form.label.note": "Note",
-  "vendor_credit_form.note.placeholder": "Enter the terms and conditions of your business to be displayed in your transaction",
+  "vendor_credit_form.note.placeholder": "Internal note. Not visible to the vendor.",
   "vendor_credit_form.label.subtotal": "Subtotal",
   "vendor_credit_form.label.total": "TOTAL",
   "payment_made_form.label.statement": "Statement",
   "payment_made_form.statement.placeholder": "Thanks for your business and have a great day!",
   "payment_made_form.label.subtotal": "Subtotal",
   "payment_made_form.label.total": "TOTAL",
+  "payment_made.form.internal_note.label": "Note",
+  "payment_made.form.internal_note.placeholder": "Internal note. Not visible to the vendor.",
   "make_journal.label.subtotal": "Subtotal",
   "make_journal.label.total": "TOTAL",
   "expense.label.subtotal": "Subtotal",
@@ -2002,6 +2011,10 @@
   "estimate.warehouse_button.label": "Warehouse: {label}",
   "receipt.branch_button.label": "Branch: {label}",
   "receipt.warehouse_button.label": "Warehouse: {label}",
-  "warehouse_transfer.empty_status.title": "",
-  "warehouse_transfer.empty_status.description": ""
+
+  "warehouse_transfer.empty_status.title": "Manage transfer orders between warehouses.",
+  "warehouse_transfer.empty_status.description": "Business with multiply warehouses often transfers items from on warehouse to another when they are in immediate need of vendors.",
+
+  "warehouse_transfer.form.reason.label": "Reason",
+  "warehouse_transfer.form.reason.placeholder": "Enter the reason behind the transfer order."
 }
\ No newline at end of file

From 10af33f1dca0a25b610c431ff8434b6a533def57 Mon Sep 17 00:00:00 2001
From: "a.bouhuolia" <a.bouhuolia@live.com>
Date: Mon, 28 Mar 2022 19:25:06 +0200
Subject: [PATCH 14/28] fix: `BIG-352` Add terms and conditions/notes field to
 a warehouse transfer.

---
 .../PaymentReceiveFormFootetLeft.js           |  2 +-
 .../ReceiptForm/ReceiptFormFooterLeft.js      | 18 +++++++------
 src/lang/en/index.json                        | 25 ++++++++++---------
 3 files changed, 24 insertions(+), 21 deletions(-)

diff --git a/src/containers/Sales/PaymentReceives/PaymentReceiveForm/PaymentReceiveFormFootetLeft.js b/src/containers/Sales/PaymentReceives/PaymentReceiveForm/PaymentReceiveFormFootetLeft.js
index 486883543..752ce4079 100644
--- a/src/containers/Sales/PaymentReceives/PaymentReceiveForm/PaymentReceiveFormFootetLeft.js
+++ b/src/containers/Sales/PaymentReceives/PaymentReceiveForm/PaymentReceiveFormFootetLeft.js
@@ -20,7 +20,7 @@ export function PaymentReceiveFormFootetLeft() {
       {/* --------- Internal Note--------- */}
       <TermsConditsFormGroup
         name={'internal_note'}
-        label={<T id={'payment_receive_form.label.internal_note'} />}
+        label={<T id={'payment_receive_form.label.note'} />}
       >
         <FEditableText
           name={'internal_note'}
diff --git a/src/containers/Sales/Receipts/ReceiptForm/ReceiptFormFooterLeft.js b/src/containers/Sales/Receipts/ReceiptForm/ReceiptFormFooterLeft.js
index 4429726d0..1e9b7e8f6 100644
--- a/src/containers/Sales/Receipts/ReceiptForm/ReceiptFormFooterLeft.js
+++ b/src/containers/Sales/Receipts/ReceiptForm/ReceiptFormFooterLeft.js
@@ -18,16 +18,18 @@ export function ReceiptFormFooterLeft() {
         />
       </ReceiptMsgFormGroup>
 
-      {/* --------- Statement--------- */}
-      <StatementFormGroup
-        label={<T id={'receipt_form.label.statement'} />}
-        name={'statement'}
+      {/* --------- Terms and conditions --------- */}
+      <TermsConditsFormGroup
+        label={<T id={'receipt_form.label.terms_conditions'} />}
+        name={'terms_conditions'}
       >
         <FEditableText
-          name={'statement'}
-          placeholder={intl.get('receipt_form.statement.placeholder')}
+          name={'terms_conditions'}
+          placeholder={intl.get(
+            'receipt_form.terms_and_conditions.placeholder',
+          )}
         />
-      </StatementFormGroup>
+      </TermsConditsFormGroup>
     </React.Fragment>
   );
 }
@@ -46,7 +48,7 @@ const ReceiptMsgFormGroup = styled(FFormGroup)`
   }
 `;
 
-const StatementFormGroup = styled(FFormGroup)`
+const TermsConditsFormGroup = styled(FFormGroup)`
   &.bp3-form-group {
     .bp3-label {
       font-size: 12px;
diff --git a/src/lang/en/index.json b/src/lang/en/index.json
index 43e936ab8..a14106e11 100644
--- a/src/lang/en/index.json
+++ b/src/lang/en/index.json
@@ -1164,7 +1164,7 @@
   "sorry_about_that_something_went_wrong": "Sorry about that! Something went wrong",
   "if_the_problem_stuck_please_contact_us_as_soon_as_possible": "If the problem stuck, please contact us as soon as possible.",
   "non-inventory": "Non-Inventory",
-  "terms_conditions": "Terms conditions",
+  "terms_conditions": "Terms & Conditions",
   "inventory_adjustment.publish.success_message": "The inventory adjustment has been published successfully.",
   "inventory_adjustment.publish.alert_message": "Are you sure you want to publish this inventory adjustment?",
   "the_contact_has_been_activated_successfully": "The contact has been inactivated successfully.",
@@ -1527,8 +1527,8 @@
   "credit_note.label_credit_note_details": "Credit Note details",
   "credit_note.label_customer_note": "Customer Note",
   "credit_note.label_terms_conditions": "Terms & Conditions",
-  "credit_note.label_customer_note.placeholder": "The customer note will be displayed on the credit note.",
-  "credit_note.label_terms_and_conditions.placeholder": "Enter the terms and conditions of your business to be displayed in your transaction",
+  "credit_note.label_customer_note.placeholder": "This message will be displayed on the credit note.",
+  "credit_note.label_terms_and_conditions.placeholder": "Enter the terms and conditions of your business to be displayed on the credit note.",
   "credit_note.label_total": "TOTAL",
   "credit_note.label_subtotal": "Subtotal",
   "credit_note.once_delete_this_credit_note": "Once you delete this credit note, you won't be able to restore it later. Are you sure you want to delete this credit note?",
@@ -1950,7 +1950,7 @@
   "estimate_form.label.customer_note": "Customer Note",
   "estimate_form.label.terms_conditions": "Terms & Conditions",
   "estimate_form.customer_note.placeholder": "This message will be displayed on the estimate.",
-  "estimate_form.terms_and_conditions.placeholder": "Enter the terms and conditions of your business to be displayed in your transaction",
+  "estimate_form.terms_and_conditions.placeholder": "Enter the terms and conditions of your business to be displayed on the estimate.",
   "invoice_form.label.total": "TOTAL",
   "invoice_form.label.subtotal": "Subtotal",
   "invoice_form.label.due_amount": "Due amount",
@@ -1958,18 +1958,19 @@
   "invoice_form.label.invoice_message": "Invoice Message",
   "invoice_form.label.terms_conditions": "Terms & Conditions",
   "invoice_form.invoice_message.placeholder": "This message will be displayed on the invoice.",
-  "invoice_form.terms_and_conditions.placeholder": "Enter the terms and conditions of your business to be displayed in your transaction.",
+  "invoice_form.terms_and_conditions.placeholder": "Enter the terms and conditions of your business to be displayed on the invoice.",
   "receipt_form.label.total": "TOTAL",
   "receipt_form.label.subtotal": "Subtotal",
   "receipt_form.label.due_amount": "Due amount",
   "receipt_form.label.payment_amount": "Payment amount",
   "receipt_form.label.receipt_message": "Receipt Message",
   "receipt_form.receipt_message.placeholder": "This message will be displayed on the receipt.",
-  "receipt_form.label.statement": "Statement",
-  "receipt_form.statement.placeholder": "Thanks for your business and have a great day!",
 
-  "payment_receive_form.label.internal_note": "Internal Note",
-  "payment_receive_form.internal_note.placeholder": "Internal notes, Not visible to the customer.",
+  "receipt_form.label.terms_conditions": "Terms & Conditions",
+  "receipt_form.terms_and_conditions.placeholder": "Enter the terms and conditions of your business to be displayed on the receipt.",
+
+  "payment_receive_form.label.note": "Note",
+  "payment_receive_form.internal_note.placeholder": "Internal notes (Not visible to the customer).",
 
   "payment_receive_form.message.label": "Payment Message",
   "payment_receive_form.message.placeholder": "This message will be displayed on the payment receipt.",
@@ -1978,13 +1979,13 @@
   "payment_receive_form.label.total": "TOTAL",
 
   "bill_form.label.note": "Note",
-  "bill_form.label.note.placeholder": "Internal note. Not visible to the vendor.",
+  "bill_form.label.note.placeholder": "Internal note (Not visible to the vendor).",
   "bill_form.label.subtotal": "Subtotal",
   "bill_form.label.total": "TOTAL",
   "bill_form.label.due_amount": "Due amount",
   "bill_form.label.payment_amount": "Payment amount",
   "vendor_credit_form.label.note": "Note",
-  "vendor_credit_form.note.placeholder": "Internal note. Not visible to the vendor.",
+  "vendor_credit_form.note.placeholder": "Internal note (Not visible to the vendor).",
   "vendor_credit_form.label.subtotal": "Subtotal",
   "vendor_credit_form.label.total": "TOTAL",
   "payment_made_form.label.statement": "Statement",
@@ -1992,7 +1993,7 @@
   "payment_made_form.label.subtotal": "Subtotal",
   "payment_made_form.label.total": "TOTAL",
   "payment_made.form.internal_note.label": "Note",
-  "payment_made.form.internal_note.placeholder": "Internal note. Not visible to the vendor.",
+  "payment_made.form.internal_note.placeholder": "Internal note (Not visible to the vendor).",
   "make_journal.label.subtotal": "Subtotal",
   "make_journal.label.total": "TOTAL",
   "expense.label.subtotal": "Subtotal",

From a9c2a5c5f0b63b52e8d0072bd8eb601b32d28f0a Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Mon, 28 Mar 2022 21:38:56 +0200
Subject: [PATCH 15/28] BIG-354: warehouse transfer validate.

---
 .../WarehouseTransferForm.js                  | 20 +++++++++++++++----
 src/lang/ar/index.json                        |  4 +++-
 src/lang/en/index.json                        | 16 +++------------
 3 files changed, 22 insertions(+), 18 deletions(-)

diff --git a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.js b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.js
index c61ce2b92..7a9f77a34 100644
--- a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.js
+++ b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.js
@@ -1,7 +1,7 @@
 import React from 'react';
 import intl from 'react-intl-universal';
 import { Formik, Form } from 'formik';
-import { isEmpty } from 'lodash';
+import { isEmpty, sumBy } from 'lodash';
 import { Intent } from '@blueprintjs/core';
 import { useHistory } from 'react-router-dom';
 import { CLASSES } from 'common/classes';
@@ -20,7 +20,7 @@ import WarehouseTransferFormDialog from './WarehouseTransferFormDialog';
 import withDashboardActions from 'containers/Dashboard/withDashboardActions';
 import withSettings from 'containers/Settings/withSettings';
 
-import { AppToaster, } from 'components';
+import { AppToaster } from 'components';
 import { useWarehouseTransferFormContext } from './WarehouseTransferFormProvider';
 import { compose, orderingLinesIndexes, transactionNumber } from 'utils';
 import { WarehouseTransferObserveItemsCost } from './components';
@@ -72,6 +72,18 @@ function WarehouseTransferForm({
   // Handles form submit.
   const handleSubmit = (values, { setSubmitting, setErrors, resetForm }) => {
     setSubmitting(true);
+    const totalQuantity = sumBy(values.entries, 'quantity');
+
+    if (totalQuantity <= 0) {
+      AppToaster.show({
+        message: intl.get(
+          'warehouse_transfer.quantity_cannot_be_zero_or_empty',
+        ),
+        intent: Intent.DANGER,
+      });
+      return;
+    }
+
     // Transformes the values of the form to request.
     const form = {
       ...transformValueToRequest(values),
@@ -119,7 +131,7 @@ function WarehouseTransferForm({
         .catch(onError);
     }
   };
-  
+
   return (
     <div
       className={classNames(
@@ -141,7 +153,7 @@ function WarehouseTransferForm({
           <WarehouseTransferFormFooter />
           <WarehouseTransferFormDialog />
           <WarehouseTransferFloatingActions />
-          <WarehouseTransferObserveItemsCost />          
+          <WarehouseTransferObserveItemsCost />
         </Form>
       </Formik>
     </div>
diff --git a/src/lang/ar/index.json b/src/lang/ar/index.json
index 48edb6793..cf6eb0632 100644
--- a/src/lang/ar/index.json
+++ b/src/lang/ar/index.json
@@ -2005,5 +2005,7 @@
   "receipt.warehouse_button.label": "المخزن: {label}",
   "warehouse_transfer.empty_status.title": "إدارة عمليات النقل بين المستودعات",
   "warehouse_transfer.empty_status.description": "غالبًا ماتحتاج الاعمال ذات مستودعات متعددة لطلبات نقل البضائع من مستودع إلى آخر عندما تكون في حاجة ماسة إلى البائعين.",
-  "item.error.you_could_not_delete_item_has_associated": "لا يمكنك حذف العنصر لديه معاملات مرتبطة به "
+  "item.error.you_could_not_delete_item_has_associated": "لا يمكنك حذف العنصر لديه معاملات مرتبطة به ",
+  "warehouse_transfer.quantity_cannot_be_zero_or_empty": "لا يمكن أن تكون الكمية صفراً أو فارغة."
+
 }
\ No newline at end of file
diff --git a/src/lang/en/index.json b/src/lang/en/index.json
index a14106e11..5911e4753 100644
--- a/src/lang/en/index.json
+++ b/src/lang/en/index.json
@@ -1440,7 +1440,7 @@
   "AP_aging_summary.filter_options.label": "Filter vendors",
   "item.error.type_cannot_change_with_item_has_transactions": "Cannot change item type to inventory with item has associated transactions.",
   "item.error.cannot_change_inventory_account": "Cannot change item inventory account while the item has transactions.",
-  "item.error.you_could_not_delete_item_has_associated":"You could not delete item that has associated transactions",
+  "item.error.you_could_not_delete_item_has_associated": "You could not delete item that has associated transactions",
   "customer.link.customer_details": "Customer details ({amount})",
   "bad_debt.dialog.written_off_amount": "Written-off amount",
   "bad_debt.dialog.bad_debt": "Bad debt",
@@ -1776,13 +1776,10 @@
   "profit_loss_sheet.percentage_of_row": "% of Row",
   "profit_loss_sheet.percentage_of_expense": "% of Expense",
   "profit_loss_sheet.percentage_of_income": "% of Income",
-  
   "report.balance_sheet_comparison.title": "Balance Sheet Comparison",
   "report.balance_sheet_comparison.desc": "Reports a company's assets, liabilities and shareholders' equity compared to previous year.",
-
   "report.profit_loss_sheet_comparison.title": "Profit/Loss Comparison",
   "report.profit_loss_sheet_comparison.desc": "Reports the revenues, costs and expenses incurred at a specific point and compared to previous year.",
-  
   "the_vendor_has_been_inactivated_successfully": "The contact has been inactivated successfully.",
   "vendor.alert.activated_message": "The vendor has been activated successfully.",
   "vendor.alert.are_you_sure_want_to_inactivate_this_vendor": "Are you sure want to inactivate this vendor? You will to able to activate it later.",
@@ -1794,7 +1791,6 @@
   "customer.alert.are_you_sure_want_to_inactivate_this_customer": "Are you sure want to inactivate this customer? You will to able to activate it later.",
   "credit_note_preview.dialog.title": "Credit Note PDF Preview",
   "payment_receive_preview.dialog.title": "Payment Receive PDF Preview",
-
   "warehouses.label": "Warehouses",
   "warehouses.label.new_warehouse": "New Warehouse",
   "warehouse.dialog.label.new_warehouse": "New Warehouse",
@@ -1965,19 +1961,14 @@
   "receipt_form.label.payment_amount": "Payment amount",
   "receipt_form.label.receipt_message": "Receipt Message",
   "receipt_form.receipt_message.placeholder": "This message will be displayed on the receipt.",
-
   "receipt_form.label.terms_conditions": "Terms & Conditions",
   "receipt_form.terms_and_conditions.placeholder": "Enter the terms and conditions of your business to be displayed on the receipt.",
-
   "payment_receive_form.label.note": "Note",
   "payment_receive_form.internal_note.placeholder": "Internal notes (Not visible to the customer).",
-
   "payment_receive_form.message.label": "Payment Message",
   "payment_receive_form.message.placeholder": "This message will be displayed on the payment receipt.",
-
   "payment_receive_form.label.subtotal": "Subtotal",
   "payment_receive_form.label.total": "TOTAL",
-
   "bill_form.label.note": "Note",
   "bill_form.label.note.placeholder": "Internal note (Not visible to the vendor).",
   "bill_form.label.subtotal": "Subtotal",
@@ -2012,10 +2003,9 @@
   "estimate.warehouse_button.label": "Warehouse: {label}",
   "receipt.branch_button.label": "Branch: {label}",
   "receipt.warehouse_button.label": "Warehouse: {label}",
-
   "warehouse_transfer.empty_status.title": "Manage transfer orders between warehouses.",
   "warehouse_transfer.empty_status.description": "Business with multiply warehouses often transfers items from on warehouse to another when they are in immediate need of vendors.",
-
   "warehouse_transfer.form.reason.label": "Reason",
-  "warehouse_transfer.form.reason.placeholder": "Enter the reason behind the transfer order."
+  "warehouse_transfer.form.reason.placeholder": "Enter the reason behind the transfer order.",
+  "warehouse_transfer.quantity_cannot_be_zero_or_empty": "Quantity cannot be zero or empty."
 }
\ No newline at end of file

From 3f4ffdc99569b372554e4d1207181e78a50328f2 Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Wed, 30 Mar 2022 15:04:55 +0200
Subject: [PATCH 16/28] BIG-237: Validate invoice due date.

---
 .../Sales/Invoices/InvoiceForm/InvoiceForm.schema.js  | 11 ++++++++++-
 src/lang/ar/index.json                                |  6 ++++--
 src/lang/en/index.json                                |  4 +++-
 3 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/src/containers/Sales/Invoices/InvoiceForm/InvoiceForm.schema.js b/src/containers/Sales/Invoices/InvoiceForm/InvoiceForm.schema.js
index eaedac85f..9d68c079a 100644
--- a/src/containers/Sales/Invoices/InvoiceForm/InvoiceForm.schema.js
+++ b/src/containers/Sales/Invoices/InvoiceForm/InvoiceForm.schema.js
@@ -1,4 +1,5 @@
 import * as Yup from 'yup';
+import moment from 'moment';
 import intl from 'react-intl-universal';
 import { DATATYPES_LENGTH } from 'common/dataTypes';
 import { isBlank } from 'utils';
@@ -7,7 +8,15 @@ const getSchema = () =>
   Yup.object().shape({
     customer_id: Yup.string().label(intl.get('customer_name_')).required(),
     invoice_date: Yup.date().required().label(intl.get('invoice_date_')),
-    due_date: Yup.date().required().label(intl.get('due_date_')),
+    due_date: Yup.date()
+      .min(Yup.ref('invoice_date'), ({ path, min }) =>
+        intl.get('invoice.validation.due_date', {
+          path,
+          min: moment(min).format('YYYY/MM/DD'),
+        }),
+      )
+      .required()
+      .label(intl.get('due_date_')),
     invoice_no: Yup.string()
       .max(DATATYPES_LENGTH.STRING)
       .label(intl.get('invoice_no_')),
diff --git a/src/lang/ar/index.json b/src/lang/ar/index.json
index cf6eb0632..b732b125b 100644
--- a/src/lang/ar/index.json
+++ b/src/lang/ar/index.json
@@ -1361,6 +1361,7 @@
   "item.field.sell_account.hint": "أدخل السعر الذي ستبيعه لهذا العنصر.",
   "item_entries.products_services.hint": "أدخل المنتجات أو الخدمات التي تبيعها أو تشتريها لتتبع ما قمت ببيعه أو شرائه.",
   "item_entries.landed.hint": "يتيح لك هذه الخيار إمكانية  إضافة تكلفة اضافية علي فاتورة الشراء متال علي ذلك تكاليف الشحن ، ثم تحديد هذه التكلفة لتحميلها علي فاتورة الشراء.",
+  "item_entries.remove_row": "حذف الصف",
   "invoice.auto_increment.auto": "يتم تعيين أرقام الفواتير على وضع الزيادة التلقائي. هل أنت متأكد من تغيير هذا الإعداد؟",
   "invoice.auto_increment.manually": "يتم تعيين أرقام فواتيرك يدوياً. هل أنت متأكد من تغيير هذه الإعدادات؟",
   "manual_journals.auto_increment.auto": "يتم تعيين أرقام القيود على وضع الزيادة التلقائي. هل أنت متأكد من تغيير هذا الإعداد؟",
@@ -1847,6 +1848,7 @@
   "warehouse_transfer.column.transfer_quantity": "الكمية ",
   "warehouse_transfer.column.source_warehouse": "المصدر",
   "warehouse_transfer.column.destination_warehouse": "الوجهة",
+  "warehouse_transfer.column.cost_price": "سعر التكلفة",
   "warehouse_transfer.auto_increment.auto": "يتم تعيين أرقام النقل على وضع الزيادة التلقائي. هل أنت متأكد من تغيير هذا الإعداد؟",
   "warehouse_transfer.auto_increment.manually": "يتم تعيين أرقام النقل يدوياً. هل أنت متأكد من تغيير هذه الإعدادات؟",
   "warehouse_transfer.setting_your_auto_generated_transfer_no": "تعيين رقم النقل الذي تم إنشاؤه تلقائيًا",
@@ -2006,6 +2008,6 @@
   "warehouse_transfer.empty_status.title": "إدارة عمليات النقل بين المستودعات",
   "warehouse_transfer.empty_status.description": "غالبًا ماتحتاج الاعمال ذات مستودعات متعددة لطلبات نقل البضائع من مستودع إلى آخر عندما تكون في حاجة ماسة إلى البائعين.",
   "item.error.you_could_not_delete_item_has_associated": "لا يمكنك حذف العنصر لديه معاملات مرتبطة به ",
-  "warehouse_transfer.quantity_cannot_be_zero_or_empty": "لا يمكن أن تكون الكمية صفراً أو فارغة."
-
+  "warehouse_transfer.quantity_cannot_be_zero_or_empty": "لا يمكن أن تكون الكمية صفراً أو فارغة.",
+  "invoice.validation.due_date": "يجب أن يكون حقل {path} في وقت لاحق من {min}"
 }
\ No newline at end of file
diff --git a/src/lang/en/index.json b/src/lang/en/index.json
index 5911e4753..9d46f4090 100644
--- a/src/lang/en/index.json
+++ b/src/lang/en/index.json
@@ -1338,6 +1338,7 @@
   "item.field.sell_account.hint": "Enter price which you goint to sell this item.",
   "item_entries.products_services.hint": "Enter products or services you sell or buy to keep tracking what your sold or purchased.",
   "item_entries.landed.hint": "This options allows you to be able to add additional cost eg. freight then allocate cost to the items in your bills.",
+  "item_entries.remove_row": "Remove line",
   "invoice.auto_increment.auto": "Your invoice numbers are set on auto-increment mode. Are you sure changing this setting?",
   "invoice.auto_increment.manually": "Your invoice numbers are set on manual mode. Are you sure chaning this settings?",
   "manual_journals.auto_increment.auto": "Your Jouranl numbers are set on auto-increment mode. Are you sure changing this setting?",
@@ -2007,5 +2008,6 @@
   "warehouse_transfer.empty_status.description": "Business with multiply warehouses often transfers items from on warehouse to another when they are in immediate need of vendors.",
   "warehouse_transfer.form.reason.label": "Reason",
   "warehouse_transfer.form.reason.placeholder": "Enter the reason behind the transfer order.",
-  "warehouse_transfer.quantity_cannot_be_zero_or_empty": "Quantity cannot be zero or empty."
+  "warehouse_transfer.quantity_cannot_be_zero_or_empty": "Quantity cannot be zero or empty.",
+  "invoice.validation.due_date": "{path} field must be later than {min}"
 }
\ No newline at end of file

From 373a695c4cf1af71bb4676a4adef525ac8cdcfc3 Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Wed, 30 Mar 2022 15:06:58 +0200
Subject: [PATCH 17/28] BIG-236: Validate estimate expiration date.

---
 .../Estimates/EstimateForm/EstimateForm.schema.js | 15 +++++++++------
 src/lang/ar/index.json                            |  3 ++-
 src/lang/en/index.json                            |  3 ++-
 3 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/src/containers/Sales/Estimates/EstimateForm/EstimateForm.schema.js b/src/containers/Sales/Estimates/EstimateForm/EstimateForm.schema.js
index 46bd23f5f..78cc4139d 100644
--- a/src/containers/Sales/Estimates/EstimateForm/EstimateForm.schema.js
+++ b/src/containers/Sales/Estimates/EstimateForm/EstimateForm.schema.js
@@ -2,16 +2,19 @@ import * as Yup from 'yup';
 import intl from 'react-intl-universal';
 import { DATATYPES_LENGTH } from 'common/dataTypes';
 import { isBlank } from 'utils';
+import moment from 'moment';
 
 const Schema = Yup.object().shape({
-  customer_id: Yup.number()
-    .label(intl.get('customer_name_'))
-    .required(),
-  estimate_date: Yup.date()
-    .required()
-    .label(intl.get('estimate_date_')),
+  customer_id: Yup.number().label(intl.get('customer_name_')).required(),
+  estimate_date: Yup.date().required().label(intl.get('estimate_date_')),
   expiration_date: Yup.date()
     .required()
+    .min(Yup.ref('estimate_date'), ({ path, min }) =>
+      intl.get('estimate.validation.expiration_date', {
+        path,
+        min: moment(min).format('YYYY/MM/DD'),
+      }),
+    )
     .label(intl.get('expiration_date_')),
   estimate_number: Yup.string()
     .max(DATATYPES_LENGTH.STRING)
diff --git a/src/lang/ar/index.json b/src/lang/ar/index.json
index b732b125b..944d6ea7a 100644
--- a/src/lang/ar/index.json
+++ b/src/lang/ar/index.json
@@ -2009,5 +2009,6 @@
   "warehouse_transfer.empty_status.description": "غالبًا ماتحتاج الاعمال ذات مستودعات متعددة لطلبات نقل البضائع من مستودع إلى آخر عندما تكون في حاجة ماسة إلى البائعين.",
   "item.error.you_could_not_delete_item_has_associated": "لا يمكنك حذف العنصر لديه معاملات مرتبطة به ",
   "warehouse_transfer.quantity_cannot_be_zero_or_empty": "لا يمكن أن تكون الكمية صفراً أو فارغة.",
-  "invoice.validation.due_date": "يجب أن يكون حقل {path} في وقت لاحق من {min}"
+  "invoice.validation.due_date": "يجب أن يكون حقل {path} في وقت لاحق من {min}",
+  "estimate.validation.expiration_date": "يجب أن يكون حقل {path} في وقت لاحق من {min}"
 }
\ No newline at end of file
diff --git a/src/lang/en/index.json b/src/lang/en/index.json
index 9d46f4090..2a4d0b094 100644
--- a/src/lang/en/index.json
+++ b/src/lang/en/index.json
@@ -2009,5 +2009,6 @@
   "warehouse_transfer.form.reason.label": "Reason",
   "warehouse_transfer.form.reason.placeholder": "Enter the reason behind the transfer order.",
   "warehouse_transfer.quantity_cannot_be_zero_or_empty": "Quantity cannot be zero or empty.",
-  "invoice.validation.due_date": "{path} field must be later than {min}"
+  "invoice.validation.due_date": "{path} field must be later than {min}",
+  "estimate.validation.expiration_date": "{path} field must be later than {min}"
 }
\ No newline at end of file

From ce674466fedf8f2f9fa46012ae282963b46cbf62 Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Wed, 30 Mar 2022 15:09:11 +0200
Subject: [PATCH 18/28] BIG-238: Validate bill due date.

---
 .../Purchases/Bills/BillForm/BillForm.schema.js | 17 ++++++++++-------
 src/lang/ar/index.json                          |  3 ++-
 src/lang/en/index.json                          |  3 ++-
 3 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/src/containers/Purchases/Bills/BillForm/BillForm.schema.js b/src/containers/Purchases/Bills/BillForm/BillForm.schema.js
index 6f77262b2..258ad5be4 100644
--- a/src/containers/Purchases/Bills/BillForm/BillForm.schema.js
+++ b/src/containers/Purchases/Bills/BillForm/BillForm.schema.js
@@ -1,16 +1,19 @@
 import * as Yup from 'yup';
+import moment from 'moment';
 import intl from 'react-intl-universal';
 import { DATATYPES_LENGTH } from 'common/dataTypes';
 import { isBlank } from 'utils';
 
 const BillFormSchema = Yup.object().shape({
-  vendor_id: Yup.number()
-    .required()
-    .label(intl.get('vendor_name_')),
-  bill_date: Yup.date()
-    .required()
-    .label(intl.get('bill_date_')),
+  vendor_id: Yup.number().required().label(intl.get('vendor_name_')),
+  bill_date: Yup.date().required().label(intl.get('bill_date_')),
   due_date: Yup.date()
+    .min(Yup.ref('bill_date'), ({ path, min }) =>
+      intl.get('bill.validation.due_date', {
+        path,
+        min: moment(min).format('YYYY/MM/DD'),
+      }),
+    )
     .required()
     .label(intl.get('due_date_')),
   bill_number: Yup.string()
@@ -25,7 +28,7 @@ const BillFormSchema = Yup.object().shape({
   open: Yup.boolean(),
   branch_id: Yup.string(),
   warehouse_id: Yup.string(),
-  exchange_rate:Yup.number(),
+  exchange_rate: Yup.number(),
   entries: Yup.array().of(
     Yup.object().shape({
       quantity: Yup.number()
diff --git a/src/lang/ar/index.json b/src/lang/ar/index.json
index 944d6ea7a..ca3cb74aa 100644
--- a/src/lang/ar/index.json
+++ b/src/lang/ar/index.json
@@ -2010,5 +2010,6 @@
   "item.error.you_could_not_delete_item_has_associated": "لا يمكنك حذف العنصر لديه معاملات مرتبطة به ",
   "warehouse_transfer.quantity_cannot_be_zero_or_empty": "لا يمكن أن تكون الكمية صفراً أو فارغة.",
   "invoice.validation.due_date": "يجب أن يكون حقل {path} في وقت لاحق من {min}",
-  "estimate.validation.expiration_date": "يجب أن يكون حقل {path} في وقت لاحق من {min}"
+  "estimate.validation.expiration_date": "يجب أن يكون حقل {path} في وقت لاحق من {min}",
+  "bill.validation.due_date": "يجب أن يكون حقل {path} في وقت لاحق من {min}" 
 }
\ No newline at end of file
diff --git a/src/lang/en/index.json b/src/lang/en/index.json
index 2a4d0b094..7c10a8e5b 100644
--- a/src/lang/en/index.json
+++ b/src/lang/en/index.json
@@ -2010,5 +2010,6 @@
   "warehouse_transfer.form.reason.placeholder": "Enter the reason behind the transfer order.",
   "warehouse_transfer.quantity_cannot_be_zero_or_empty": "Quantity cannot be zero or empty.",
   "invoice.validation.due_date": "{path} field must be later than {min}",
-  "estimate.validation.expiration_date": "{path} field must be later than {min}"
+  "estimate.validation.expiration_date": "{path} field must be later than {min}",
+  "bill.validation.due_date": "{path} field must be later than {min}"
 }
\ No newline at end of file

From 30b17d697f55fb236ef3f058162e17214a417e24 Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Wed, 30 Mar 2022 16:28:42 +0200
Subject: [PATCH 19/28] BIG-355: remove expandable  in item categories.

---
 src/containers/ItemsCategories/ItemCategoriesTable.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/containers/ItemsCategories/ItemCategoriesTable.js b/src/containers/ItemsCategories/ItemCategoriesTable.js
index 5f2436e91..654500e24 100644
--- a/src/containers/ItemsCategories/ItemCategoriesTable.js
+++ b/src/containers/ItemsCategories/ItemCategoriesTable.js
@@ -50,7 +50,7 @@ function ItemsCategoryTable({
       loading={isCategoriesLoading}
       headerLoading={isCategoriesLoading}
       progressBarLoading={isCategoriesFetching}
-      expandable={true}
+      // expandable={false}
       sticky={true}
       selectionColumn={true}
       TableLoadingRenderer={TableSkeletonRows}

From 9bd13b0d4691e5967d64277cf3077c5c92ae1580 Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Wed, 30 Mar 2022 16:31:34 +0200
Subject: [PATCH 20/28] BIG-355: remove expandable  in item categories.

---
 src/containers/ItemsCategories/ItemCategoriesTable.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/containers/ItemsCategories/ItemCategoriesTable.js b/src/containers/ItemsCategories/ItemCategoriesTable.js
index 654500e24..305865f45 100644
--- a/src/containers/ItemsCategories/ItemCategoriesTable.js
+++ b/src/containers/ItemsCategories/ItemCategoriesTable.js
@@ -50,7 +50,7 @@ function ItemsCategoryTable({
       loading={isCategoriesLoading}
       headerLoading={isCategoriesLoading}
       progressBarLoading={isCategoriesFetching}
-      // expandable={false}
+      expandable={false}
       sticky={true}
       selectionColumn={true}
       TableLoadingRenderer={TableSkeletonRows}

From 86c6de361bf3899edfea696fa010bbecb14746b3 Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Wed, 30 Mar 2022 16:34:51 +0200
Subject: [PATCH 21/28] BIG-356: add localize remove line entries.

---
 src/containers/Accounting/MakeJournal/components.js | 12 ++++++++++--
 src/containers/Entries/components.js                |  2 +-
 src/containers/Expenses/ExpenseForm/components.js   |  7 +++++--
 src/containers/WarehouseTransfers/utils.js          |  5 ++++-
 src/lang/ar/index.json                              |  5 ++++-
 src/lang/en/index.json                              |  5 ++++-
 6 files changed, 28 insertions(+), 8 deletions(-)

diff --git a/src/containers/Accounting/MakeJournal/components.js b/src/containers/Accounting/MakeJournal/components.js
index cec39f28c..260adddd4 100644
--- a/src/containers/Accounting/MakeJournal/components.js
+++ b/src/containers/Accounting/MakeJournal/components.js
@@ -4,7 +4,12 @@ import { Popover2 } from '@blueprintjs/popover2';
 import { useFormikContext } from 'formik';
 import intl from 'react-intl-universal';
 
-import { ExchangeRateInputGroup, Icon, Hint, FormattedMessage as T } from 'components';
+import {
+  ExchangeRateInputGroup,
+  Icon,
+  Hint,
+  FormattedMessage as T,
+} from 'components';
 import {
   AccountsListFieldCell,
   MoneyFieldCell,
@@ -63,7 +68,10 @@ export const ActionsCellRenderer = ({
   };
   const exampleMenu = (
     <Menu>
-      <MenuItem onClick={handleClickRemoveRole} text="Remove line" />
+      <MenuItem
+        onClick={handleClickRemoveRole}
+        text={intl.get('make_journal.entries.remove_row')}
+      />
     </Menu>
   );
   return (
diff --git a/src/containers/Entries/components.js b/src/containers/Entries/components.js
index bb0bc53a2..d7877cd1b 100644
--- a/src/containers/Entries/components.js
+++ b/src/containers/Entries/components.js
@@ -43,7 +43,7 @@ export function ActionsCellRenderer({
 
   const exampleMenu = (
     <Menu>
-      <MenuItem onClick={onRemoveRole} text="Remove line" />
+      <MenuItem onClick={onRemoveRole} text={'item_entries.remove_row'} />
     </Menu>
   );
 
diff --git a/src/containers/Expenses/ExpenseForm/components.js b/src/containers/Expenses/ExpenseForm/components.js
index 417d81506..c0426d9a3 100644
--- a/src/containers/Expenses/ExpenseForm/components.js
+++ b/src/containers/Expenses/ExpenseForm/components.js
@@ -48,7 +48,10 @@ const ActionsCellRenderer = ({
   };
   const exampleMenu = (
     <Menu>
-      <MenuItem onClick={handleClickRemoveRole} text="Remove line" />
+      <MenuItem
+        onClick={handleClickRemoveRole}
+        text={intl.get('expense.entries.remove_row')}
+      />
     </Menu>
   );
   return (
@@ -163,4 +166,4 @@ export function ExpensesExchangeRateInputField({ ...props }) {
     />
   );
 }
-ExpensesExchangeRateInputField.cellType = CellType.Field;
\ No newline at end of file
+ExpensesExchangeRateInputField.cellType = CellType.Field;
diff --git a/src/containers/WarehouseTransfers/utils.js b/src/containers/WarehouseTransfers/utils.js
index cc118fdd7..638a55a22 100644
--- a/src/containers/WarehouseTransfers/utils.js
+++ b/src/containers/WarehouseTransfers/utils.js
@@ -21,7 +21,10 @@ export function ActionsCellRenderer({
 
   const exampleMenu = (
     <Menu>
-      <MenuItem onClick={onRemoveRole} text="Remove line" />
+      <MenuItem
+        onClick={onRemoveRole}
+        text={intl.get('warehouse_transfer.entries.remove_row')}
+      />
     </Menu>
   );
 
diff --git a/src/lang/ar/index.json b/src/lang/ar/index.json
index 944d6ea7a..9d09a3bff 100644
--- a/src/lang/ar/index.json
+++ b/src/lang/ar/index.json
@@ -2010,5 +2010,8 @@
   "item.error.you_could_not_delete_item_has_associated": "لا يمكنك حذف العنصر لديه معاملات مرتبطة به ",
   "warehouse_transfer.quantity_cannot_be_zero_or_empty": "لا يمكن أن تكون الكمية صفراً أو فارغة.",
   "invoice.validation.due_date": "يجب أن يكون حقل {path} في وقت لاحق من {min}",
-  "estimate.validation.expiration_date": "يجب أن يكون حقل {path} في وقت لاحق من {min}"
+  "estimate.validation.expiration_date": "يجب أن يكون حقل {path} في وقت لاحق من {min}",
+  "make_journal.entries.remove_row": "حذف الصف",
+  "expense.entries.remove_row": "حذف الصف",
+  "warehouse_transfer.entries.remove_row": "حذف الصف"
 }
\ No newline at end of file
diff --git a/src/lang/en/index.json b/src/lang/en/index.json
index 2a4d0b094..dbd9b1e32 100644
--- a/src/lang/en/index.json
+++ b/src/lang/en/index.json
@@ -2010,5 +2010,8 @@
   "warehouse_transfer.form.reason.placeholder": "Enter the reason behind the transfer order.",
   "warehouse_transfer.quantity_cannot_be_zero_or_empty": "Quantity cannot be zero or empty.",
   "invoice.validation.due_date": "{path} field must be later than {min}",
-  "estimate.validation.expiration_date": "{path} field must be later than {min}"
+  "estimate.validation.expiration_date": "{path} field must be later than {min}",
+  "make_journal.entries.remove_row": "Remove line",
+  "expense.entries.remove_row": "Remove line",
+  "warehouse_transfer.entries.remove_row": "Remove line"
 }
\ No newline at end of file

From 2db32b8ee85769da6d92a92fe58e8b39f307c646 Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Wed, 30 Mar 2022 17:17:23 +0200
Subject: [PATCH 22/28] BIG-141: add inactive status to item details.

---
 .../ItemDetailDrawerProvider.js               |  6 ++++-
 .../Drawers/ItemDetailDrawer/utlis.js         | 27 +++++++++++++++++++
 src/lang/ar/index.json                        |  3 ++-
 src/lang/en/index.json                        |  3 ++-
 4 files changed, 36 insertions(+), 3 deletions(-)
 create mode 100644 src/containers/Drawers/ItemDetailDrawer/utlis.js

diff --git a/src/containers/Drawers/ItemDetailDrawer/ItemDetailDrawerProvider.js b/src/containers/Drawers/ItemDetailDrawer/ItemDetailDrawerProvider.js
index c748e559b..fa811cf1d 100644
--- a/src/containers/Drawers/ItemDetailDrawer/ItemDetailDrawerProvider.js
+++ b/src/containers/Drawers/ItemDetailDrawer/ItemDetailDrawerProvider.js
@@ -1,6 +1,7 @@
 import React from 'react';
 import { DrawerHeaderContent, DrawerLoading } from 'components';
 import { useItem } from 'hooks/query';
+import { inactiveStatus } from './utlis';
 
 const ItemDetailDrawerContext = React.createContext();
 
@@ -27,7 +28,10 @@ function ItemDetailDrawerProvider({ itemId, ...props }) {
 
   return (
     <DrawerLoading loading={isItemLoading}>
-      <DrawerHeaderContent name="item-detail-drawer" title={item?.name} />
+      <DrawerHeaderContent
+        name="item-detail-drawer"
+        title={inactiveStatus(item)}
+      />
       <ItemDetailDrawerContext.Provider value={provider} {...props} />
     </DrawerLoading>
   );
diff --git a/src/containers/Drawers/ItemDetailDrawer/utlis.js b/src/containers/Drawers/ItemDetailDrawer/utlis.js
new file mode 100644
index 000000000..72b46fe3d
--- /dev/null
+++ b/src/containers/Drawers/ItemDetailDrawer/utlis.js
@@ -0,0 +1,27 @@
+import React from 'react';
+import styled from 'styled-components';
+import { Intent, Tag } from '@blueprintjs/core';
+import { Choose, FormattedMessage as T } from '../../../components';
+
+/**
+ * items inactive status.
+ * @returns {React.JSX}
+ */
+export function inactiveStatus(item) {
+  return (
+    <Choose>
+      <Choose.When condition={!item.active}>
+        {item.name}
+        <StatusTag intent={Intent.NONE} minimal={true} round={true}>
+          <T id={'item.details.inactive'} />
+        </StatusTag>
+      </Choose.When>
+      <Choose.Otherwise>{item.name}</Choose.Otherwise>
+    </Choose>
+  );
+}
+
+const StatusTag = styled(Tag)`
+  font-size: 11px;
+  margin-left: 10px;
+`;
diff --git a/src/lang/ar/index.json b/src/lang/ar/index.json
index 9d09a3bff..2e870609f 100644
--- a/src/lang/ar/index.json
+++ b/src/lang/ar/index.json
@@ -2013,5 +2013,6 @@
   "estimate.validation.expiration_date": "يجب أن يكون حقل {path} في وقت لاحق من {min}",
   "make_journal.entries.remove_row": "حذف الصف",
   "expense.entries.remove_row": "حذف الصف",
-  "warehouse_transfer.entries.remove_row": "حذف الصف"
+  "warehouse_transfer.entries.remove_row": "حذف الصف",
+  "item.details.inactive": "غير نشط"
 }
\ No newline at end of file
diff --git a/src/lang/en/index.json b/src/lang/en/index.json
index dbd9b1e32..664036468 100644
--- a/src/lang/en/index.json
+++ b/src/lang/en/index.json
@@ -2013,5 +2013,6 @@
   "estimate.validation.expiration_date": "{path} field must be later than {min}",
   "make_journal.entries.remove_row": "Remove line",
   "expense.entries.remove_row": "Remove line",
-  "warehouse_transfer.entries.remove_row": "Remove line"
+  "warehouse_transfer.entries.remove_row": "Remove line",
+  "item.details.inactive": "Inactive"
 }
\ No newline at end of file

From b849bfaa951788d9d72a33975d440eea8e30c9dc Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Thu, 31 Mar 2022 13:39:15 +0200
Subject: [PATCH 23/28] BIG-344: add branch to manual journal & expense.

---
 .../ExpenseDrawer/ExpenseDrawerProvider.js    | 19 ++++++++++++++++-
 src/containers/Drawers/ExpenseDrawer/index.js |  3 ---
 .../Drawers/ManualJournalDrawer/utils.js      | 21 ++++++++++++++++---
 src/lang/ar/index.json                        |  6 ++++--
 src/lang/en/index.json                        |  1 +
 5 files changed, 41 insertions(+), 9 deletions(-)

diff --git a/src/containers/Drawers/ExpenseDrawer/ExpenseDrawerProvider.js b/src/containers/Drawers/ExpenseDrawer/ExpenseDrawerProvider.js
index 90e4b87a1..f5da42cc8 100644
--- a/src/containers/Drawers/ExpenseDrawer/ExpenseDrawerProvider.js
+++ b/src/containers/Drawers/ExpenseDrawer/ExpenseDrawerProvider.js
@@ -1,6 +1,9 @@
 import React from 'react';
+import intl from 'react-intl-universal';
 import { useExpense } from 'hooks/query';
-import { DrawerLoading } from 'components';
+import { DrawerHeaderContent, DrawerLoading } from 'components';
+import { Features } from 'common';
+import { useFeatureCan } from 'hooks/state';
 
 const ExpenseDrawerDrawerContext = React.createContext();
 
@@ -8,6 +11,9 @@ const ExpenseDrawerDrawerContext = React.createContext();
  * Expense drawer provider.
  */
 function ExpenseDrawerProvider({ expenseId, ...props }) {
+  // Features guard.
+  const { featureCan } = useFeatureCan();
+
   // Fetch the expense details.
   const {
     data: expense,
@@ -28,6 +34,17 @@ function ExpenseDrawerProvider({ expenseId, ...props }) {
 
   return (
     <DrawerLoading loading={isExpenseLoading}>
+      <DrawerHeaderContent
+        name="expense-drawer"
+        title={intl.get('expense.drawer.title')}
+        subTitle={
+          featureCan(Features.Branches)
+            ? intl.get('expense.drawer.subtitle', {
+                value: expense.branch?.name,
+              })
+            : null
+        }
+      />
       <ExpenseDrawerDrawerContext.Provider value={provider} {...props} />
     </DrawerLoading>
   );
diff --git a/src/containers/Drawers/ExpenseDrawer/index.js b/src/containers/Drawers/ExpenseDrawer/index.js
index cb3c56f66..92ad685b6 100644
--- a/src/containers/Drawers/ExpenseDrawer/index.js
+++ b/src/containers/Drawers/ExpenseDrawer/index.js
@@ -1,6 +1,4 @@
 import React, { lazy } from 'react';
-import intl from 'react-intl-universal';
-
 import { Drawer, DrawerSuspense } from 'components';
 import withDrawers from 'containers/Drawer/withDrawers';
 
@@ -22,7 +20,6 @@ function ExpenseDrawer({
     <Drawer
       isOpen={isOpen}
       name={name}
-      title={intl.get('expense.drawer.title')}
       size={'65%'}
       style={{ minWidth: '700px', maxWidth: '900px' }}
     >
diff --git a/src/containers/Drawers/ManualJournalDrawer/utils.js b/src/containers/Drawers/ManualJournalDrawer/utils.js
index 944c4f784..31e38ccf0 100644
--- a/src/containers/Drawers/ManualJournalDrawer/utils.js
+++ b/src/containers/Drawers/ManualJournalDrawer/utils.js
@@ -3,6 +3,8 @@ import React from 'react';
 import { Tag, Intent, Classes, Tooltip, Position } from '@blueprintjs/core';
 
 import { T, Choose, FormatNumberCell, If, Icon } from '../../../components';
+import { Features } from 'common';
+import { useFeatureCan } from 'hooks/state';
 
 /**
  * Note column accessor.
@@ -46,8 +48,9 @@ export function ManualJournalDetailsStatus({ manualJournal }) {
 /**
  * Retrieve read-only manual journal entries columns.
  */
-export const useManualJournalEntriesColumns = () =>
-  React.useMemo(
+export const useManualJournalEntriesColumns = () => {
+  const { featureCan } = useFeatureCan();
+  return React.useMemo(
     () => [
       {
         Header: intl.get('account_name'),
@@ -70,6 +73,17 @@ export const useManualJournalEntriesColumns = () =>
         disableSortBy: true,
         className: 'note',
       },
+      ...(featureCan(Features.Branches)
+        ? [
+            {
+              Header: intl.get('branch'),
+              width: 130,
+              accessor: 'branch.name',
+              disableSortBy: true,
+              className: 'branch',
+            },
+          ]
+        : []),
       {
         Header: intl.get('credit'),
         accessor: 'credit',
@@ -93,5 +107,6 @@ export const useManualJournalEntriesColumns = () =>
         align: 'right',
       },
     ],
-    [],
+    [featureCan],
   );
+};
diff --git a/src/lang/ar/index.json b/src/lang/ar/index.json
index cfb865514..9e069b70f 100644
--- a/src/lang/ar/index.json
+++ b/src/lang/ar/index.json
@@ -2005,8 +2005,10 @@
   "estimate.warehouse_button.label": "المخزن: {label}",
   "receipt.branch_button.label": "الفرع: {label}",
   "receipt.warehouse_button.label": "المخزن: {label}",
-  "warehouse_transfer.empty_status.title": "إدارة عمليات النقل بين المستودعات",
-  "warehouse_transfer.empty_status.description": "غالبًا ماتحتاج الاعمال ذات مستودعات متعددة لطلبات نقل البضائع من مستودع إلى آخر عندما تكون في حاجة ماسة إلى البائعين.",
+  "warehouse_transfer.empty_status.title": "إدارة عمليات النقل بين المخازن",
+  "warehouse_transfer.empty_status.description": "غالبًا ماتحتاج الاعمال ذات مخازن متعددة لطلبات نقل البضائع من مخزن إلى آخر عندما تكون في حاجة ماسة إلى البائعين.",
+  "warehouse_transfer.form.reason.label": "أسباب النقل",
+  "warehouse_transfer.form.reason.placeholder": "Enter the reason behind the transfer order.",
   "item.error.you_could_not_delete_item_has_associated": "لا يمكنك حذف العنصر لديه معاملات مرتبطة به ",
   "warehouse_transfer.quantity_cannot_be_zero_or_empty": "لا يمكن أن تكون الكمية صفراً أو فارغة.",
   "invoice.validation.due_date": "يجب أن يكون حقل {path} في وقت لاحق من {min}",
diff --git a/src/lang/en/index.json b/src/lang/en/index.json
index 850a6313d..eb8483918 100644
--- a/src/lang/en/index.json
+++ b/src/lang/en/index.json
@@ -1756,6 +1756,7 @@
   "payment_made.drawer.subtitle": "Branch: {value}",
   "manual_journal.drawer.title": "Manual journal details ({number})",
   "expense.drawer.title": "Expense details",
+  "expense.drawer.subtitle": "Branch: {value}",
   "global_error.you_dont_have_permissions": "You do not have permissions to access this page.",
   "global_error.transactions_locked": "Transactions before {lockedToDate} has been locked. Hence action cannot be performed.",
   "global_error.authorized_user_inactive": "The authorized user is inactive.",

From 872b98fb0dc37a95922183db2e977416faa651c3 Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Thu, 31 Mar 2022 13:57:07 +0200
Subject: [PATCH 24/28] BIG-278: add created_at in expense details.

---
 .../Drawers/ExpenseDrawer/ExpenseDrawerHeader.js           | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/containers/Drawers/ExpenseDrawer/ExpenseDrawerHeader.js b/src/containers/Drawers/ExpenseDrawer/ExpenseDrawerHeader.js
index 816970709..f8187b2a5 100644
--- a/src/containers/Drawers/ExpenseDrawer/ExpenseDrawerHeader.js
+++ b/src/containers/Drawers/ExpenseDrawer/ExpenseDrawerHeader.js
@@ -10,6 +10,7 @@ import {
   Col,
   DetailItem,
   DetailsMenu,
+  FormatDate,
   ExchangeRateDetailItem,
   FormattedMessage as T,
 } from 'components';
@@ -64,10 +65,12 @@ export default function ExpenseDrawerHeader() {
             minLabelSize={'180px'}
           >
             <DetailItem label={<T id={'published_at'} />}>
-              {moment(expense.published_at).format('YYYY MMM DD')}
+              <FormatDate value={expense.published_at} />
             </DetailItem>
 
-            <DetailItem label={<T id={'created_at'} />}>2021 Aug 24</DetailItem>
+            <DetailItem label={<T id={'created_at'} />}>
+              <FormatDate value={expense.created_at} />
+            </DetailItem>
           </DetailsMenu>
         </Col>
       </Row>

From b903aa3eb2d577447ac41c80eec0c04fdb8c3e0c Mon Sep 17 00:00:00 2001
From: "a.bouhuolia" <a.bouhuolia@live.com>
Date: Thu, 31 Mar 2022 14:07:17 +0200
Subject: [PATCH 25/28] dump v1.7.2 version with changelogs.

---
 CHANGELOG.md | 20 ++++++++++++++++++++
 package.json |  2 +-
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ab70adcb0..4bb04704e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,26 @@
 
 All notable changes to Bigcapital server-side will be in this file.
 
+## [1.7.1-rc.2] - 30-03-2022
+
+## Added
+  - `BIG-141` Add inactive status to item drawer details.
+  - `BIG-278` Add created at date on expense details.
+  - `BIG-350` Add empty status content of warehouse transfers service.
+## Fixed
+  - `BIG-221` Remove Non-inventory radio choice on item form.
+  - `BIG-236` Validate estimate expiration date should be equal or bigger than estimate date.
+  - `BIG-237` Validate invoice due date should be equal or bigger than invoice date.
+  - `BIG-238` Validate bill due date should be equal or bigger than bill date.
+  - `BIG-280` Optimize style of multi-select accounts menu.
+  - `BIG-284` Cashflow statement loading bar.
+  - `BIG-296` Creating a new child account from accounts list.
+  - `BIG-301` Navigation bar divider on actions bar hide with permissions control.
+  - `BIG-304` Adding cash or bank account from cash flow service.
+  - `BIG-351` Invalid date in the inventory adjustment detail.
+  - `BIG-352` Fix terms and notes fields on footer of all services.
+  - `BIG-354` Validate the warehouse transfer quantity should be above zero.
+
 ## [1.7.0-rc.1] - 24-03-2022
 
 ## Added 
diff --git a/package.json b/package.json
index d4a827375..cf7f8a161 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "bigcapital-client",
-  "version": "1.6.3",
+  "version": "1.7.1",
   "private": true,
   "dependencies": {
     "@babel/core": "7.8.4",

From 41d2fc63cb0f8d0040f09a7eeff40b19e4abe6b6 Mon Sep 17 00:00:00 2001
From: "a.bouhuolia" <a.bouhuolia@live.com>
Date: Thu, 31 Mar 2022 14:08:22 +0200
Subject: [PATCH 26/28] chore(Changelog): add the missing logs.

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4bb04704e..8b1592013 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,7 @@ All notable changes to Bigcapital server-side will be in this file.
   - `BIG-141` Add inactive status to item drawer details.
   - `BIG-278` Add created at date on expense details.
   - `BIG-350` Add empty status content of warehouse transfers service.
+  - `BIG-344` Add branch details to manual journal and expense details.
 ## Fixed
   - `BIG-221` Remove Non-inventory radio choice on item form.
   - `BIG-236` Validate estimate expiration date should be equal or bigger than estimate date.

From 46d895bef9d608f0299292a2f311b218332f9a2e Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Thu, 31 Mar 2022 14:50:40 +0200
Subject: [PATCH 27/28] BIG-354: Validate the warehouse transfer.

---
 .../WarehouseTransferForm/WarehouseTransferForm.js  | 13 -------------
 .../WarehouseTransferForm.schema.js                 |  2 +-
 .../WarehouseTransferFormEntriesTable.js            |  2 +-
 3 files changed, 2 insertions(+), 15 deletions(-)

diff --git a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.js b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.js
index 7a9f77a34..07bcb913e 100644
--- a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.js
+++ b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.js
@@ -71,19 +71,6 @@ function WarehouseTransferForm({
 
   // Handles form submit.
   const handleSubmit = (values, { setSubmitting, setErrors, resetForm }) => {
-    setSubmitting(true);
-    const totalQuantity = sumBy(values.entries, 'quantity');
-
-    if (totalQuantity <= 0) {
-      AppToaster.show({
-        message: intl.get(
-          'warehouse_transfer.quantity_cannot_be_zero_or_empty',
-        ),
-        intent: Intent.DANGER,
-      });
-      return;
-    }
-
     // Transformes the values of the form to request.
     const form = {
       ...transformValueToRequest(values),
diff --git a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.schema.js b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.schema.js
index 026bc5e20..3fab6b29a 100644
--- a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.schema.js
+++ b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.schema.js
@@ -20,7 +20,7 @@ const Schema = Yup.object().shape({
     Yup.object().shape({
       item_id: Yup.number().nullable(),
       description: Yup.string().nullable().max(DATATYPES_LENGTH.TEXT),
-      quantity: Yup.number().nullable().max(DATATYPES_LENGTH.INT_10),
+      quantity: Yup.number().min(1).max(DATATYPES_LENGTH.INT_10),
     }),
   ),
 });
diff --git a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormEntriesTable.js b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormEntriesTable.js
index b4336cb13..09e8f5990 100644
--- a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormEntriesTable.js
+++ b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormEntriesTable.js
@@ -45,7 +45,7 @@ export default function WarehouseTransferFormEntriesTable({
         item_id: newRowMeta.itemId,
         warehouses: newRowMeta.warehouses,
         description: '',
-        quantity: 0,
+        quantity: '',
       };
       const newRows = mutateTableRow(newRowMeta.rowIndex, newRow, entries);
 

From 6daa9f09a5ee88815bbaa4a6325cd38caa9fcf46 Mon Sep 17 00:00:00 2001
From: elforjani13 <39470382+elforjani13@users.noreply.github.com>
Date: Thu, 31 Mar 2022 14:58:36 +0200
Subject: [PATCH 28/28] BIG-354: fix validate the warehouse transfer.

---
 .../WarehouseTransferForm/WarehouseTransferForm.js            | 1 +
 src/lang/ar/index.json                                        | 4 +---
 src/lang/en/index.json                                        | 3 +--
 3 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.js b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.js
index 07bcb913e..1359c6132 100644
--- a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.js
+++ b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.js
@@ -71,6 +71,7 @@ function WarehouseTransferForm({
 
   // Handles form submit.
   const handleSubmit = (values, { setSubmitting, setErrors, resetForm }) => {
+    setSubmitting(true);
     // Transformes the values of the form to request.
     const form = {
       ...transformValueToRequest(values),
diff --git a/src/lang/ar/index.json b/src/lang/ar/index.json
index cf6eb0632..48edb6793 100644
--- a/src/lang/ar/index.json
+++ b/src/lang/ar/index.json
@@ -2005,7 +2005,5 @@
   "receipt.warehouse_button.label": "المخزن: {label}",
   "warehouse_transfer.empty_status.title": "إدارة عمليات النقل بين المستودعات",
   "warehouse_transfer.empty_status.description": "غالبًا ماتحتاج الاعمال ذات مستودعات متعددة لطلبات نقل البضائع من مستودع إلى آخر عندما تكون في حاجة ماسة إلى البائعين.",
-  "item.error.you_could_not_delete_item_has_associated": "لا يمكنك حذف العنصر لديه معاملات مرتبطة به ",
-  "warehouse_transfer.quantity_cannot_be_zero_or_empty": "لا يمكن أن تكون الكمية صفراً أو فارغة."
-
+  "item.error.you_could_not_delete_item_has_associated": "لا يمكنك حذف العنصر لديه معاملات مرتبطة به "
 }
\ No newline at end of file
diff --git a/src/lang/en/index.json b/src/lang/en/index.json
index 5911e4753..2224f1074 100644
--- a/src/lang/en/index.json
+++ b/src/lang/en/index.json
@@ -2006,6 +2006,5 @@
   "warehouse_transfer.empty_status.title": "Manage transfer orders between warehouses.",
   "warehouse_transfer.empty_status.description": "Business with multiply warehouses often transfers items from on warehouse to another when they are in immediate need of vendors.",
   "warehouse_transfer.form.reason.label": "Reason",
-  "warehouse_transfer.form.reason.placeholder": "Enter the reason behind the transfer order.",
-  "warehouse_transfer.quantity_cannot_be_zero_or_empty": "Quantity cannot be zero or empty."
+  "warehouse_transfer.form.reason.placeholder": "Enter the reason behind the transfer order."
 }
\ No newline at end of file