From 1e4b29f83c8caba2ce6aec7f7fe8dd6e5d21796c Mon Sep 17 00:00:00 2001
From: Ahmed Bouhuolia <a.bouhuolia@gmail.com>
Date: Sun, 14 Jan 2024 15:59:25 +0200
Subject: [PATCH] fix: content tweaks in rates re-calc popover

---
 .../ExchangeRate/ExchangeRateInput.tsx        | 24 +++++++++++--------
 .../InvoiceExchangeRateChangeDialog.tsx       | 16 ++++---------
 2 files changed, 19 insertions(+), 21 deletions(-)

diff --git a/packages/webapp/src/components/ExchangeRate/ExchangeRateInput.tsx b/packages/webapp/src/components/ExchangeRate/ExchangeRateInput.tsx
index caf2f3d58e..d96d91231a 100644
--- a/packages/webapp/src/components/ExchangeRate/ExchangeRateInput.tsx
+++ b/packages/webapp/src/components/ExchangeRate/ExchangeRateInput.tsx
@@ -8,6 +8,7 @@ import {
   ControlGroup,
   Intent,
   Popover,
+  Position,
   Spinner,
 } from '@blueprintjs/core';
 import { FlagIcon } from '../Tags';
@@ -106,31 +107,30 @@ export function ExchangeRateInputGroup({
   const popoverConfirmContent = (
     <PopoverContent>
       <p>
-        Are you want to re-calculate item prices based on this exchange rate
+        Are you want to re-calculate item prices based on this exchange rate.
       </p>
       <div
         style={{
           display: 'flex',
-          justifyContent: 'flex-end',
           marginTop: 15,
         }}
       >
         <Button
+          intent={Intent.WARNING}
           className={Classes.POPOVER_DISMISS}
-          style={{ marginRight: 10 }}
-          onClick={handleCancelBtn}
+          onClick={handleRecalcConfirmBtn}
           small
-          minimal
         >
-          Cancel
+          Calculate
         </Button>
         <Button
-          intent={Intent.WARNING}
           className={Classes.POPOVER_DISMISS}
-          onClick={handleRecalcConfirmBtn}
+          style={{ marginRight: 10 }}
+          onClick={handleCancelBtn}
           small
+          minimal
         >
-          Re-calculate
+          Cancel
         </Button>
       </div>
     </PopoverContent>
@@ -144,7 +144,11 @@ export function ExchangeRateInputGroup({
         </ExchangeRatePrepend>
 
         {withPopoverRecalcConfirm ? (
-          <Popover isOpen={isOpen} content={popoverConfirmContent}>
+          <Popover
+            isOpen={isOpen}
+            content={popoverConfirmContent}
+            position={Position.RIGHT}
+          >
             {exchangeRateField}
           </Popover>
         ) : (
diff --git a/packages/webapp/src/containers/Sales/Invoices/InvoiceForm/Dialogs/InvoiceExchangeRateChangeDialog.tsx b/packages/webapp/src/containers/Sales/Invoices/InvoiceForm/Dialogs/InvoiceExchangeRateChangeDialog.tsx
index 50771d9137..2880ac383a 100644
--- a/packages/webapp/src/containers/Sales/Invoices/InvoiceForm/Dialogs/InvoiceExchangeRateChangeDialog.tsx
+++ b/packages/webapp/src/containers/Sales/Invoices/InvoiceForm/Dialogs/InvoiceExchangeRateChangeDialog.tsx
@@ -10,9 +10,7 @@ import { Button, Classes, Intent } from '@blueprintjs/core';
  */
 function InvoiceExchangeRateChangeDialog({
   dialogName,
-  payload: { initialFormValues },
   isOpen,
-  onConfirm,
   // #withDialogActions
   closeDialog,
 }) {
@@ -23,6 +21,7 @@ function InvoiceExchangeRateChangeDialog({
   return (
     <Dialog
       name={dialogName}
+      title={'Kindly take care of new rates'}
       autoFocus={true}
       canEscapeKeyClose={true}
       isOpen={isOpen}
@@ -31,18 +30,13 @@ function InvoiceExchangeRateChangeDialog({
       <DialogSuspense>
         <div className={Classes.DIALOG_BODY}>
           <p>
-            You have changed customer's currency after adding items to the
-            Invoice.
-          </p>
-
-          <p>
-            The item rates have been adjusted to the new currency using exchange
-            rate feeds.
+            The item rates have been <strong>adjusted</strong> to the new
+            currency using realtime exchange rate.
           </p>
 
           <p style={{ marginBottom: '30px' }}>
-            Before saving the transaction, ensure that the item rates align with
-            the current exchange rate of the newly selected currency.
+            Make sure to check that the item rates match the current exchange
+            rate of the newly selected currency before saving the transaction.
           </p>
         </div>