Skip to content

Commit

Permalink
Clean up Makefile
Browse files Browse the repository at this point in the history
  • Loading branch information
cbrnr committed Feb 11, 2024
1 parent 37b3bf2 commit 912a446
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ you can run tests by making use of the `Makefile` and
From the project root, call:

- `make test` to run tests and coverage
- `make pep` to run style checks
- `pre-commit run` to run style checks (Ruff and some additional hooks)

## Building the documentation

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
- name: Check formatting
if: ${{ matrix.platform == 'ubuntu-22.04' && matrix.python-version == '3.11' }}
run: |
make pep
make check-manifest
pre-commit run --all-files || ( git status --short ; git diff ; exit 1 )
- name: Test with pytest
Expand Down
10 changes: 2 additions & 8 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.PHONY: all inplace test check-manifest pep build-doc dist-build
.PHONY: all inplace test check-manifest build-doc dist-build

all: inplace pep test build-doc dist-build
all: inplace check-manifest test build-doc dist-build

inplace:
@echo "Installing pybv"
Expand All @@ -16,12 +16,6 @@ check-manifest:
@echo "Running check-manifest"
@check-manifest

ruff:
@echo "Running ruff"
@ruff .

pep: ruff check-manifest

build-doc:
@echo "Building documentation"
make -C docs/ clean
Expand Down

0 comments on commit 912a446

Please sign in to comment.