Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect warnings: TaskName key in channels.tsv, and events.tsv missing for noise #2154

Closed
Moo-Marc opened this issue Oct 10, 2024 · 3 comments

Comments

@Moo-Marc
Copy link

I get this error for MEG *_channels.tsv files:
warning: SIDECAR_KEY_RECOMMENDED (TaskName)
But that's clearly wrong for channel lists, and it's not in the specification.

There's another warning that could be improved. Currently, it warns of missing events.tsv file, but recognizes "rest" tasks as not needing it. Another task that doesn't need events is an empty room noise recording, "noise". The validator should check that word too and prevent this warning.

Cheers

effigies referenced this issue in effigies/bids-specification Oct 10, 2024
@effigies
Copy link
Collaborator

The emptyroom problem was also noted in https://github.com/bids-standard/bids-validator/issues/2137 and should be resolved by the latest development version.

Added a fix for this to bids-standard/bids-specification#1941

@Moo-Marc
Copy link
Author

@effigies @rwblair As I commented in bids-standard/bids-validator#12 (but I forgot to tag anyone so it was probably missed), noise recordings may be inside "normal" subject folders instead of sub-emptyroom, so that fix doesn't work in general. I believe checking task-noise is the way to go.

@effigies effigies reopened this Oct 16, 2024
@effigies
Copy link
Collaborator

Actually, reopening bids-standard/bids-validator#12 instead of this one, since it's more focused on this one problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants