Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunk entity not covered by validator? #1582

Closed
jcohenadad opened this issue Jan 12, 2023 · 7 comments
Closed

chunk entity not covered by validator? #1582

jcohenadad opened this issue Jan 12, 2023 · 7 comments

Comments

@jcohenadad
Copy link

Hello! I have a dataset that contains the chunk entity, which is valid in v1.8.0 (see here). However, I am getting a bids-validator error: test_bids_errors.txt

Dummy dataset for testing: test_bids.zip

Is it because the BIDS validator is not (yet) covering this entity? Or did I do something stupid with my naming?

Thanks!

@Remi-Gau
Copy link
Contributor

@jcohenadad
Copy link
Author

Thank you for the insights @Remi-Gau !

How do people refer to various FOV chunks, which is pretty common in MRI

@Remi-Gau
Copy link
Contributor

The acquisition label ?
Really not sure. But this would be my first response from the top of my head.

@jcohenadad
Copy link
Author

Hum, that’s too bad because the definition of chunk is much closer to that of acq for describing different FOVs acquired on the same subject in the same imaging session:

Definition: The chunk- key/value pair is used to distinguish between different regions, 2D images or 3D volumes files, of the same physical sample with different fields of view acquired in the same imaging experiment.

Maybe there is already a BEP that plans to make a wiser use of chunk? @mariehbourget @SylvainTakerkart do you know by any chance?

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Jan 13, 2023 via email

@jcohenadad
Copy link
Author

In theory we could add an entity from one datatype to an another existing datatype without needing a whole bep. Maybe open an issue in the specification describing your use case and motivations.

👍 bids-standard/bids-specification#1382

@SylvainTakerkart
Copy link

this would make sense to me, this indeed would be consistent with the BIDS microscopy chunking...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants