-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edf file naming #72
Comments
I'm not sure I understand the problem, so let me think out loud:
To (1) I'd say don't worry, make sure EDF to tsv.gz files + JSONs works well and leave the naming for the very end. |
Maybe @yarikoptic can give us a much better response given his experience with reproin and heudiconv (although, reproin uses your option 3) Also, Yarik may be able to tell us if heudiconv has "hooks" where eye2bids could be called. That must have an interface and maybe the problem turns into just adopting it. |
The folder thing we somewhat "control" through the --output_dir flag
Subject number is not encoded in the edf file, taskname can be recorded if the user defines it beforehand but not everyone does that.
That's my actual question. Because they can give the edf file a name with only 8 characters it would not be possible for them to let the eyelink give them a file named "sub-01_taskname.edf" because subject encoding already takes 6 characters. Of course, they can rename the file straight after acquisition but that we would need them to do then. So, as I see it, we can
|
quite FYI for context ideally I would prefer to leave a lot of this mapping be handled by "real" BIDS converters that already do that well (heudiconv, dicom2bids, bidscoin...) and to have eye2bids be just a "plugin" for those that would handle the data wrangling for them. sorry for the brevity, ask me questions if this is too confusing |
agreed, this is why I summoned @yarikoptic here :) |
ok, I don't know the other converters well enough. I'll wait for Yariks reply Just wanted to make sure that this is also considered for people who don't combine eyetracking with other modalities but have only eyetrack & behavior data. |
FYI had also talked briefly with Marcel Zwiers who maintains bidscoin that has a plugin system |
Unfortunately
We do rely (although can be overloaded from command line or a helper script) on subject id to come from as entered on data acquisition system and given to us in DICOM files.
I am not familiar with EyeLink system -- is there any way for preparing "experiment protocols" like it is done on MRI systems , see e.g. this image ? or entering extra metadata? Is there time metadata in the file? If yes -- what I am thinking -- if this eye tracking data is to be associated with other imaging data, then it is closer to our https://github.com/ReproNim/reprostim/ project where given a video file we need to cut out a piece (yet to do) and associate with a specific data file in an existing BIDS dataset. Then common use case would be more of just providing .edf file and BIDS dataset, and tool figuring out appropriate file (based on timing in Is there metadata in .edf about particulars of data acquisition like which eye it is etc? |
For collecting the data on the Host-PC (=EyeLink PC), you are limited to 8 characters and you can not change this (apparently, I'm not doing eyetracking myself...however, looking at the code eyelink gives I doubt it a bit, but I'm no expert). However, while you transfer the data to your main computer (=computer where experiment is displayed to participant and data is eventually saved), you can rename the file during this process. This is automatically done IF you coded it before. It is apparently easy to make use of this as this function comes with the EyeLink code templates, so the User really only has to type in the filename in this function. So what they could do is just give the subject number as input for the pop-up window before the experiment (host-pc) and hard-code the taskname in their code to be added to the subject number while transferring it to main-pc and folder. My question was more about how much we want to control by the converter regarding filename and how much we want to "serve" the users/how much to leave to the users to care about it themselves. Because I'm not sure how common a practice this file-renaming while transferring is.
In the edf file we have metadata about which eye and a timestamp like this: Mon Sep 9 16:48:07 2013. So this could be helpful for this issue when combined with other modalities. My concerns were more regarding the researchers doing purely eyetracking without any other modalities. |
Hi, |
Not that I'm aware of, however Eyelink provide a rich file with different settings and metadata, eye2bids aim at collecting these info and putting them in the json following the standards we agreed on with the BEP.
Well, if you refer to when the data were collected, yes.
It is a good proposal, I however feel it is a different endeavor for eye2bids which TMO aim first at converting "raw" data while leaving other softwares or user deal with file naming.
Yes and we are parsing them now in eye2bids together with other things. |
EyeLink only allows 8 characters when recording the data. In our converter we only add the suffix but we do not code subject number or task name. Do we want users to have their files already named "sub-01_taskname" before conversion or do we want to add something that allows the user to insert it during the conversion process?
The text was updated successfully, but these errors were encountered: