Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation generates a message about needing to "trust this site" #45

Closed
arokem opened this issue Dec 14, 2021 · 2 comments · Fixed by #88
Closed

Validation generates a message about needing to "trust this site" #45

arokem opened this issue Dec 14, 2021 · 2 comments · Fixed by #88
Labels
impact: high Estimated high impact task

Comments

@arokem
Copy link

arokem commented Dec 14, 2021

The validator website includes the message that "Note: Selecting a dataset only performs validation. Files are never uploaded."

However, when data is selected for upload the browser counters with something like this (Chrome):

Screen Shot 2021-12-14 at 9 29 06 AM

Or like this (Firefox):
Screenshot 2021-12-14 at 18 35 39

As noted by @robertoostenveld, this is not in the validator code-base, but comes from the browser itself. The question is whether there is any way to prevent the browser from raising this, or some other way to mitigate this.

@sappelhoff sappelhoff added the impact: high Estimated high impact task label Dec 14, 2021
@nellh
Copy link
Member

nellh commented Dec 14, 2021

There isn't a way to avoid this while targeting the browser since you are exposing the files to network loaded JavaScript that could do anything with them. We may be able to slightly improve how this looks to a user by accessing via the File System Access API instead of a input form element but this API is Blink only at the moment and I think that makes it unsuitable for the validator. Here's an example of asking for read only access to a directory looks like with this API though in case it gains wider browser support (screenshot from Chrome).

image

There's some specification level discussion of adding support for installed PWAs to persist filesystem permissions but I don't expect it to be implemented anytime soon. For now, an installed PWA just shows the same permission request as any other webpage when prompting for the filesystem access and asks each time it is opened.

@effigies effigies transferred this issue from bids-standard/legacy-validator Nov 5, 2024
@effigies
Copy link
Contributor

effigies commented Nov 7, 2024

Nothing to do here, but this is being discussed in #88, so I'll plan to close this with that merge unless someone disagrees.

@effigies effigies mentioned this issue Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: high Estimated high impact task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants