Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add interpretation of "n/a" onsets in events.tsv files #1966

Merged
merged 2 commits into from
Oct 28, 2024
Merged

[ENH] Add interpretation of "n/a" onsets in events.tsv files #1966

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c48f58
fix 1943
Remi-Gau Oct 21, 2024
de4db09
mv
Remi-Gau Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/schema/objects/columns.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ onset:
Onset (in seconds) of the event, measured from the beginning of the acquisition
of the first data point stored in the corresponding task data file.
Negative onsets are allowed, to account for events that occur prior to the first
stored data point.
stored data point. A `n/a` value indicates the onset time is unknown or unavailable.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this to the bottom to avoid breaking up discussion of negatives. And maybe "A value of n/a..." to get around the a/an weirdness with consonants like n (I would use "an n/a").

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved actually at the end of the whole section

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this. I think n/a is fine. The description for onset now seems to be parallel to the description for duration.

For example, in case there is an in-scanner training phase that begins before
the scanning sequence has started events from this sequence should have
negative onset time counting down to the beginning of the acquisition of the
Expand Down