From 0f12c7e348086e0b8189d92ff06d24aa7f0124e4 Mon Sep 17 00:00:00 2001 From: Horea Christian Date: Mon, 1 May 2023 16:02:26 -0400 Subject: [PATCH 1/2] Zero can be an index --- src/common-principles.md | 2 +- src/schema/objects/formats.yaml | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/common-principles.md b/src/common-principles.md index 0285a3704d..69aa738149 100644 --- a/src/common-principles.md +++ b/src/common-principles.md @@ -709,7 +709,7 @@ for naming of participants, sessions, acquisition schemes. Note that they MUST consist only of allowed characters as described in [Definitions](common-principles.md#definitions) above. In ``es we RECOMMEND using zero padding (for example, `01` instead of `1` -if you have more than nine subjects) to make alphabetical sorting more intuitive. +if you have more than ten subjects) to make alphabetical sorting more intuitive. Note that zero padding SHOULD NOT be used to merely maintain uniqueness of ``es. diff --git a/src/schema/objects/formats.yaml b/src/schema/objects/formats.yaml index 88d1bafbe5..71e613a871 100644 --- a/src/schema/objects/formats.yaml +++ b/src/schema/objects/formats.yaml @@ -4,9 +4,8 @@ index: display_name: Index description: | - Non-negative, non-zero integers, optionally prefixed with leading zeros for sortability. - An index may not be all zeros. - pattern: '[0-9]*[1-9]+[0-9]*' + Non-negative, optionally prefixed with leading zeros for better visual homogeneity and sorting. + pattern: '[0-9]*' label: display_name: Label description: | From 86e06a5c29f7bb352a4806dbb3dac539d6e3a17a Mon Sep 17 00:00:00 2001 From: Horea Christian Date: Mon, 1 May 2023 19:10:19 -0400 Subject: [PATCH 2/2] Expression correction and more accurate description Co-authored-by: Christopher J. Markiewicz --- src/common-principles.md | 2 +- src/schema/objects/formats.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/common-principles.md b/src/common-principles.md index 69aa738149..2565b8076c 100644 --- a/src/common-principles.md +++ b/src/common-principles.md @@ -709,7 +709,7 @@ for naming of participants, sessions, acquisition schemes. Note that they MUST consist only of allowed characters as described in [Definitions](common-principles.md#definitions) above. In ``es we RECOMMEND using zero padding (for example, `01` instead of `1` -if you have more than ten subjects) to make alphabetical sorting more intuitive. +if some participants have two-digit labels) to make alphabetical sorting more intuitive. Note that zero padding SHOULD NOT be used to merely maintain uniqueness of ``es. diff --git a/src/schema/objects/formats.yaml b/src/schema/objects/formats.yaml index 71e613a871..e0704bee31 100644 --- a/src/schema/objects/formats.yaml +++ b/src/schema/objects/formats.yaml @@ -5,7 +5,7 @@ index: display_name: Index description: | Non-negative, optionally prefixed with leading zeros for better visual homogeneity and sorting. - pattern: '[0-9]*' + pattern: '[0-9]+' label: display_name: Label description: |