[INFRA] add election banner #1278
Conversation
mkdocs.yml
Outdated
| features: | ||
| - navigation.sections | ||
| - header.autohide |
There was a problem hiding this comment.
FYI this will hide a the top banner as people scroll down.
Codecov Report
@@ Coverage Diff @@
## master #1278 +/- ##
=======================================
Coverage 88.53% 88.53%
=======================================
Files 6 6
Lines 1055 1055
=======================================
Hits 934 934
Misses 121 121 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This is very rudimentary in terms of stilling. Just to see what people think of the idea. |
There was a problem hiding this comment.
LGTM, together with
- setting "dev" as the default page for this short period
- adding an additional warning that this is "dev", not stable (if possible to reverse what you described in Add option to toggle announcements on the spec website #1276 (comment))
Co-authored-by: Stefan Appelhoff <[email protected]>
that has to be changed on Read the docs, no? |
|
Making a couple a aesthetic / readability changes. Centering a div should be easy, right? (FLW) |
|
Discussed at maintainers meeting. Probably better to try to use some Javascript to display a banner on all versions than just a banner on a single one. |
|
@Remi-Gau I am afraid we let the perfect be the enemy of the good for this one here and now the nomination period is already over 🙈 should we just close this and its corresponding issue? or do you want to use this to implement a mechanism that we can easily switch on/off for the next nomination period? |
|
leave it open or maybe let's have it as a draft last meeting it was decided we were just going to javascript the 💩 out of this. |
closes #1276