Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update (new version) of MEF3 format (MED). #1931

Closed
MEDFormat opened this issue Sep 26, 2024 · 15 comments · Fixed by #1956
Closed

Update (new version) of MEF3 format (MED). #1931

MEDFormat opened this issue Sep 26, 2024 · 15 comments · Fixed by #1956
Labels

Comments

@MEDFormat
Copy link
Contributor

MEDFormat commented Sep 26, 2024

Hello,

I am Matt Stead, the creator of all the MEF formats (1-3). The new version MEF version (MED) is faster & produces better compression than its predecessors. It continues to be HIPAA & IRB compliant. A fuller description of MED is available on https://MEDFormat.org.

I currently have 4 groups asking me about official BIDS compatibility.

MED data can be read in open source multiple tools (Matlab, FieldTrip, EEGLab, Python , Neo).

These tools are freely available in compiled form for all major platforms (MacOS, Linux, Windows) as well as having source code and specification documents available on https://github.com/MEDFormat.

There are also multiple free data converters (MEF, EDF, DAT, Neuralynx (NCS & NRD), & NATUS) available.

I would be happy to make the pull request for this.

@bids-standard/raw-electrophys-ieeg

@effigies
Copy link
Collaborator

effigies commented Sep 26, 2024

FWIW I'm +1 on this, but I don't work with these data.

I believe the places to update in the schema would be:

I did open MEDFormat/MEDPython#6, though. The usability of a GPL'd Python library is questionable if users do not want to GPL their own code. I am having trouble digging up references, but I recall seeing some lack of clarity whether Python's import mechanism triggered LGPL or not. IIRC the most similar license that was definitely safe for use in non-GPL Python projects was the Mozilla Public License v2.


Edit: Got a reply at MEDFormat/MEDPython#6 (comment). import dhn_med_py is not considered to trigger GPL restrictions by the authors.

@dorahermes
Copy link
Member

I am +1 on this as well, as long as we can make sure that the old MEF3 format remains valid.

@cimbi
Copy link

cimbi commented Oct 5, 2024

Totally agree with this we already started using MED in BIDS.

@EmmanuelBarbeau
Copy link

Hi all, we fully support this as we would also like to use MED in BIDS in our Epilepsy Research Group.

@michaelpereira73
Copy link

Hello everyone, we are also a few research groups in Grenoble, France to use the MED format and are hoping for it to be included in the BIDS format! Thank you.

@KLehongre
Copy link

Hello, I confirm that having MED in BIDs would be really useful for the management and sharing of the data of our database. Thank you!

@tjr1
Copy link

tjr1 commented Oct 10, 2024

We'd be very glad to have both MED and MEF3 in BIDS!

@dorahermes
Copy link
Member

I think @effigies described the next steps above. Are there any examples you are interested in adding as well?

@MEDFormat
Copy link
Contributor Author

MEDFormat commented Oct 10, 2024 via email

@MEDFormat
Copy link
Contributor Author

MEDFormat commented Oct 15, 2024 via email

@effigies
Copy link
Collaborator

I'll merge those into a single PR...

@effigies
Copy link
Collaborator

Hi all. If iEEG users (ping @dorahermes @cimbi @EmmanuelBarbeau @michaelpereira73 @KLehongre @tjr1, who have chimed in already) could have a review of https://github.com/bids-standard/bids-examples/pull/469/files to make sure that it looks correct, that would be greatly appreciated.

@MEDFormat provided an emptied data directory, and I updated it along the lines of the already existing ieeg_epilepsy example. Validation is passing on the schema validator using the schema changes proposed in #1956. I have not made a plan to update the legacy validator, though it would not be difficult if someone wants this to be available in the legacy validator (you would just update these lines).

The main thing that needs review is that this dataset would be understandable to iEEG researchers and work with BIDS tools.

@MEDFormat
Copy link
Contributor Author

MEDFormat commented Oct 28, 2024 via email

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Nov 8, 2024

From what I can see it looks like MED is BIDS approved. If I’m wrong about that, please let me know.

just to be pedantic: things become "official"' in BIDS when there is a new release (usually when a BIDS extension proposal is merged), so until there is a new release, features that have been merged in the default branch of the specification are not yet will only become official BIDS approved on the next release

We usually have 1or 2 releases a year and the last one was in September.

@MEDFormat
Copy link
Contributor Author

MEDFormat commented Nov 8, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants