-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Potential BUG] Task events is modality-specific? #1751
Comments
To make sure I understand, you are saying that eventhough an events.tsv file will in most cases be found in a datatype subfolder, the rules that apply to them are the same irrespective of the datatype and that therefore it feels strange to have those in the "modality specific" section if the spec? |
Correct -- the thought process is what kind of modality task events are? |
The fact that task was specific to some datatypes seems less and less true now. So it may be worth moving that up one level. |
I agree with @oesteban. Also I think that task event is a misnomer in that event files contain markers for things that happen during the experiment. Sometimes these are not related to the task but markers on the experimental time line for other things. |
@VisLab - you may be interested in #1750. In fact, BIDS has already Regarding the asynchronous events that are not task-related, we hit that issue pretty hard in BEP 020 #1128 and are about to propose a
Anyways - we are trying to improve these aspects of the spec step-by-step and #1750 is on top of the list. |
Bringing the conversation from #1868. I think there are two aspects here:
|
I agree with 1. above... However...
I have strong reservations about a "separation" proposal. In most experiments and analysis that I am familiar with, the experimental markers come out from various places and are merged into a single time line associated with the imaging and put into the The proposed separation would require people to separate these into separate files. But which things go where is somewhat arbitrary and they would end up being mapped into the same time line for analysis. |
Describe your problem in detail.
Currently, task events are presented as modality-specific.
Describe what you expected.
That task events are cross-modality.
BIDS specification section
https://bids-specification.readthedocs.io/en/stable/modality-specific-files/task-events.html
The text was updated successfully, but these errors were encountered: