-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow Levels values (in sidecar for TSV files) to be objects #1573
Comments
Could you provide an example of what the object could look like? |
@Remi-Gau Would a JSON or a HED object do alright? |
Hey, sorry for the delay here - and thanks @Remi-Gau for creating the issue! As far as I understand, the {
"MeasurementToolMetadata": {
"Description": "Adult ADHD Clinical Diagnostic Scale V1.2",
"TermURL": "https://www.cognitiveatlas.org/task/id/trm_5586ff878155d"
}
"adhd_c_dx": {
"Description": "As child met A, B, C, D, E and F diagnostic criteria",
"Levels": {
"1": "YES",
"2": "NO"
}
}
} The problem is that this only allows us to put a human readable description (e.g. So what we would like to propose is to turn the allowed values for {
"MeasurementToolMetadata": {
"Description": "Adult ADHD Clinical Diagnostic Scale V1.2",
"TermURL": "https://www.cognitiveatlas.org/task/id/trm_5586ff878155d"
}
"adhd_c_dx": {
"Description": "As child met A, B, C, D, E and F diagnostic criteria",
"Levels": {
"1": {
"TermURL": "https://myhappyontology.org/vocab/controlled_term_yes",
"Label": "Yes"
},
"2": "NO"
}
}
} so that machines and humans can coexist peacefully. For now in neurobagel, we have instead created a new key |
Also pinging @alyssadai here because she is also working on our current specification for these semantically annotated BIDS sidecar files. |
Good catch @ericearl given that this could potentially affect all TSV in bids it would be good to make sure that this plays well with anything that is coupled with them. @VisLab what would be your take on having annotations of levels in TSV files that match what the suggestion from @surchs above? as far as I can tell this would cause any problem with HED but maybe I am missing something. |
Worth noting that the Motion BEP is moving some of its metadata into levels objects, so there's other demand for this (#1524/#1591). I'm +1 on relaxing |
|
Description is free-form, so intended for communication to a human reader. I would say it's reasonable for a tool to fetch TermURL and find its display value there. |
Your idea
was raised during a meeting at OHBM that some project invovled with phenotypic annotation (neurobagel) may greatly benefit if the data type for TermURL (in the sidecar json of TSV files) could be a json object instead of just string.
Opening an issue here to to start the conversation.
@ericearl @jbpoline @nikhil153 @surchs @michellewang @bcmcpher
The text was updated successfully, but these errors were encountered: