From e50373d88f102f5c2202389d12a9bc737867eef8 Mon Sep 17 00:00:00 2001 From: jwelzel <52565341+JuliusWelzel@users.noreply.github.com> Date: Tue, 2 May 2023 13:51:23 +0200 Subject: [PATCH] [FIX] motion channel types: remove ANGVEL, rename ANGACC -> ANGACCEL (#1478) * [FIX] remove ANGVEL channel in motion channel types * remove motion angvel ch type from schema * ANGACC --> ANGACCEL --------- Co-authored-by: Stefan Appelhoff --- src/modality-specific-files/motion.md | 3 +-- src/schema/objects/columns.yaml | 3 +-- src/schema/objects/metadata.yaml | 4 ++-- src/schema/rules/sidecars/motion.yaml | 2 +- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/modality-specific-files/motion.md b/src/modality-specific-files/motion.md index 886df52e90..1c83de6fe0 100644 --- a/src/modality-specific-files/motion.md +++ b/src/modality-specific-files/motion.md @@ -172,8 +172,7 @@ Note that upper-case is REQUIRED: | **Keyword** | **Description** | | ----------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ACCEL | Accelerometer channel, one channel for each spatial axis. Column component for the axis MUST be added to the *_channels.tsv file (x, y, or z). | -| ANGACC | Angular acceleration channel, one channel for each spatial axis. Column component for the axis MUST be added to the *_channels.tsv file (x, y, or z). | -| ANGVEL | Angular velocity channel, one channel for each spatial axis. Column component for the axis MUST be added to the *_channels.tsv file (x, y, or z). | +| ANGACCEL | Angular acceleration channel, one channel for each spatial axis. Column component for the axis MUST be added to the *_channels.tsv file (x, y, or z). | | GYRO | Gyrometer channel, one channel for each spatial axis. Column component for the axis MUST be added to the *_channels.tsv file (x, y, or z). | | JNTANG | Joint angle channel between two fixed axis belonging to two bodyparts. Angle SHOULD be defined between proximal and distal bodypart in deg. | | LATENCY | Latency of samples in seconds from recording onset (see `acq_time` column of the respective `*_scans.tsv` file). MUST be in form of `s[.000000]`, where `s` reflects whole seconds, and `.000000` reflects OPTIONAL fractional seconds. | diff --git a/src/schema/objects/columns.yaml b/src/schema/objects/columns.yaml index 183851e27c..b4b32c41a5 100644 --- a/src/schema/objects/columns.yaml +++ b/src/schema/objects/columns.yaml @@ -747,8 +747,7 @@ type__motion_channels: type: string enum: - ACCEL - - ANGACC - - ANGVEL + - ANGACCEL - GYRO - JNTANG - LATENCY diff --git a/src/schema/objects/metadata.yaml b/src/schema/objects/metadata.yaml index c7ac94a6a5..75fede833f 100644 --- a/src/schema/objects/metadata.yaml +++ b/src/schema/objects/metadata.yaml @@ -140,8 +140,8 @@ AnatomicalLandmarkCoordinates__mri: type: number minItems: 3 maxItems: 3 -ANGACCChannelCount: - name: ANGACCChannelCount +ANGACCELChannelCount: + name: ANGACCELChannelCount display_name: Angular acceleration channel count description: | Number of angular acceleration channels. diff --git a/src/schema/rules/sidecars/motion.yaml b/src/schema/rules/sidecars/motion.yaml index 9ac6312fb0..981e0b3ad7 100644 --- a/src/schema/rules/sidecars/motion.yaml +++ b/src/schema/rules/sidecars/motion.yaml @@ -61,7 +61,7 @@ motionRecommended: - suffix == "motion" fields: ACCELChannelCount: recommended - ANGACCChannelCount: recommended + ANGACCELChannelCount: recommended GYROChannelCount: recommended JNTANGChannelCount: recommended LATENCYChannelCount: recommended