From ecfbf73e50c449648fd9b5bf1d206cd697117398 Mon Sep 17 00:00:00 2001 From: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> Date: Wed, 6 Mar 2019 12:18:21 +0100 Subject: [PATCH 01/18] =?UTF-8?q?dcm2nii=20=E2=86=92=20dcm2niix?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change dicom converter recommendation from obsolete dcm2nii to modern dcm2niix. --- src/02-common-principles.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/02-common-principles.md b/src/02-common-principles.md index 2138fe03b6..bbe754ea61 100644 --- a/src/02-common-principles.md +++ b/src/02-common-principles.md @@ -206,7 +206,7 @@ possible. Since the NIfTI standard offers limited support for the various image acquisition parameters available in DICOM files, we RECOMMEND that users provide additional meta information extracted from DICOM files in a sidecar JSON file (with the same filename as the `.nii[.gz]` file, but with a `.json` extension). -Extraction of BIDS compatible metadata can be performed using [dcm2nii](https://www.nitrc.org/projects/dcm2nii/) +Extraction of BIDS compatible metadata can be performed using [dcm2niix](https://www.nitrc.org/projects/dcm2nii/) and [dicm2nii](http://www.mathworks.com/matlabcentral/fileexchange/42997-dicom-to-nifti-converter/content/dicm2nii.m) DICOM to NIfTI converters. A provided [validator](https://github.com/bids-standard/bids-validator) From 5ad238bb0566c735188f1c877683130251634a24 Mon Sep 17 00:00:00 2001 From: Chris Gorgolewski Date: Wed, 6 Mar 2019 08:26:31 -0800 Subject: [PATCH 02/18] updated link to dcm2niix --- src/02-common-principles.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/02-common-principles.md b/src/02-common-principles.md index bbe754ea61..ecaf302dc4 100644 --- a/src/02-common-principles.md +++ b/src/02-common-principles.md @@ -206,7 +206,7 @@ possible. Since the NIfTI standard offers limited support for the various image acquisition parameters available in DICOM files, we RECOMMEND that users provide additional meta information extracted from DICOM files in a sidecar JSON file (with the same filename as the `.nii[.gz]` file, but with a `.json` extension). -Extraction of BIDS compatible metadata can be performed using [dcm2niix](https://www.nitrc.org/projects/dcm2nii/) +Extraction of BIDS compatible metadata can be performed using [dcm2niix](https://github.com/rordenlab/dcm2niix) and [dicm2nii](http://www.mathworks.com/matlabcentral/fileexchange/42997-dicom-to-nifti-converter/content/dicm2nii.m) DICOM to NIfTI converters. A provided [validator](https://github.com/bids-standard/bids-validator) From 4f36c755cf9c2c08d1ad8d00dee5febbe0e4eafd Mon Sep 17 00:00:00 2001 From: Elizabeth DuPre Date: Thu, 7 Mar 2019 20:24:17 -0500 Subject: [PATCH 03/18] fix: fixes spelling of continuous --- CONTRIBUTING.md | 2 +- mkdocs.yml | 2 +- ...s.md => 06-physiological-and-other-continuous-recordings.md} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename src/04-modality-specific-files/{06-physiological-and-other-continous-recordings.md => 06-physiological-and-other-continuous-recordings.md} (100%) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1869a5e8d6..b3ccb3db16 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -46,7 +46,7 @@ can validate your changes against the guide using [remark](https://github.com/re [standalone command line tool](https://github.com/remarkjs/remark/tree/master/packages/remark-cli) as well as [a plugin for various text editors](https://github.com/remarkjs/remark-lint#editor-integrations). Remark preserves consistent markdown styling across the contributions. Please ensure before submitting a contribution that you do not have any linter errors in your text editor. You can also use [prettier](https://github.com/prettier/prettier) to automatically correct some of the style issuse that might be found in the proposed changes. -We have deployed a continous integrator ([circle CI](https://circleci.com/)) to further allow for integrating changes continously. The CI is testing that the changes are inline with our standard styling. +We have deployed a continuous integrator ([circle CI](https://circleci.com/)) to further allow for integrating changes continuously. The CI is testing that the changes are inline with our standard styling. GitHub has a helpful page on [getting started with writing and formatting on GitHub](https://help.github.com/articles/getting-started-with-writing-and-formatting-on-github). diff --git a/mkdocs.yml b/mkdocs.yml index 39322ae87c..cc1194b1a6 100644 --- a/mkdocs.yml +++ b/mkdocs.yml @@ -15,7 +15,7 @@ nav: - Electroencephalography: 04-modality-specific-files/03-electroencephalography.md - intracranial Electroencephalography: 04-modality-specific-files/04-intracranial-electroencephalography.md - Task events: 04-modality-specific-files/05-task-events.md - - Physiological and other continous recordings: 04-modality-specific-files/06-physiological-and-other-continous-recordings.md + - Physiological and other continuous recordings: 04-modality-specific-files/06-physiological-and-other-continuous-recordings.md - Behavioral experiments (with no MRI): 04-modality-specific-files/07-behavioral-experiments.md - Longitudinal and multi-site studies: 05-longitudinal-and-multi-site-studies.md - Extending the BIDS specification: 06-extensions.md diff --git a/src/04-modality-specific-files/06-physiological-and-other-continous-recordings.md b/src/04-modality-specific-files/06-physiological-and-other-continuous-recordings.md similarity index 100% rename from src/04-modality-specific-files/06-physiological-and-other-continous-recordings.md rename to src/04-modality-specific-files/06-physiological-and-other-continuous-recordings.md From fabcf9375b97dc075a5b0fa08b2e089c75271c93 Mon Sep 17 00:00:00 2001 From: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> Date: Wed, 20 Feb 2019 09:40:17 +0100 Subject: [PATCH 04/18] New contributor --- CODEOWNERS | 2 +- src/99-appendices/01-contributors.md | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 39a7964049..0ef42927de 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -9,6 +9,6 @@ /src/CHANGES.md @chrisfilo @sappelhoff @CPernet # Individual sections -/src/01-common-principles.md @chrisfilo +/src/01-common-principles.md @chrisfilo @DimitriPapadopoulos /src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md @chrisfilo /src/04-modality-specific-files/03-electroencephalography.md @sappelhoff diff --git a/src/99-appendices/01-contributors.md b/src/99-appendices/01-contributors.md index a530f8325a..491e97ac69 100644 --- a/src/99-appendices/01-contributors.md +++ b/src/99-appendices/01-contributors.md @@ -89,6 +89,7 @@ your name is not listed, please add it. - Dylan Nielson 📖💻🔧 - Guiomar Niso 📖💡📢 - Robert Oostenveld 📖🔧📢💡✅⚠️🤔 +- Dimitri Papadopoulos Orfanos 📖💡🤔💬 - Patrick Park 📖💡💬 - Dianne Patterson 📖 - John Pellman 📖 From f5972b4c21ce44aadb3f09ecfda8585af5b0512e Mon Sep 17 00:00:00 2001 From: Chris Gorgolewski Date: Mon, 4 Mar 2019 09:54:38 -0800 Subject: [PATCH 05/18] Removing leftover file --- .../05-behavioral-experiments.md | 26 ------------------- 1 file changed, 26 deletions(-) delete mode 100644 src/04-modality-specific-files/05-behavioral-experiments.md diff --git a/src/04-modality-specific-files/05-behavioral-experiments.md b/src/04-modality-specific-files/05-behavioral-experiments.md deleted file mode 100644 index 83c2018384..0000000000 --- a/src/04-modality-specific-files/05-behavioral-experiments.md +++ /dev/null @@ -1,26 +0,0 @@ -# Behavioral experiments (with no MRI) - -Template: - -```Text -sub-