You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
so in addition to units, and excluding software_filters (which is a string for a list but without clear formatting stated) there is also hplc_recovery_fractions
hplc_recovery_fractions:
name: hplc_recovery_fractionsdisplay_name: HPLC recovery fractionsdescription: | HPLC recovery fractions (the fraction of activity that gets loaded onto the HPLC).type: numberunit: arbitrary
which is scalar (I thought that they might be a list ;) ), but especially since a scalar -- we should make them into singular as well IMHO and add to common principles (if not there) that should be singular.
The text was updated successfully, but these errors were encountered:
hplc_recovery_fractions is for PET, hence let me inquire @bids-standard/raw-pet -- do you agree that it would be ok to make it singular hplc_recovery_fraction as all the other columns are singular and other fraction(s) too:
Generalization of the
Looking at column names we do not have consistency.
grep '^[a-z]' src/schema/objects/columns.yaml | grep -v __
Dirty list: grep '^[a-z]' src/schema/objects/columns.yaml | grep -v __ | grep 's:'
so in addition to units, and excluding
software_filters
(which is a string for a list but without clear formatting stated) there is also hplc_recovery_fractionswhich is scalar (I thought that they might be a list ;) ), but especially since a scalar -- we should make them into singular as well IMHO and add to common principles (if not there) that should be singular.
The text was updated successfully, but these errors were encountered: