-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the suffix and exclusively use entities in the filename. #58
Comments
As I mentioned in the other thread, this inevitably leads to discussing that the new entity In my opinion, removing the suffix damages human readability with a meager return. |
The BIDS standard already specifies a strict ordering of the entities, and I am not proposing to change that.
|
Sure, that's manageable for BIDS "raw". But the problem scales with the number of entities, and BIDS Derivatives is set out to define a fair bunch.
That proposal does not point at such a problem, only the discussion after it could be interpreted in that way. This proposal (i.e., removing the suffix) does not describe what it is solving. It just opens some flexibility with two goals:
I think (1) is just a countermeasure to open space of agreement on a problem we currently don't have, and (2) leads to total flexibility that will require additional metadata to describe the dataset. (2) is not theoretically a bad idea, but I would honestly move into other alternatives (I said NIDM a bunch of times) with more programmatic and reliable foundations to describe the data. BIDS should offer something easy-to-use and highly readable for humans. |
In general I agree with the motivation for the change. I would only vote to not add again semantically meaningless |
And what is that motivation? I truly don't know what it is. |
ATM suffix has no clear semantic meaning. ATM it aims to be a "human accessible term best describing what is in the file", values for which is a mix of
I think it is as a result of this absent semantical clarity, while contemplating new "suffixes" it becomes unclear what should go into the suffix vs some other entity - should a new suffix be created or an entity be created, or a mix of the two, etc. And that is what I think prompted @robertoostenveld to file this issue. |
Don't we already have this? I've always seen subject and session first, or is this slated to be removed in BIDS2? |
yes, we have clear ordering and AFAIK always had so far. What to be done for BIDS 2.0 or either there would be effect from is yet to be decided about. Not sure what @oesteban had in mind while talking about derivatives since, as @robertoostenveld pointed out the order is universal across modalities and specified in https://github.com/bids-standard/bids-specification/blob/master/src/schema/rules/entities.yaml . Note that |
Above I think I have forgotten to mention another potential suffix purpose (or may be the only one to leave in the scope of #54 ) -
❯ grep '^[^ ]*s:' ./src/schema/objects/suffixes.yaml | grep -v -E 'nirs'
channels:
descriptions:
electrodes:
events:
markers:
optodes:
scans:
sessions:
svs: |
Let me revisit this. The reason to raise this issue in the first place was the discussions that pursued in the drafting stage of multiple BEPs that I followed closely, whether something new should become a new suffix, or whether it should be coded as a (new or existing) entity. This unclarity in the different and quite diverse BEP teams shows that people in general don't understand or agree on the difference between a suffix and an entity. Removing the suffix - as I proposed - would be a way to avoid this, albeit a crude way that certain people appear to dislike. Yarek raises the plurality in Imagine (note this is a thought experiment, not a real proposal) that we were to drop all entities from any file name in a simple BIDS dataset, as already the case for Note that |
The discussion bids-standard/bids-specification#1602 shows that there is no universal agreement on when some information is to be coded as a suffix (at the end of the filename just prior to the extension, e.g.,
_bold
) or as an entity (like<key>-<value>
).I propose to remove that source of conflict in BIDS 2 by removing the suffix altogether. To me the suffix serves the same purpose as the value in an entity, except that the name has been left out. I.e., I propose that
_bold.nii.gz
were to become_suffix-bold.nii.gz
. Instead ofsuffix
, another name (or names) could be given to these entities.The consequence would be that the whole filename up to the first period
.
(which indicates the start of the file extension, see *) can be parsed on the underscore to separate entities, and each entity can be parsed on the dash to split its name and value.*) The file extension (e.g.,
.tsv
,.h5
,.nii.gz
) would remain as it is and provide information about how the file is technically to be parsed as an ascii and/or binary stream.The text was updated successfully, but these errors were encountered: