Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force recomputation #25

Closed
fliem opened this issue Jan 31, 2017 · 6 comments
Closed

force recomputation #25

fliem opened this issue Jan 31, 2017 · 6 comments

Comments

@fliem
Copy link
Contributor

fliem commented Jan 31, 2017

  • At the moment we check if there is a is a {fsid}/scripts/IsRunning.lh+rh file. If it is there we remove the folder and start from scratch.
  • Elseif we check if there is a {fid} folder. If that's the case, we run the resume_cmd. If the recon-all has been completed, that seems to recompute everything.

How about adding an input argument that needs to be set to recompute everything (like --force-recompute)? That way

  • completed subjects that have been submitted to the analysis by mistake won't be computed
  • we could probably run test cases for longitudinal data on circleci by providing the cross-sectional recons and only testing the base and long step (longitudinal tests #23)
@alexlicohen
Copy link
Collaborator

alexlicohen commented Jan 31, 2017

Chris and I had discussed this when I added the resume_cmd for Issue #7, the reason for the current checks is to allow for resuming stages after manual correction, but still allowing for the novice, "run it again to rewrite everything" behavior.

This would change the default behavior to skipping subjects if the subject directory exists unless force-recompute is present, but if you want to run e.g., autorecon3, you would also have to set force-recompute, which may be confusing, but could be explained.

Chris, what do you think?

An alternative could be a --longitudinal2 switch which goes straight to base and long (maybe using the dontrun stages flag).

On further reviewing the code, I believe the stages options is missing from the first round run.py lines 158 and 162, which also needs to be fixed.

@fliem
Copy link
Contributor Author

fliem commented Jan 31, 2017

On further reviewing the code, I believe the stagesoptions is missing from the first round run.py lines 158 and 162, which also needs to be fixed.

That's probably on purpose. If only parts of recon-all -all is run at the cross-sectional phase, it think it is not possible to create a base image.

@alexlicohen
Copy link
Collaborator

alexlicohen commented Jan 31, 2017 via email

@PeerHerholz
Copy link
Collaborator

Ahoi hoi @fliem and @alexlicohen,

was there any further discussion re this?
Otherwise, we could close this issue.

Cheers, Peer

@alexlicohen
Copy link
Collaborator

alexlicohen commented Dec 16, 2020 via email

@PeerHerholz
Copy link
Collaborator

Ok, thx @alexlicohen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants