Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with non-Latin languages #46

Open
atanetfq opened this issue Dec 11, 2024 · 8 comments
Open

Issue with non-Latin languages #46

atanetfq opened this issue Dec 11, 2024 · 8 comments

Comments

@atanetfq
Copy link

Hello,
One of Moodle instances I manage uses Arabic and Hebrew languages.
Once I'm trying to download report all non-Latin characters replaced by ?
example_report.pdf
Thank you in advance for any help

@srobotta
Copy link
Collaborator

srobotta commented Dec 17, 2024

I have addressed your issue in the latest commit in main. I assume this will not yet work in your case, because the selected font doesn not support Hebrew nor Arabic. It would be probably just a matter to add the appropriated fonts as well.
I did test with Cyrillic and Chinese, the first has been fixed, the latter not.

Therefore, could you please give me some more information about your setup?

  • Which language is your site using?
  • Do you use Arabic and Hebrew at the same time (at one Moodle installation)?
  • In case the site is in English? Does the user has Hebrew or Arabic set in his user preferences?

I guess the template need to include several fonts at once and that must be flexible depending on the Moodle site and user settings. I still have no clue yet how to do this in an inteligent way, that the user name is displayed correctly at any time.

@atanetfq
Copy link
Author

Hello and thank you for your response.
The spoken Moodle 4.5 instance has English, Hebrew and Arabic UI.
We use following fonts as they support all those languages pretty well: Segoe UI ,Roboto, Helvetica Neue ,Arial.

@atanetfq
Copy link
Author

btw, how can I contact you to discuss mod_verbalfeedback customization / features request ?

@srobotta
Copy link
Collaborator

srobotta commented Dec 18, 2024

About the fonts: Segoe seems to fix your use case, it works out of the box with latin, cyrillic, arabic and hebrew characters. It does not with chinese or japanese chars. While this is a better solution as the Noto front it's still not perfect. However, the showstopper here is that the license of Segoe does not allow me to bundle it with the plugin.
I didn check the other fonts.
About feature requests: please open a new issue and fill the feature request in there. I am not the only one working at this plugin and because it's open source, there might be other people interested as well in the feature as well might help with the implementation.

@srobotta
Copy link
Collaborator

I have added additional fonts and a handling that should now fix the issue that names are not displayed correcty. This counts for both, students and teachers names. Could you please check if that fix works for you?
Changes are commited in the main branch.

@atanetfq
Copy link
Author

atanetfq commented Jan 2, 2025

Doesn't work
Moodle 4.5.1 (Build: 20241209)
mod_verbalfeedback v4.5-r2

@srobotta
Copy link
Collaborator

srobotta commented Jan 6, 2025

Could you please a bit more specific in the last comment? A screenshot (with personal information blured) and an explanation would help.
Also: at the moment, if you have a list of teachers, the first name is checked only. If you have teachers using latin and hebrew names then the second or follwoing name would not be checked and may not come out well in case it would have to use a different charset.
In my changes I assumed that in a common setup there is one common setting (e.g. have the site in english and teachers and users in hebrew for example - that makes things easier in the background). If that's not your case please let me now.

@atanetfq
Copy link
Author

atanetfq commented Jan 7, 2025

The spoken Moodle has 4 language packs (LP) installed - Hebrew (HE) as default one, Arabic, English (EN) and Russian.
On attached screenshot you can see that translated strings properly displayed in Moodle (both with EN or HE LP).
VERB_HEB_01
Once you try to display PDF report (in this case I used Chrome) the ??? shown instead of Hebrew letters (both with EN or HE LP). If HE LP used, the problem exist both for translated strings or values.
VERB_HEB_02
VERB_HEB_03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants