New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename some of parameters in api_server.toml #23

Open

clarinette9 opened this issue Apr 15, 2022 · 0 comments

Contributor

clarinette9 commented Apr 15, 2022 •

edited

Loading

As reviews of #22 , some of parameters' name in api_server.toml need to be renamed.
Code need to be change accordingly:

Parameters in api_server_toml that need to be renamed:

GracefulTimeOutMs = 5000 -------------> Rename to GracefulTimeoutInMs

ConnMaxIdleTimeMs = 500000 ---------------> Rename to ConnMaxIdleTimeInMs
ConnMaxLifetimeMs = 5000000 ---------------> Rename to ConnMaxLifetimeInMs

SessionExpireDay = 10 ---------------------> Rename to SessionExpireInDay

ilujiez mentioned this issue

rename some of parameters in conf and format api_server.toml #24

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment