Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming issue and implement IAsyncDisposable #163

Open
Poker-sang opened this issue Jun 19, 2024 · 1 comment
Open

Fix naming issue and implement IAsyncDisposable #163

Poker-sang opened this issue Jun 19, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Poker-sang
Copy link

Poker-sang commented Jun 19, 2024

Dowloader's api design is handy and makes sense! But there are some methods with a Task return value, named without using the Async suffix, which confuses me when I use them. The Async suffix is also used in some void methods, such as DowloadService.CancelAsync.

Also I would like DowloadService to use DisposeAsync instead of Clear so that the await using syntax can be used.

Thank you!

@bezzad bezzad self-assigned this Jun 30, 2024
@bezzad bezzad added the enhancement New feature or request label Jun 30, 2024
@bezzad
Copy link
Owner

bezzad commented Jun 30, 2024

The Downloader release for all .Net versions such as .Net Framework 4.6. So the IAsyncDisposable is just supported in .Net Core and can't be used now. But, in the next version, I would remove support old versions from the Downloader and release it just for .Net 6 and 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants